Skip to content

Conversation

@zy-kkk
Copy link
Member

@zy-kkk zy-kkk commented Apr 26, 2024

Proposed changes

Issue Number: close #xxx

Some MySQL JDBC Drivers will automatically send set sql_select_limit='DEFAULT', where value is of String type. In order to avoid errors, I made it compatible

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zy-kkk
Copy link
Member Author

zy-kkk commented Apr 26, 2024

run buildall

@zy-kkk
Copy link
Member Author

zy-kkk commented Apr 26, 2024

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit df227276488155d83cf5346e024345609e14a391, data reload: false

------ Round 1 ----------------------------------
q1	17957	4364	4353	4353
q2	2283	191	211	191
q3	11986	1169	1290	1169
q4	11314	811	716	716
q5	7489	2670	2658	2658
q6	210	131	131	131
q7	1005	628	592	592
q8	9224	2056	2036	2036
q9	8942	6609	6536	6536
q10	8687	3726	3765	3726
q11	454	243	234	234
q12	386	218	225	218
q13	17760	2939	2949	2939
q14	277	227	237	227
q15	512	484	468	468
q16	528	379	384	379
q17	969	649	762	649
q18	8056	7488	7416	7416
q19	1623	1536	1473	1473
q20	642	314	304	304
q21	4933	3260	3307	3260
q22	347	271	283	271
Total cold run time: 115584 ms
Total hot run time: 39946 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4246	4191	4201	4191
q2	377	287	271	271
q3	3034	2773	2807	2773
q4	1862	1558	1595	1558
q5	5325	5288	5305	5288
q6	207	125	124	124
q7	2245	1902	1850	1850
q8	3204	3335	3389	3335
q9	8590	8546	8555	8546
q10	3896	3695	3728	3695
q11	588	496	492	492
q12	791	601	607	601
q13	17161	2917	2931	2917
q14	297	294	288	288
q15	517	476	482	476
q16	463	420	444	420
q17	1745	1496	1487	1487
q18	7602	7530	7506	7506
q19	1666	1557	1563	1557
q20	1983	1760	1794	1760
q21	5021	4768	4768	4768
q22	563	490	472	472
Total cold run time: 71383 ms
Total hot run time: 54375 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 186879 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit df227276488155d83cf5346e024345609e14a391, data reload: false

query1	911	362	350	350
query2	6455	2357	2270	2270
query3	6658	226	209	209
query4	23104	21348	21223	21223
query5	4245	454	450	450
query6	288	190	189	189
query7	4609	294	292	292
query8	246	197	188	188
query9	8446	2321	2315	2315
query10	429	255	255	255
query11	14807	14350	14285	14285
query12	147	91	89	89
query13	1644	366	369	366
query14	9774	7681	7604	7604
query15	258	172	181	172
query16	8153	268	261	261
query17	1836	591	575	575
query18	2121	289	278	278
query19	278	159	158	158
query20	97	89	86	86
query21	208	138	132	132
query22	5099	4897	4878	4878
query23	34853	34188	33384	33384
query24	12902	3049	3008	3008
query25	651	365	367	365
query26	1753	157	149	149
query27	2997	311	316	311
query28	7605	1988	1980	1980
query29	1012	631	604	604
query30	304	151	150	150
query31	997	749	761	749
query32	90	53	56	53
query33	745	255	247	247
query34	1093	484	483	483
query35	837	668	659	659
query36	1074	925	894	894
query37	274	67	67	67
query38	3188	3000	2965	2965
query39	1611	1547	1535	1535
query40	280	134	128	128
query41	43	42	36	36
query42	106	94	94	94
query43	564	536	537	536
query44	1267	729	738	729
query45	284	263	270	263
query46	1076	758	721	721
query47	1900	1854	1860	1854
query48	365	292	290	290
query49	1194	399	402	399
query50	773	380	396	380
query51	6826	6779	6751	6751
query52	98	91	93	91
query53	345	288	283	283
query54	317	240	250	240
query55	78	75	73	73
query56	250	225	222	222
query57	1219	1139	1110	1110
query58	242	203	206	203
query59	3476	3264	3254	3254
query60	269	244	234	234
query61	91	90	89	89
query62	652	450	452	450
query63	305	281	283	281
query64	9485	7138	7094	7094
query65	3128	3040	3102	3040
query66	1379	340	343	340
query67	15395	14907	15083	14907
query68	6784	523	540	523
query69	534	315	308	308
query70	1181	1130	1159	1130
query71	472	273	266	266
query72	7937	2677	2406	2406
query73	721	323	319	319
query74	6592	6093	6055	6055
query75	4358	2717	2657	2657
query76	4341	1016	901	901
query77	787	274	263	263
query78	10862	10516	10314	10314
query79	7455	521	533	521
query80	1209	436	444	436
query81	526	225	229	225
query82	1309	97	104	97
query83	201	168	168	168
query84	278	83	119	83
query85	1558	271	262	262
query86	495	296	308	296
query87	3315	3139	3065	3065
query88	4844	2324	2329	2324
query89	504	408	376	376
query90	2010	184	187	184
query91	129	102	98	98
query92	61	52	50	50
query93	5732	514	500	500
query94	1203	184	179	179
query95	387	301	313	301
query96	607	269	258	258
query97	3140	2944	2936	2936
query98	237	225	217	217
query99	1279	866	841	841
Total cold run time: 304254 ms
Total hot run time: 186879 ms

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 612c84a into apache:master Apr 26, 2024
@zy-kkk zy-kkk deleted the sql_select_limit branch October 22, 2024 09:53
@zy-kkk zy-kkk removed the dev/2.0.x label Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants