[refactor](statistic) fetch statistic data with catalog and database id (#33928) #34202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…id (apache#33928) In previously, all statistic tables have a column named `id`. This column is combined with `tableId` and `indexId`. Because table's id is unique globally, so we can query statistic table by only `id` to fetch the table's statistic data. By for external table, the table's id may not be unique globally. For example, the table id may only be unique within a database. So we need more predicates to fetch the right statistic data. In this PR, I changed all query statements of statistic table, by adding `catalog_id` and `database_id` conditions. For example: ``` SELECT * FROM column_statistics WHERE `id` = '${id}' AND `catalog_id` = '${catalogId}' AND `db_id` = '${dbId}' ``` The content of `id` column in statistic tables remain unchanged, so that after user upgrade Doris, the existing statistic data can still be used.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bp (#33928)