Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Refactor remove the useless code in column vector

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.61% (8966/25176)
Line Coverage: 27.27% (73968/271198)
Region Coverage: 26.50% (38212/144185)
Branch Coverage: 23.30% (19462/83532)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c1c2c7003d6fde86758b3e9a583696e02fdfbf57_c1c2c7003d6fde86758b3e9a583696e02fdfbf57/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 186385 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c1c2c7003d6fde86758b3e9a583696e02fdfbf57, data reload: false

query1	906	358	350	350
query2	6302	2352	2366	2352
query3	6655	210	210	210
query4	23882	21730	21849	21730
query5	3750	411	418	411
query6	256	184	168	168
query7	4525	312	287	287
query8	245	189	188	188
query9	8420	2399	2408	2399
query10	400	259	267	259
query11	15153	14900	14896	14896
query12	120	84	92	84
query13	1650	365	365	365
query14	9710	7644	6534	6534
query15	245	163	167	163
query16	8193	267	266	266
query17	1762	576	555	555
query18	2086	292	268	268
query19	331	149	149	149
query20	89	85	81	81
query21	188	131	124	124
query22	5074	4915	4834	4834
query23	33927	33346	33294	33294
query24	10640	3007	2833	2833
query25	602	380	370	370
query26	1175	150	150	150
query27	2878	320	314	314
query28	7540	2052	2022	2022
query29	872	611	608	608
query30	247	155	151	151
query31	990	699	729	699
query32	94	50	51	50
query33	725	242	238	238
query34	1045	474	473	473
query35	792	649	644	644
query36	1046	926	925	925
query37	141	63	65	63
query38	3140	3051	3013	3013
query39	1587	1565	1540	1540
query40	190	126	125	125
query41	41	37	37	37
query42	110	93	95	93
query43	569	564	532	532
query44	1140	713	726	713
query45	256	243	249	243
query46	1070	709	709	709
query47	1925	1886	1895	1886
query48	369	291	292	291
query49	851	411	378	378
query50	756	392	381	381
query51	6747	6620	6652	6620
query52	106	89	90	89
query53	347	276	277	276
query54	298	236	239	236
query55	78	72	73	72
query56	246	219	211	211
query57	1221	1163	1128	1128
query58	222	196	193	193
query59	3425	3181	3092	3092
query60	253	223	222	222
query61	87	84	87	84
query62	659	453	467	453
query63	303	273	276	273
query64	8702	7205	7166	7166
query65	3091	3055	3057	3055
query66	1336	327	336	327
query67	15661	15006	15068	15006
query68	9741	537	528	528
query69	607	314	308	308
query70	1313	1097	1127	1097
query71	514	266	270	266
query72	8646	2561	2388	2388
query73	1563	314	314	314
query74	6576	6051	6094	6051
query75	4731	2626	2656	2626
query76	5939	944	1037	944
query77	639	265	254	254
query78	11161	10291	10319	10291
query79	11441	533	525	525
query80	1690	446	461	446
query81	505	215	221	215
query82	247	89	94	89
query83	205	163	164	163
query84	272	87	84	84
query85	1106	272	256	256
query86	351	319	294	294
query87	3258	3090	3045	3045
query88	5426	2325	2323	2323
query89	518	387	368	368
query90	2400	188	183	183
query91	127	96	98	96
query92	64	48	49	48
query93	7076	496	497	496
query94	1548	178	185	178
query95	411	313	310	310
query96	607	267	264	264
query97	3092	2932	2958	2932
query98	241	218	222	218
query99	1046	883	834	834
Total cold run time: 310503 ms
Total hot run time: 186385 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2024

PR approved by anyone and no changes requested.

Copy link
Contributor

@luozenglin luozenglin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 0c0053d into apache:master May 6, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
zhangstar333 pushed a commit to zhangstar333/incubator-doris that referenced this pull request Jul 15, 2024
morningman pushed a commit that referenced this pull request Jul 15, 2024
…4432) (#37827)


cherry-pick from master #34432

Co-authored-by: HappenLee <happenlee@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants