Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

fix bug const one column floor error in regression test,by pr:#34391

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@HappenLee
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40675 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8043be5b322d7b450356c4a0a3ae19f4bc72ce3a, data reload: false

------ Round 1 ----------------------------------
q1	17930	4484	4360	4360
q2	2531	188	195	188
q3	10895	1171	1190	1171
q4	11606	839	799	799
q5	8480	2680	2706	2680
q6	213	131	130	130
q7	1034	605	566	566
q8	9227	2095	2058	2058
q9	9150	6570	6475	6475
q10	8972	3754	3689	3689
q11	463	241	249	241
q12	468	220	229	220
q13	17765	2958	2949	2949
q14	253	215	216	215
q15	525	479	472	472
q16	509	385	374	374
q17	959	600	790	600
q18	8024	7439	7452	7439
q19	1637	1526	1539	1526
q20	659	307	303	303
q21	5074	3950	3934	3934
q22	348	289	286	286
Total cold run time: 116722 ms
Total hot run time: 40675 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4399	4260	4213	4213
q2	359	278	269	269
q3	3001	2716	2709	2709
q4	1855	1621	1614	1614
q5	5286	5268	5280	5268
q6	210	128	128	128
q7	2254	1894	1915	1894
q8	3209	3364	3340	3340
q9	8438	8476	8482	8476
q10	3893	3686	3713	3686
q11	585	496	502	496
q12	759	591	599	591
q13	17398	2975	3003	2975
q14	299	263	277	263
q15	514	487	497	487
q16	463	414	417	414
q17	1756	1469	1460	1460
q18	7628	7664	7485	7485
q19	4995	1475	1532	1475
q20	1998	1759	1783	1759
q21	4935	4800	4925	4800
q22	579	518	521	518
Total cold run time: 74813 ms
Total hot run time: 54320 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.64% (8970/25169)
Line Coverage: 27.28% (74024/271321)
Region Coverage: 26.51% (38233/144243)
Branch Coverage: 23.31% (19488/83610)
Coverage Report: http://coverage.selectdb-in.cc/coverage/8043be5b322d7b450356c4a0a3ae19f4bc72ce3a_8043be5b322d7b450356c4a0a3ae19f4bc72ce3a/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 186430 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8043be5b322d7b450356c4a0a3ae19f4bc72ce3a, data reload: false

query1	918	360	339	339
query2	6453	2356	2375	2356
query3	6645	212	210	210
query4	22983	21245	21200	21200
query5	4203	425	438	425
query6	287	178	179	178
query7	4588	286	286	286
query8	233	181	184	181
query9	8471	2431	2406	2406
query10	433	244	247	244
query11	14806	14227	14208	14208
query12	131	88	88	88
query13	1641	370	373	370
query14	10534	8298	7484	7484
query15	262	180	177	177
query16	8194	277	269	269
query17	1838	574	559	559
query18	2129	285	281	281
query19	288	157	152	152
query20	97	87	91	87
query21	201	129	135	129
query22	5048	4784	4801	4784
query23	33737	33340	33071	33071
query24	10839	2939	2957	2939
query25	638	382	376	376
query26	1481	160	153	153
query27	2917	330	327	327
query28	7557	2092	2069	2069
query29	952	631	610	610
query30	286	157	155	155
query31	982	752	734	734
query32	97	55	57	55
query33	762	254	297	254
query34	981	478	483	478
query35	803	661	677	661
query36	1111	952	891	891
query37	125	66	68	66
query38	3196	2989	3013	2989
query39	1611	1543	1552	1543
query40	272	122	125	122
query41	42	39	39	39
query42	103	97	99	97
query43	584	533	553	533
query44	1210	730	738	730
query45	270	258	247	247
query46	1074	712	719	712
query47	1958	1843	1856	1843
query48	387	291	298	291
query49	1134	398	422	398
query50	773	395	378	378
query51	6716	6585	6640	6585
query52	103	90	90	90
query53	357	286	276	276
query54	326	257	266	257
query55	81	74	78	74
query56	238	219	230	219
query57	1214	1153	1110	1110
query58	218	194	201	194
query59	3267	3201	3244	3201
query60	266	237	231	231
query61	91	104	89	89
query62	674	453	449	449
query63	317	280	281	280
query64	9728	7234	7206	7206
query65	3126	3066	3058	3058
query66	1387	335	353	335
query67	15448	15025	14920	14920
query68	6766	535	543	535
query69	536	315	302	302
query70	1234	1071	1147	1071
query71	489	268	276	268
query72	8012	2591	2383	2383
query73	734	329	325	325
query74	6576	6084	6042	6042
query75	4025	2676	2608	2608
query76	4907	1056	975	975
query77	614	290	269	269
query78	10919	10363	10271	10271
query79	8817	521	512	512
query80	1330	443	452	443
query81	530	219	219	219
query82	845	94	96	94
query83	203	167	164	164
query84	263	85	86	85
query85	1448	285	271	271
query86	464	312	300	300
query87	3241	3095	3075	3075
query88	5243	2440	2484	2440
query89	546	383	385	383
query90	1995	194	191	191
query91	127	102	99	99
query92	58	49	49	49
query93	7333	521	510	510
query94	1168	190	184	184
query95	407	304	304	304
query96	617	282	273	273
query97	3165	2938	2951	2938
query98	241	229	215	215
query99	1289	889	884	884
Total cold run time: 303964 ms
Total hot run time: 186430 ms

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 7, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2024

PR approved by anyone and no changes requested.

@zhiqiang-hhhh
Copy link
Contributor

LGTM

@Gabriel39 Gabriel39 merged commit a4fca4e into apache:master May 7, 2024
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants