[feat](Nereids): Reject Commutativity Swap for Nested Loop Joins Affecting Parallelism #34639
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
xzj7019
approved these changes
May 13, 2024
Contributor
|
PR approved by anyone and no changes requested. |
jackwener
approved these changes
May 13, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
nextdreamblue
pushed a commit
to nextdreamblue/doris
that referenced
this pull request
May 13, 2024
…cting Parallelism (apache#34639)
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
May 14, 2024
…cting Parallelism (apache#34639)
ByteYue
pushed a commit
to ByteYue/doris
that referenced
this pull request
May 15, 2024
…cting Parallelism (apache#34639)
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
May 17, 2024
…cting Parallelism (apache#34639)
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
May 17, 2024
…cting Parallelism (apache#34639)
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
May 17, 2024
…cting Parallelism (apache#34639)
keanji-x
added a commit
to keanji-x/doris
that referenced
this pull request
May 20, 2024
…cting Parallelism (apache#34639)
morrySnow
pushed a commit
that referenced
this pull request
May 21, 2024
…ting Parallelism (#34639) (#34996) pick from master #34639 This PR introduces a safeguard to prevent commutativity swaps in nested loop joins that would convert a parallelizable join into a non-parallelizable one, thereby preserving optimal query execution efficiency. By adding a function that assesses the impact of such swaps on parallelism, the system automatically rejects changes that would hinder performance, ensuring that joins can continue to be executed in parallel to fully utilize system resources and maintain high operational throughput.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…ting Parallelism (apache#34639) (apache#34996) pick from master apache#34639 This PR introduces a safeguard to prevent commutativity swaps in nested loop joins that would convert a parallelizable join into a non-parallelizable one, thereby preserving optimal query execution efficiency. By adding a function that assesses the impact of such swaps on parallelism, the system automatically rejects changes that would hinder performance, ensuring that joins can continue to be executed in parallel to fully utilize system resources and maintain high operational throughput.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces a safeguard to prevent commutativity swaps in nested loop joins that would convert a parallelizable join into a non-parallelizable one, thereby preserving optimal query execution efficiency. By adding a function that assesses the impact of such swaps on parallelism, the system automatically rejects changes that would hinder performance, ensuring that joins can continue to be executed in parallel to fully utilize system resources and maintain high operational throughput.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...