Skip to content

[fix](memory) Fix build.sh thirdparty path error for jemalloc #34643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xinyiZzz merged 2 commits into from
May 11, 2024
Merged

[fix](memory) Fix build.sh thirdparty path error for jemalloc #34643

xinyiZzz merged 2 commits into from
May 11, 2024

Conversation

@xinyiZzz
Copy link
Contributor

@xinyiZzz xinyiZzz commented May 10, 2024 •
edited
Loading

Proposed changes

  1. Fix build.sh thirdparty path error for jemalloc
  2. fix jemalloc thirdparty is compatible with old code
  3. if build_type=ASAN, compile without jemalloc, because asan not compatible with jemalloc without prefix
    Crash only with Jemalloc, ASan is clean jemalloc/jemalloc#2353
    image

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented May 10, 2024

run buildall

morningman
morningman previously approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 10, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented May 10, 2024

TeamCity be ut coverage result:
Function Coverage: 35.67% (8980/25172)
Line Coverage: 27.32% (74172/271509)
Region Coverage: 26.56% (38343/144379)
Branch Coverage: 23.37% (19550/83640)
Coverage Report: http://coverage.selectdb-in.cc/coverage/2506df7c69698d63c955d977ebab721ee08a2ad6_2506df7c69698d63c955d977ebab721ee08a2ad6/report/index.html

BiteTheDDDDt
BiteTheDDDDt previously approved these changes May 10, 2024
View reviewed changes
@xinyiZzz xinyiZzz dismissed stale reviews from BiteTheDDDDt and morningman via 03fbab5 May 11, 2024 05:11
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented May 11, 2024

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 11, 2024
@xinyiZzz xinyiZzz force-pushed the 20240510_fix_jemalloc branch from 03fbab5 to c9416a7 Compare May 11, 2024 05:18
@xinyiZzz
Copy link
Contributor Author

xinyiZzz commented May 11, 2024

run buildall

@doris-robot
Copy link

doris-robot commented May 11, 2024

TeamCity be ut coverage result:
Function Coverage: 35.65% (8979/25190)
Line Coverage: 27.32% (74231/271725)
Region Coverage: 26.55% (38364/144485)
Branch Coverage: 23.38% (19570/83704)
Coverage Report: http://coverage.selectdb-in.cc/coverage/c9416a71db26f00fda0ca1afeb00c2ee958f80e6_c9416a71db26f00fda0ca1afeb00c2ee958f80e6/report/index.html

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 11, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 11, 2024

PR approved by at least one committer and no changes requested.

morningman
morningman approved these changes May 11, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit 875b85c into apache:master May 11, 2024
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request May 11, 2024
@xinyiZzz
[fix](memory) Fix build.sh thirdparty path error for jemalloc (apache…
9f59f24 
…#34643)

Fix build.sh thirdparty path error for jemalloc
fix jemalloc thirdparty is compatible with old code
if build_type=ASAN, compile without jemalloc, because asan not compatible with jemalloc without prefix
Crash only with Jemalloc, ASan is clean jemalloc/jemalloc#2353
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@xinyiZzz @ByteYue
[fix](memory) Fix build.sh thirdparty path error for jemalloc (apache…
4afe5a5 
…#34643)

Fix build.sh thirdparty path error for jemalloc
fix jemalloc thirdparty is compatible with old code
if build_type=ASAN, compile without jemalloc, because asan not compatible with jemalloc without prefix
Crash only with Jemalloc, ASan is clean jemalloc/jemalloc#2353
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request May 31, 2024
@xinyiZzz
Revert "[fix](memory) Fix build.sh thirdparty path error for jemalloc (…
cb4d4a3 
…apache#34643)"

This reverts commit 875b85c.
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request May 31, 2024
@xinyiZzz
Revert "[fix](memory) Fix build.sh thirdparty path error for jemalloc (…
2e98559 
…apache#34643)"

This reverts commit 875b85c.
@xinyiZzz xinyiZzz mentioned this pull request Dec 17, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@yiguolei yiguolei yiguolei approved these changes

@BiteTheDDDDt BiteTheDDDDt BiteTheDDDDt left review comments

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xinyiZzz @doris-robot @morningman @BiteTheDDDDt @yiguolei @dataroaring