Skip to content

[Fix](hive-writer) Fix hive partition update file size and remove redundant column names. #34651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
May 14, 2024
Merged

[Fix](hive-writer) Fix hive partition update file size and remove redundant column names. #34651

morningman merged 1 commit into from
May 14, 2024

Conversation

@kaka11chen
Copy link
Contributor

@kaka11chen kaka11chen commented May 10, 2024

Proposed changes

Issue Number: #31442

[Fix] (hive-writer) Fix hive partition update file size and remove redundant column names.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 10, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaka11chen
Copy link
Contributor Author

kaka11chen commented May 10, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 10, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 10, 2024

TeamCity be ut coverage result:
Function Coverage: 35.67% (8980/25172)
Line Coverage: 27.33% (74200/271510)
Region Coverage: 26.57% (38369/144381)
Branch Coverage: 23.40% (19570/83642)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e086463a471da632f8512956da28e4c130926d68_e086463a471da632f8512956da28e4c130926d68/report/index.html

morningman
morningman approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 13, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

PR approved by anyone and no changes requested.

@morningman morningman force-pushed the fix_hive_partition_update_file_size branch from e086463 to 0f41eec Compare May 13, 2024 11:26
@morningman
Copy link
Contributor

morningman commented May 13, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 13, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 13, 2024

TeamCity be ut coverage result:
Function Coverage: 35.66% (8988/25206)
Line Coverage: 27.32% (74301/271931)
Region Coverage: 26.55% (38396/144598)
Branch Coverage: 23.37% (19583/83790)
Coverage Report: http://coverage.selectdb-in.cc/coverage/0f41eec4488b0d3cc55557cc05d81bd50ece0246_0f41eec4488b0d3cc55557cc05d81bd50ece0246/report/index.html

morningman
morningman approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 4213608 into apache:master May 14, 2024
kaka11chen added a commit to kaka11chen/doris that referenced this pull request May 15, 2024
@kaka11chen
[Fix](hive-writer) Fix hive partition update file size and remove red…
4a4eecd 
…undant column names. (apache#34651)
@kaka11chen kaka11chen mentioned this pull request May 15, 2024
Merged
morningman pushed a commit that referenced this pull request May 15, 2024
@kaka11chen
[Fix](hive-writer) Fix hive partition update file size and remove red…
e13ce90 
…undant column names. (#34651) (#34885)

Backport #34651.
ByteYue pushed a commit to ByteYue/doris that referenced this pull request May 15, 2024
@kaka11chen @ByteYue
[Fix](hive-writer) Fix hive partition update file size and remove red…
f62ccf9 
…undant column names. (apache#34651)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningman morningman morningman approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.3-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kaka11chen @doris-robot @morningman @zy-kkk @gavinchou