[fix](prepare) fix datetimev2 return err when binary_row_format #34662

nextdreamblue · 2024-05-10T09:07:59Z

Proposed changes

Issue Number: close #xxx

fix datetimev2 return err when binary_row_format. before pr, Backend return datetimev2 alwary by to_string.
fix datatimev2 return metadata loss scale.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

doris-robot · 2024-05-10T09:08:04Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

github-actions · 2024-05-10T09:14:45Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T10:42:50Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T10:47:04Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T11:24:21Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T11:24:28Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T11:27:42Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-10T12:04:31Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-10T13:33:55Z

TeamCity be ut coverage result:
Function Coverage: 35.67% (8980/25173)
Line Coverage: 27.34% (74241/271556)
Region Coverage: 26.57% (38372/144416)
Branch Coverage: 23.39% (19568/83652)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1f6c32a7769c6c69783c8fc335962d6e81253dd4_1f6c32a7769c6c69783c8fc335962d6e81253dd4/report/index.html

github-actions · 2024-05-13T03:23:31Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-13T03:26:06Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-13T04:31:45Z

TPC-H: Total hot run time: 39876 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a1014c0c52335c44bbda65032d89ac688bb01f08, data reload: false

------ Round 1 ----------------------------------
q1	17978	5260	4387	4387
q2	2642	188	197	188
q3	10988	1191	1192	1191
q4	10350	739	742	739
q5	7546	2716	2604	2604
q6	213	127	127	127
q7	1038	614	588	588
q8	9421	2106	2040	2040
q9	8978	6556	6504	6504
q10	8968	3653	3743	3653
q11	476	242	233	233
q12	458	221	211	211
q13	17778	2979	2944	2944
q14	246	220	218	218
q15	532	478	474	474
q16	509	393	377	377
q17	968	631	673	631
q18	8106	7473	7351	7351
q19	5824	1561	1537	1537
q20	666	312	313	312
q21	5114	3891	3286	3286
q22	346	281	286	281
Total cold run time: 119145 ms
Total hot run time: 39876 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4389	4244	4186	4186
q2	386	278	272	272
q3	3027	2749	2749	2749
q4	1899	1632	1604	1604
q5	5281	5259	5291	5259
q6	205	122	121	121
q7	2239	1902	1875	1875
q8	3232	3357	3330	3330
q9	8418	8343	8380	8343
q10	3897	3667	3675	3667
q11	593	484	493	484
q12	760	588	589	588
q13	16321	2978	3001	2978
q14	280	256	260	256
q15	519	478	471	471
q16	477	413	420	413
q17	1795	1490	1472	1472
q18	7769	7594	7289	7289
q19	1651	1513	1581	1513
q20	1948	1779	1758	1758
q21	4783	4859	5008	4859
q22	554	520	503	503
Total cold run time: 70423 ms
Total hot run time: 53990 ms

doris-robot · 2024-05-13T04:43:20Z

TPC-DS: Total hot run time: 187887 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a1014c0c52335c44bbda65032d89ac688bb01f08, data reload: false

query1	924	363	353	353
query2	6450	2489	2379	2379
query3	6655	209	213	209
query4	23093	21241	21124	21124
query5	4147	417	431	417
query6	269	170	194	170
query7	4575	295	292	292
query8	245	195	194	194
query9	8769	2417	2409	2409
query10	440	254	267	254
query11	14799	14326	14223	14223
query12	130	95	88	88
query13	1634	372	374	372
query14	9755	7804	7837	7804
query15	232	168	177	168
query16	7727	253	262	253
query17	1858	584	536	536
query18	1384	276	276	276
query19	204	146	151	146
query20	95	88	86	86
query21	203	131	132	131
query22	5043	4950	4929	4929
query23	34267	33868	33683	33683
query24	11670	2959	2974	2959
query25	630	365	376	365
query26	1525	161	157	157
query27	2701	314	322	314
query28	7403	2066	2059	2059
query29	948	611	630	611
query30	289	156	150	150
query31	998	808	744	744
query32	87	53	56	53
query33	739	243	258	243
query34	1038	474	490	474
query35	806	684	657	657
query36	1077	904	933	904
query37	130	69	68	68
query38	2881	2785	2772	2772
query39	1630	1541	1562	1541
query40	274	125	126	125
query41	42	38	39	38
query42	107	95	100	95
query43	595	568	554	554
query44	1236	721	744	721
query45	265	257	258	257
query46	1075	721	704	704
query47	1942	1895	1919	1895
query48	375	291	299	291
query49	1145	395	430	395
query50	772	388	396	388
query51	6850	6673	6656	6656
query52	101	92	94	92
query53	355	299	297	297
query54	1083	433	434	433
query55	75	73	72	72
query56	249	225	237	225
query57	1246	1131	1130	1130
query58	235	205	216	205
query59	3543	3181	3401	3181
query60	258	243	245	243
query61	90	89	87	87
query62	655	500	464	464
query63	312	286	316	286
query64	9802	7381	7321	7321
query65	3259	3169	3132	3132
query66	1296	348	354	348
query67	15393	14954	15138	14954
query68	4594	532	538	532
query69	478	310	318	310
query70	1195	1156	1168	1156
query71	423	274	288	274
query72	7247	2606	2359	2359
query73	703	321	322	321
query74	6574	6127	6178	6127
query75	3362	2642	2603	2603
query76	2764	926	916	916
query77	413	272	273	272
query78	10644	10180	10216	10180
query79	1488	516	516	516
query80	1062	446	442	442
query81	504	222	220	220
query82	957	93	96	93
query83	265	162	165	162
query84	232	85	86	85
query85	1242	327	339	327
query86	381	305	309	305
query87	3277	3104	3095	3095
query88	3153	2431	2421	2421
query89	466	375	396	375
query90	1925	187	186	186
query91	127	100	96	96
query92	58	50	49	49
query93	1325	510	494	494
query94	1211	182	185	182
query95	384	302	302	302
query96	587	274	266	266
query97	3152	2992	2959	2959
query98	234	223	213	213
query99	1167	911	893	893
Total cold run time: 281674 ms
Total hot run time: 187887 ms

doris-robot · 2024-05-13T04:46:14Z

TeamCity be ut coverage result:
Function Coverage: 35.65% (8984/25201)
Line Coverage: 27.31% (74256/271880)
Region Coverage: 26.54% (38374/144590)
Branch Coverage: 23.36% (19568/83774)
Coverage Report: http://coverage.selectdb-in.cc/coverage/a1014c0c52335c44bbda65032d89ac688bb01f08_a1014c0c52335c44bbda65032d89ac688bb01f08/report/index.html

github-actions · 2024-05-13T06:51:29Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-13T07:08:33Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-13T07:35:45Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-13T08:23:04Z

clang-tidy review says "All clean, LGTM! 👍"

nextdreamblue · 2024-05-13T09:02:06Z

run buildall

github-actions · 2024-05-13T09:07:16Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-13T10:11:53Z

TPC-H: Total hot run time: 41858 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d392fb581554b72619859ed015431cbbe7a4cfa8, data reload: false

------ Round 1 ----------------------------------
q1	17602	4846	4268	4268
q2	2018	184	191	184
q3	10463	1162	1230	1162
q4	10394	846	757	757
q5	7496	2815	2838	2815
q6	218	141	144	141
q7	1063	617	627	617
q8	9293	2205	2155	2155
q9	9127	6783	6689	6689
q10	9151	3897	3920	3897
q11	442	242	242	242
q12	487	230	234	230
q13	17905	3113	3173	3113
q14	261	229	224	224
q15	509	481	478	478
q16	549	390	409	390
q17	1044	649	761	649
q18	8558	7696	7793	7696
q19	4738	1533	1514	1514
q20	656	316	319	316
q21	5263	4137	4047	4047
q22	366	278	274	274
Total cold run time: 117603 ms
Total hot run time: 41858 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4283	4196	4218	4196
q2	385	277	256	256
q3	3024	2745	2822	2745
q4	1870	1635	1605	1605
q5	5357	5323	5307	5307
q6	208	127	124	124
q7	2257	1889	1865	1865
q8	3172	3337	3338	3337
q9	8410	8386	8388	8386
q10	3910	3652	3674	3652
q11	586	489	489	489
q12	787	612	605	605
q13	17279	2970	2982	2970
q14	298	280	242	242
q15	532	471	482	471
q16	452	417	427	417
q17	1778	1499	1460	1460
q18	7657	7692	7375	7375
q19	1677	1571	1559	1559
q20	1952	1789	1767	1767
q21	10146	4884	4764	4764
q22	601	499	485	485
Total cold run time: 76621 ms
Total hot run time: 54077 ms

doris-robot · 2024-05-13T10:23:15Z

TPC-DS: Total hot run time: 187082 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d392fb581554b72619859ed015431cbbe7a4cfa8, data reload: false

query1	910	382	345	345
query2	6442	2503	2459	2459
query3	6655	211	213	211
query4	22998	21243	21266	21243
query5	4130	434	427	427
query6	269	171	169	169
query7	4602	288	282	282
query8	253	194	196	194
query9	8589	2399	2375	2375
query10	434	253	242	242
query11	14735	14269	14142	14142
query12	136	97	85	85
query13	1644	379	378	378
query14	9885	8509	7665	7665
query15	249	167	174	167
query16	8127	264	269	264
query17	1726	550	538	538
query18	2090	277	286	277
query19	204	147	143	143
query20	88	86	85	85
query21	191	130	131	130
query22	5023	4865	4856	4856
query23	34022	33731	33472	33472
query24	6644	2862	2925	2862
query25	539	358	378	358
query26	686	157	155	155
query27	1996	319	344	319
query28	3918	2073	2056	2056
query29	845	619	610	610
query30	222	154	148	148
query31	942	755	726	726
query32	85	53	53	53
query33	488	254	240	240
query34	860	474	488	474
query35	764	684	678	678
query36	1036	918	898	898
query37	103	64	68	64
query38	2881	2784	2800	2784
query39	1639	1548	1565	1548
query40	191	123	122	122
query41	42	38	37	37
query42	105	97	95	95
query43	586	537	550	537
query44	1104	731	741	731
query45	266	250	260	250
query46	1059	738	767	738
query47	1954	1860	1880	1860
query48	369	292	287	287
query49	767	402	392	392
query50	777	404	390	390
query51	6835	6820	6769	6769
query52	96	91	90	90
query53	348	284	289	284
query54	533	427	422	422
query55	72	73	72	72
query56	245	217	219	217
query57	1225	1138	1173	1138
query58	213	197	200	197
query59	3599	3156	3229	3156
query60	254	230	234	230
query61	119	89	86	86
query62	581	486	470	470
query63	311	290	283	283
query64	8466	7393	7363	7363
query65	3127	3109	3117	3109
query66	810	350	387	350
query67	15371	14870	14927	14870
query68	4551	536	540	536
query69	485	302	311	302
query70	1184	1145	1147	1145
query71	393	263	267	263
query72	7821	2604	2355	2355
query73	696	324	324	324
query74	6574	6040	6113	6040
query75	3372	2687	2570	2570
query76	2351	1066	1037	1037
query77	454	266	263	263
query78	10671	10101	10106	10101
query79	2386	517	524	517
query80	830	440	437	437
query81	476	223	220	220
query82	814	94	94	94
query83	240	163	166	163
query84	242	89	85	85
query85	903	328	264	264
query86	427	323	296	296
query87	3269	3092	3041	3041
query88	4074	2329	2315	2315
query89	464	380	399	380
query90	2028	188	192	188
query91	121	97	96	96
query92	59	52	52	52
query93	1784	534	511	511
query94	1117	184	199	184
query95	403	319	306	306
query96	583	271	261	261
query97	3165	3008	2961	2961
query98	231	221	224	221
query99	1165	897	887	887
Total cold run time: 269808 ms
Total hot run time: 187082 ms

doris-robot · 2024-05-13T10:43:40Z

TeamCity be ut coverage result:
Function Coverage: 35.66% (8989/25206)
Line Coverage: 27.33% (74311/271943)
Region Coverage: 26.56% (38414/144609)
Branch Coverage: 23.37% (19583/83794)
Coverage Report: http://coverage.selectdb-in.cc/coverage/d392fb581554b72619859ed015431cbbe7a4cfa8_d392fb581554b72619859ed015431cbbe7a4cfa8/report/index.html

nextdreamblue · 2024-05-13T14:04:02Z

run p0

nextdreamblue · 2024-05-13T14:49:42Z

run buildall

nextdreamblue · 2024-05-13T14:52:03Z

run buildall

nextdreamblue · 2024-05-16T10:07:42Z

run buildall

github-actions · 2024-05-16T10:12:43Z

clang-tidy review says "All clean, LGTM! 👍"

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

nextdreamblue · 2024-05-16T10:23:03Z

run buildall

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

nextdreamblue · 2024-05-16T10:25:02Z

run buildall

github-actions · 2024-05-16T10:27:51Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-16T10:29:54Z

clang-tidy review says "All clean, LGTM! 👍"

cambyzju

LGTM

github-actions · 2024-05-16T10:53:11Z

PR approved by at least one committer and no changes requested.

doris-robot · 2024-05-16T11:54:25Z

TeamCity be ut coverage result:
Function Coverage: 35.71% (9005/25219)
Line Coverage: 27.37% (74499/272166)
Region Coverage: 26.62% (38521/144728)
Branch Coverage: 23.43% (19648/83850)
Coverage Report: http://coverage.selectdb-in.cc/coverage/6aa4dfef6eec7c6c0d5f7374df3c9e9ed50f6a7f_6aa4dfef6eec7c6c0d5f7374df3c9e9ed50f6a7f/report/index.html

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

nextdreamblue · 2024-05-17T02:31:23Z

run buildall

github-actions · 2024-05-17T02:36:37Z

clang-tidy review says "All clean, LGTM! 👍"

github-actions · 2024-05-17T02:37:20Z

clang-tidy review says "All clean, LGTM! 👍"

doris-robot · 2024-05-17T03:27:09Z

TeamCity be ut coverage result:
Function Coverage: 35.69% (9004/25225)
Line Coverage: 27.36% (74493/272220)
Region Coverage: 26.60% (38508/144743)
Branch Coverage: 23.43% (19647/83860)
Coverage Report: http://coverage.selectdb-in.cc/coverage/7b4043127d912e59f0c99d69966ae7c4d5bd3d5a_7b4043127d912e59f0c99d69966ae7c4d5bd3d5a/report/index.html

xy720

LGTM

cambyzju

LGTM

eldenmoon

LGTM

#34807) fix datetimev2 return err when binary_row_format. before pr, Backend return datetimev2 alwary by to_string. fix datatimev2 return metadata loss scale.

fix datetimev2 return err when binary_row_format. before pr, Backend return datetimev2 alwary by to_string. fix datatimev2 return metadata loss scale.

…e#34662 (apache#34807) fix datetimev2 return err when binary_row_format. before pr, Backend return datetimev2 alwary by to_string. fix datatimev2 return metadata loss scale.

xiaokang added the dev/2.0.x label May 10, 2024

github-actions bot added the meta-change label May 13, 2024

nextdreamblue force-pushed the datetimev2_binary branch from 4dff278 to 646de87 Compare May 13, 2024 14:51

nextdreamblue marked this pull request as ready for review May 13, 2024 14:52

nextdreamblue force-pushed the datetimev2_binary branch from 646de87 to 9d89447 Compare May 16, 2024 10:07

github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 16, 2024

fix code 101

7a0e78b

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

fix code 102

6aa4dfe

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

cambyzju previously approved these changes May 16, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2024

fix code 103

bcce1de

Signed-off-by: nextdreamblue <zxw520blue1@163.com>

nextdreamblue dismissed cambyzju’s stale review via bcce1de May 17, 2024 02:30

Merge branch 'master' into datetimev2_binary

7b40431

xy720 approved these changes May 17, 2024

View reviewed changes

cambyzju approved these changes May 17, 2024

View reviewed changes

eldenmoon approved these changes May 17, 2024

View reviewed changes

nextdreamblue merged commit e12af93 into apache:master May 17, 2024

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

[fix](prepare) fix datetimev2 return err when binary_row_format #34662

[fix](prepare) fix datetimev2 return err when binary_row_format #34662

Uh oh!

Conversation

nextdreamblue commented May 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Further comments

Uh oh!

doris-robot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

github-actions bot commented May 10, 2024

Uh oh!

doris-robot commented May 10, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

nextdreamblue commented May 13, 2024

Uh oh!

github-actions bot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

doris-robot commented May 13, 2024

Uh oh!

nextdreamblue commented May 13, 2024

Uh oh!

nextdreamblue commented May 13, 2024

Uh oh!

nextdreamblue commented May 13, 2024

Uh oh!

nextdreamblue commented May 16, 2024

Uh oh!

github-actions bot commented May 16, 2024

Uh oh!

nextdreamblue commented May 16, 2024

Uh oh!

nextdreamblue commented May 16, 2024

Uh oh!

github-actions bot commented May 16, 2024

Uh oh!

github-actions bot commented May 16, 2024

Uh oh!

cambyzju left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 16, 2024

Uh oh!

doris-robot commented May 16, 2024

Uh oh!

nextdreamblue commented May 10, 2024 •

edited

Loading