Skip to content

[FIX](array_index)fix array tokenized index parser and array_contains bugs #34683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eldenmoon merged 2 commits into from
May 13, 2024
Merged

[FIX](array_index)fix array tokenized index parser and array_contains bugs #34683

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
34aee14
fix array tokenized index parser and array_contains bugs
May 11, 2024
de4dade
delete useless param
May 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions be/src/olap/rowset/segment_v2/inverted_index_writer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,9 +394,11 @@ class InvertedIndexColumnWriterImpl : public InvertedIndexColumnWriter {
_parser_type != InvertedIndexParserType::PARSER_NONE) {
// in this case stream need to delete after add_document, because the
// stream can not reuse for different field
_char_string_reader->init(v->get_data(), v->get_size(), false);
std::unique_ptr<lucene::util::Reader> char_string_reader = nullptr;
RETURN_IF_ERROR(create_char_string_reader(char_string_reader));
char_string_reader->init(v->get_data(), v->get_size(), false);
ts = _analyzer->tokenStream(new_field->name(),
_char_string_reader.get());
char_string_reader.release());
new_field->setValue(ts);
} else {
new_field_char_value(v->get_data(), v->get_size(), new_field);
Expand Down
6 changes: 3 additions & 3 deletions be/src/vec/functions/array/function_array_index.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,17 +125,17 @@ class FunctionArrayIndex : public IFunction {
std::shared_ptr<roaring::Roaring> roaring = std::make_shared<roaring::Roaring>();
auto* param_value = reinterpret_cast<ParamValue*>(
context->get_function_state(FunctionContext::FRAGMENT_LOCAL));
if (param_value == nullptr) {
if (param_value == nullptr || param_value->value.is_null()) {
return Status::Error<ErrorCode::INVERTED_INDEX_EVALUATE_SKIPPED>(
"Inverted index evaluate skipped, param_value is nullptr");
"Inverted index evaluate skipped, param_value is nullptr or value is null");
}
std::unique_ptr<InvertedIndexQueryParamFactory> query_param = nullptr;
RETURN_IF_ERROR(InvertedIndexQueryParamFactory::create_query_value(
param_value->type, &param_value->value, query_param));
if (is_string_type(param_value->type)) {
RETURN_IF_ERROR(iter->read_from_inverted_index(
data_type_with_name.first, query_param->get_value(),
segment_v2::InvertedIndexQueryType::MATCH_ANY_QUERY, num_rows, roaring));
segment_v2::InvertedIndexQueryType::EQUAL_QUERY, num_rows, roaring));
} else {
RETURN_IF_ERROR(iter->read_from_inverted_index(
data_type_with_name.first, query_param->get_value(),
Expand Down
Loading