[Opt](Iceberg) Only initialize one split if the statement can push down count #34775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
zhangbutao
commented
May 13, 2024
| // iceberg use integer to store date, | ||
| // we need transform it to string | ||
| value = DateTimeUtil.daysToIsoDate((Integer) obj); | ||
| for (CombinedScanTask taskGrp : combinedScanTasks) { |
Contributor
Author
There was a problem hiding this comment.
I didn't find a better way to end the loop in forEach, so i use for to replace forEach. :(
zhangbutao
commented
May 13, 2024
| partitionPathSet.add(structLike.toString()); | ||
| // End loop early as one split is enough if the statement can push down count | ||
| if (canPushCount) { | ||
| break; |
Contributor
Author
There was a problem hiding this comment.
This is what i want to do. End the entire loop early to avoid a lot of useless spilts if the statement can push down count.
Contributor
Author
|
run buildall |
Contributor
Author
|
@wuwenchi Could you give some suggestion about this change? Thanks. |
TPC-H: Total hot run time: 39914 ms |
TPC-DS: Total hot run time: 187944 ms |
morningman
reviewed
May 14, 2024
Contributor
morningman
left a comment
morningman
left a comment
There was a problem hiding this comment.
If you want to do this optimization, why not just create a dummy IcebergSplit?
So we even don't need to call TableScanUtil.planTasks
Contributor
Author
@morningman Thanks for your suggestion! You are right, create a dummy IcebergSplit is a better approach than this PR. But i found that BE need a real iceberg spilt to do some code logic, and we need do some odd check in BE side to let the BE accept the dummy IcebergSplit. Acutually, i think the I just submitted a new PR #34928, Please take a look if you have time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
#22923 did a good optimization for iceberg count. I think we can end the
get splits loopearly as one split is enough if the statement can push down count. This can reduce the query time if iceberg table has many splits.Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...