[fix](iceberg_orc)Fixed the bug that the iceberg reader did not perform position delete when reading the orc file without a predicate. #34814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rm position delete when reading the orc file without a predicate.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40233 ms |
TPC-DS: Total hot run time: 188082 ms |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
AshinGau
reviewed
May 14, 2024
| RETURN_IF_CATCH_EXCEPTION(Block::filter_block_internal(block, columns_to_filter, | ||
| (*_delete_rows_filter_ptr))); | ||
| } else { | ||
| std::unique_ptr<IColumn::Filter> filter(new IColumn::Filter(block->rows(), 1)); |
Member
There was a problem hiding this comment.
Why need to create filter when there's no delete rows?
Contributor
Author
There was a problem hiding this comment.
_delete_rows_filter_ptr be used in transactional hive orc , not position delete.
AshinGau
approved these changes
May 15, 2024
Member
|
LGTM |
hubgeter
added a commit
to hubgeter/doris
that referenced
this pull request
May 15, 2024
…rm position delete when reading the orc file without a predicate. (apache#34814) fix this bug: Scenario : iceberg table uses orc storage format sql : `select * from iceberg_orc;` When executing this sql, position delete filter is not performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
fix this bug:
Scenario : iceberg table uses orc storage format
sql :
select * from iceberg_orc;When executing this sql, position delete filter is not performed.
Issue Number: close #xxx
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...