Skip to content

[fix](planner)correlated predicate should include isnull predicate #34833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
May 15, 2024
Merged

[fix](planner)correlated predicate should include isnull predicate #34833

starocean999 merged 1 commit into from
May 15, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented May 14, 2024

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 14, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented May 14, 2024

run buildall

@starocean999 starocean999 mentioned this pull request May 14, 2024
Merged
@doris-robot
Copy link

doris-robot commented May 14, 2024

TPC-H: Total hot run time: 41873 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fbdef19dd03426aa991059948fd00111946be75c, data reload: false

------ Round 1 ----------------------------------
q1	17601	4288	4201	4201
q2	2014	190	188	188
q3	10456	1217	1162	1162
q4	10198	749	828	749
q5	7495	2744	2731	2731
q6	224	137	140	137
q7	1032	599	612	599
q8	9228	2177	2090	2090
q9	9248	6722	6701	6701
q10	9361	3987	3888	3888
q11	471	254	254	254
q12	501	236	225	225
q13	18529	3222	3038	3038
q14	271	220	230	220
q15	522	478	482	478
q16	517	403	401	401
q17	980	742	755	742
q18	8477	7853	7829	7829
q19	2223	1574	1514	1514
q20	653	323	330	323
q21	5321	4152	4128	4128
q22	357	275	287	275
Total cold run time: 115679 ms
Total hot run time: 41873 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4529	4358	4444	4358
q2	392	260	258	258
q3	3130	2981	2713	2713
q4	1922	1695	1730	1695
q5	5552	5517	5502	5502
q6	214	132	132	132
q7	2328	1956	1981	1956
q8	3242	3369	3428	3369
q9	8717	8730	8710	8710
q10	3937	3849	3842	3842
q11	581	513	493	493
q12	793	630	627	627
q13	17049	3136	3169	3136
q14	297	283	278	278
q15	515	499	489	489
q16	464	415	415	415
q17	1759	1486	1462	1462
q18	7792	7487	7436	7436
q19	1660	1577	1520	1520
q20	1941	1783	1754	1754
q21	9258	4803	4986	4803
q22	563	489	484	484
Total cold run time: 76635 ms
Total hot run time: 55432 ms

@doris-robot
Copy link

doris-robot commented May 14, 2024

TPC-DS: Total hot run time: 186520 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fbdef19dd03426aa991059948fd00111946be75c, data reload: false

query1	923	395	368	368
query2	6440	2399	2299	2299
query3	6665	208	211	208
query4	23687	21376	21151	21151
query5	4127	420	412	412
query6	258	180	179	179
query7	4580	296	289	289
query8	244	196	193	193
query9	8712	2476	2466	2466
query10	436	244	250	244
query11	14938	14171	14265	14171
query12	159	89	83	83
query13	1652	377	369	369
query14	10862	7741	6966	6966
query15	204	173	172	172
query16	7842	274	257	257
query17	1745	577	529	529
query18	1999	275	267	267
query19	191	143	145	143
query20	91	83	84	83
query21	192	128	128	128
query22	5065	4938	4802	4802
query23	34237	33332	33470	33332
query24	6855	2915	2855	2855
query25	599	366	364	364
query26	699	164	155	155
query27	2050	322	331	322
query28	4274	2100	2065	2065
query29	839	612	610	610
query30	267	178	182	178
query31	1009	744	752	744
query32	93	52	52	52
query33	471	244	242	242
query34	881	477	489	477
query35	746	677	663	663
query36	1104	929	895	895
query37	109	70	71	70
query38	2908	2783	2751	2751
query39	1651	1563	1602	1563
query40	203	127	123	123
query41	45	50	47	47
query42	100	99	95	95
query43	587	542	548	542
query44	1088	730	738	730
query45	266	253	257	253
query46	1068	756	723	723
query47	1959	1861	1875	1861
query48	378	312	301	301
query49	838	407	412	407
query50	766	395	381	381
query51	6856	6899	6722	6722
query52	98	90	91	90
query53	346	283	288	283
query54	530	423	421	421
query55	74	73	75	73
query56	243	221	218	218
query57	1218	1147	1185	1147
query58	212	200	199	199
query59	3511	3244	3080	3080
query60	257	226	234	226
query61	91	85	116	85
query62	630	457	473	457
query63	306	287	279	279
query64	8438	7365	7308	7308
query65	3112	3076	3078	3076
query66	786	349	369	349
query67	15234	14935	15233	14935
query68	4515	533	547	533
query69	484	309	308	308
query70	1167	1156	1100	1100
query71	375	285	271	271
query72	7248	2654	2491	2491
query73	699	334	341	334
query74	6562	6109	6058	6058
query75	3320	2649	2646	2646
query76	2252	1031	915	915
query77	424	269	272	269
query78	10559	10198	10474	10198
query79	2215	508	534	508
query80	886	460	448	448
query81	548	247	241	241
query82	671	98	103	98
query83	249	168	172	168
query84	256	89	89	89
query85	1285	319	315	315
query86	460	309	308	308
query87	3261	3112	3140	3112
query88	4089	2472	2461	2461
query89	475	383	404	383
query90	2037	190	192	190
query91	140	111	109	109
query92	63	49	51	49
query93	1672	507	506	506
query94	1170	188	196	188
query95	416	314	305	305
query96	583	272	274	272
query97	3177	3015	3039	3015
query98	242	221	225	221
query99	1192	905	883	883
Total cold run time: 271736 ms
Total hot run time: 186520 ms

@doris-robot
Copy link

doris-robot commented May 14, 2024

ClickBench: Total hot run time: 30.89 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fbdef19dd03426aa991059948fd00111946be75c, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.66	0.09	0.08
query5	0.48	0.48	0.51
query6	1.13	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.49
query10	0.55	0.56	0.54
query11	0.16	0.11	0.11
query12	0.15	0.13	0.12
query13	0.59	0.59	0.60
query14	0.78	0.78	0.79
query15	0.83	0.82	0.81
query16	0.37	0.37	0.37
query17	0.94	0.98	1.01
query18	0.24	0.23	0.23
query19	1.79	1.69	1.69
query20	0.02	0.01	0.01
query21	15.73	0.64	0.64
query22	4.01	6.49	2.12
query23	18.34	1.46	1.36
query24	1.53	0.29	0.26
query25	0.14	0.09	0.07
query26	0.25	0.17	0.16
query27	0.08	0.08	0.08
query28	13.34	1.02	1.02
query29	12.92	3.31	3.28
query30	0.24	0.06	0.06
query31	2.88	0.39	0.38
query32	3.25	0.46	0.47
query33	2.87	2.82	2.85
query34	17.09	4.48	4.46
query35	4.57	4.48	4.49
query36	0.66	0.48	0.49
query37	0.19	0.16	0.15
query38	0.16	0.15	0.14
query39	0.04	0.04	0.04
query40	0.16	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.28 s
Total hot run time: 30.89 s

@starocean999 starocean999 marked this pull request as ready for review May 15, 2024 02:01
@morrySnow morrySnow added usercase Important user case type label dev/2.0.x labels May 15, 2024
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 15, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented May 15, 2024

PR approved by anyone and no changes requested.

@starocean999 starocean999 merged commit 27e61b7 into apache:master May 15, 2024
yiguolei pushed a commit that referenced this pull request May 18, 2024
@starocean999 @Doris-Extras
[fix](planner)correlated predicate should include isnull predicate (#…
a07876e 
…34833)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@englefly englefly englefly approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.4-merged dev/3.0.0-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@starocean999 @doris-robot @englefly @morrySnow @gavinchou