Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

Proposed changes

If use Fqdn, FE Host will use hostname. then will use hostname and port creating Arrow Flight Server, If /etc/hosts is configured with an intranet IP, Arrow Flight Server will bind intranet IP, external network inaccessible.

so, let Arrow Flight Server bind 0.0.0.0, allowing all IPs to access.

In addition, fix Arrow Flight connection calling getMysqlChannel().

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 15, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yiguolei yiguolei merged commit 5e8477e into apache:master May 15, 2024
@yiguolei yiguolei added the usercase Important user case type label label May 15, 2024
@yiguolei yiguolei mentioned this pull request May 15, 2024
1 task
xinyiZzz added a commit that referenced this pull request Sep 1, 2024
… error `0.0.0.0:xxx, connection refused` (#40002)

Fix: #36340
Introduced in: #34850

```
adbc_driver_manager.OperationalError: IO: [FlightSQL] connection error: desc = "transport: Error while dialing: dial tcp 0.0.0.0:8029: connect: connection refused" (Unavailable; DoGet: endpoint 0: [uri:"grpc+tcp://0.0.0.0:8029"])
```

When query results are returned from FE Arrow Flight server, and Doris
FE and ADBC ​​Client are not on the same machine, such as `show
tables;`, `show databases;`, the IP in FlightInfo returned by FE to the
client is wrong, and `0.0.0.0` is returned instead of the real IP of FE.
The client fails to pull the results from `0.0.0.0`.

No problem when query results are returned from BE Arrow Flight server,
such as the normal query statement `select * from xxx`.
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Sep 1, 2024
… error `0.0.0.0:xxx, connection refused` (apache#40002)

Fix: apache#36340
Introduced in: apache#34850

```
adbc_driver_manager.OperationalError: IO: [FlightSQL] connection error: desc = "transport: Error while dialing: dial tcp 0.0.0.0:8029: connect: connection refused" (Unavailable; DoGet: endpoint 0: [uri:"grpc+tcp://0.0.0.0:8029"])
```

When query results are returned from FE Arrow Flight server, and Doris
FE and ADBC ​​Client are not on the same machine, such as `show
tables;`, `show databases;`, the IP in FlightInfo returned by FE to the
client is wrong, and `0.0.0.0` is returned instead of the real IP of FE.
The client fails to pull the results from `0.0.0.0`.

No problem when query results are returned from BE Arrow Flight server,
such as the normal query statement `select * from xxx`.
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
… error `0.0.0.0:xxx, connection refused` (#40002)

Fix: #36340
Introduced in: #34850

```
adbc_driver_manager.OperationalError: IO: [FlightSQL] connection error: desc = "transport: Error while dialing: dial tcp 0.0.0.0:8029: connect: connection refused" (Unavailable; DoGet: endpoint 0: [uri:"grpc+tcp://0.0.0.0:8029"])
```

When query results are returned from FE Arrow Flight server, and Doris
FE and ADBC ​​Client are not on the same machine, such as `show
tables;`, `show databases;`, the IP in FlightInfo returned by FE to the
client is wrong, and `0.0.0.0` is returned instead of the real IP of FE.
The client fails to pull the results from `0.0.0.0`.

No problem when query results are returned from BE Arrow Flight server,
such as the normal query statement `select * from xxx`.
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request Nov 11, 2024
… error `0.0.0.0:xxx, connection refused` (apache#40002)

Fix: apache#36340
Introduced in: apache#34850

```
adbc_driver_manager.OperationalError: IO: [FlightSQL] connection error: desc = "transport: Error while dialing: dial tcp 0.0.0.0:8029: connect: connection refused" (Unavailable; DoGet: endpoint 0: [uri:"grpc+tcp://0.0.0.0:8029"])
```

When query results are returned from FE Arrow Flight server, and Doris
FE and ADBC ​​Client are not on the same machine, such as `show
tables;`, `show databases;`, the IP in FlightInfo returned by FE to the
client is wrong, and `0.0.0.0` is returned instead of the real IP of FE.
The client fails to pull the results from `0.0.0.0`.

No problem when query results are returned from BE Arrow Flight server,
such as the normal query statement `select * from xxx`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants