Skip to content

Conversation

@eldenmoon
Copy link
Member

…t_id

Proposed changes

Issue Number: close #xxx

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@eldenmoon eldenmoon marked this pull request as ready for review May 16, 2024 09:10
@eldenmoon
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 16, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219)
Line Coverage: 27.37% (74489/272146)
Region Coverage: 26.61% (38508/144709)
Branch Coverage: 23.43% (19643/83838)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e9feb3ad93dcbced75249755260aad0682f1f786_e9feb3ad93dcbced75249755260aad0682f1f786/report/index.html

@dataroaring dataroaring merged commit 173db9d into apache:master May 16, 2024
eldenmoon added a commit to eldenmoon/incubator-doris that referenced this pull request May 17, 2024
xiaokang pushed a commit that referenced this pull request May 20, 2024
Co-authored-by: abmdocrt <Yukang.Lian2022@gmail.com>
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants