Skip to content

[test](regression) add cases for data quality error url #34987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
liaoxin01 merged 3 commits into from
May 17, 2024
Merged

[test](regression) add cases for data quality error url #34987

liaoxin01 merged 3 commits into from
May 17, 2024

Conversation

@kaijchen
Copy link
Member

@kaijchen kaijchen commented May 16, 2024 •
edited
Loading

Proposed changes

Add regression tests to check url is returned when filtered rows in strict mode (data quality error).
Also fix some small bugs:

  1. Error type returned when partition is not found (END_OF_FILE -> DATA_QUALITY_ERROR).
  2. Unify status string format ("[ERROR] message" -> "[ERROR]message")

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

doris-robot commented May 16, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@kaijchen
Copy link
Member Author

kaijchen commented May 16, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 16, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 16, 2024

TeamCity be ut coverage result:
Function Coverage: 35.70% (9004/25219)
Line Coverage: 27.37% (74485/272148)
Region Coverage: 26.61% (38502/144707)
Branch Coverage: 23.43% (19644/83836)
Coverage Report: http://coverage.selectdb-in.cc/coverage/9337920f11fa0665c1080e94bd3931c0d1de12df_9337920f11fa0665c1080e94bd3931c0d1de12df/report/index.html

dataroaring
dataroaring previously approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 17, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@kaijchen
Copy link
Member Author

kaijchen commented May 17, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 17, 2024

TeamCity be ut coverage result:
Function Coverage: 35.70% (9005/25226)
Line Coverage: 27.37% (74520/272237)
Region Coverage: 26.61% (38524/144770)
Branch Coverage: 23.44% (19656/83870)
Coverage Report: http://coverage.selectdb-in.cc/coverage/b9aa23be8824ca936c897d6119d147b1e0dc4d43_b9aa23be8824ca936c897d6119d147b1e0dc4d43/report/index.html

dataroaring
dataroaring approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 17, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 17, 2024
liaoxin01
liaoxin01 approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit ea26169 into apache:master May 17, 2024
@kaijchen kaijchen deleted the test-unqualified branch May 17, 2024 16:31
dataroaring pushed a commit that referenced this pull request May 26, 2024
@kaijchen @dataroaring
[test](regression) add cases for data quality error url (#34987)
e466645
kaijchen added a commit to kaijchen/doris that referenced this pull request Jul 15, 2024
@kaijchen
[test](regression) add cases for data quality error url (apache#34987)
00ee669
@kaijchen kaijchen mentioned this pull request Jul 15, 2024
Merged
liaoxin01 pushed a commit that referenced this pull request Jul 16, 2024
@kaijchen
[test](regression) add cases for data quality error url (#34987) (#37777
47096f2 
)

cherry-pick #34987
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liaoxin01 liaoxin01 liaoxin01 approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kaijchen @doris-robot @liaoxin01 @dataroaring