Skip to content

Conversation

@133tosakarin
Copy link
Contributor

@133tosakarin 133tosakarin commented May 17, 2024

add compress_type for s3 tvf, and the broker load is async, so we should wait loading finished
fix some test files content error

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor

sollhui commented May 17, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.69% (9004/25227)
Line Coverage: 27.37% (74509/272239)
Region Coverage: 26.61% (38523/144759)
Branch Coverage: 23.44% (19658/83862)
Coverage Report: http://coverage.selectdb-in.cc/coverage/4f4d76afeb8c52bb99507532c78e09f13ab1d7dc_4f4d76afeb8c52bb99507532c78e09f13ab1d7dc/report/index.html

@133tosakarin 133tosakarin force-pushed the fix_test_tvf_based_broker_load branch 2 times, most recently from 7e14b1b to f8f99be Compare May 17, 2024 10:40
@133tosakarin
Copy link
Contributor Author

run buildall

@133tosakarin 133tosakarin force-pushed the fix_test_tvf_based_broker_load branch from 784f728 to efc2b47 Compare May 22, 2024 07:41

logger.info("test parquet_s3_case1")
order_qt_parquet_s3_case1 """select count(*) from parquet_s3_case1 where col1=10"""
logger.info("test parquet_s3_case2")
Copy link
Contributor

@sollhui sollhui May 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is log info still need?

@liaoxin01
Copy link
Contributor

run buildall

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@liaoxin01 liaoxin01 changed the title [fix] line_delimiter parse error in regression_test test_tvf_based_broker_load [fix](regression-test) line_delimiter parse error in regression_test test_tvf_based_broker_load May 23, 2024
@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 23, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 6f1469a into apache:master May 23, 2024
yiguolei pushed a commit that referenced this pull request May 24, 2024
dataroaring pushed a commit that referenced this pull request May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants