[opt](parquet-writer) Specify the row group size when writing data to Parquet files. #35081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run p0 |
morningman
changed the title
BePPPower
force-pushed
the
fixParquetRgSize
branch
from
05dc722 to
c013580
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41482 ms |
TPC-DS: Total hot run time: 169074 ms |
ClickBench: Total hot run time: 30.56 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
|
This solution will consume a lot of memory, so we need to discuss a better solution. @BePPPower |
BePPPower
force-pushed
the
fixParquetRgSize
branch
from
c013580 to
d9a2a82
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run performance |
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
kaka11chen
approved these changes
Jun 6, 2024
| builder.created_by( | ||
| fmt::format("{}({})", doris::get_short_version(), parquet::DEFAULT_CREATED_BY)); | ||
| _parquet_writer_properties = builder.build(); | ||
| _parquet_writer_properties = builder.created_by("DorisBE")->build(); |
morningman
approved these changes
Jun 6, 2024
TPC-H: Total hot run time: 41257 ms |
TPC-DS: Total hot run time: 172761 ms |
ClickBench: Total hot run time: 30.36 s |
morningman
pushed a commit
to morningman/doris
that referenced
this pull request
Jun 7, 2024
… Parquet files. (apache#35081) Previously, each Block data would write a row group every time when data was written to a Parquet file. Using Arrow's `WriteRecordBatch` interface allows caching data to be written to Parquet. We can control the size of the row group cache." Currently, simply accumulate the size of the blocks to determine the cache size.
dataroaring
pushed a commit
that referenced
this pull request
Jun 13, 2024
… Parquet files. (#35081) Previously, each Block data would write a row group every time when data was written to a Parquet file. Using Arrow's `WriteRecordBatch` interface allows caching data to be written to Parquet. We can control the size of the row group cache." Currently, simply accumulate the size of the blocks to determine the cache size.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, each Block data would write a row group every time when data was written to a Parquet file.
Which causing too many row group in a single parquet file. The the reading performance on this kind of file
is very bad.
This PR use Arrow's
WriteRecordBatchinterface, which allows caching data to be written to Parquet.We can control the size of the row group cache."
Currently, simply accumulate the size of the blocks to determine the cache size.