Skip to content

Conversation

@xinyiZzz
Copy link
Contributor

Proposed changes

If not enable cgroup, log will frequently print Could not find subsystem memory in /proc/self/cgroup.
frequently refresh cgroup information is not necessary.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@xinyiZzz
Copy link
Contributor Author

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 20, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.70% (9013/25248)
Line Coverage: 27.35% (74535/272519)
Region Coverage: 26.60% (38551/144916)
Branch Coverage: 23.44% (19672/83934)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f228b3d1173a67e7e44ced35759284a3bca4ecd1_f228b3d1173a67e7e44ced35759284a3bca4ecd1/report/index.html

Copy link
Contributor

@wangbo wangbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz xinyiZzz merged commit 3525a03 into apache:master May 22, 2024
xinyiZzz added a commit to xinyiZzz/incubator-doris that referenced this pull request May 22, 2024
If not enable cgroup, log will frequently print Could not find subsystem memory in /proc/self/cgroup.
frequently refresh cgroup information is not necessary.
dataroaring pushed a commit that referenced this pull request May 26, 2024
If not enable cgroup, log will frequently print Could not find subsystem memory in /proc/self/cgroup.
frequently refresh cgroup information is not necessary.
w41ter added a commit to w41ter/incubator-doris that referenced this pull request Jul 2, 2024
…he#35083 apache#35557 (apache#3405)

[fix](memory) Fix BE memory info compatible with Cgroup (apache#35412)
[fix](memory) Avoid frequently refresh cgroup memory info (apache#35083)
[fix](libjdk) Revert support loading libjvm at runtime (apache#35557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants