Skip to content

[bugfix](tvf)catch exception for fetching SchemaTableData for 2.0 #35109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 2 commits into from
May 22, 2024
Merged

[bugfix](tvf)catch exception for fetching SchemaTableData for 2.0 #35109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2081866
[bugfix](tvf)catch exception for fetching SchemaTableData #34856
wuwenchi May 14, 2024
4644ee5
fix
wuwenchi May 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions fe/fe-core/src/main/java/org/apache/doris/planner/external/iceberg/IcebergMetadataCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,9 @@ public IcebergMetadataCache() {

public List<Snapshot> getSnapshotList(TIcebergMetadataParams params) throws UserException {
CatalogIf catalog = Env.getCurrentEnv().getCatalogMgr().getCatalog(params.getCatalog());
if (catalog == null) {
throw new UserException("The specified catalog does not exist:" + params.getCatalog());
}
IcebergMetadataCacheKey key =
IcebergMetadataCacheKey.of(catalog.getId(), params.getDatabase(), params.getTable());
List<Snapshot> ifPresent = snapshotListCache.getIfPresent(key);
Expand Down
17 changes: 11 additions & 6 deletions fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2234,13 +2234,18 @@ public TFrontendPingFrontendResult ping(TFrontendPingFrontendRequest request) th

@Override
public TFetchSchemaTableDataResult fetchSchemaTableData(TFetchSchemaTableDataRequest request) throws TException {
switch (request.getSchemaTableName()) {
case METADATA_TABLE:
return MetadataGenerator.getMetadataTable(request);
default:
break;
try {
switch (request.getSchemaTableName()) {
case METADATA_TABLE:
return MetadataGenerator.getMetadataTable(request);
default:
break;
}
return MetadataGenerator.errorResult("Fetch schema table name is not set");
} catch (Exception e) {
LOG.warn("Failed to fetchSchemaTableData", e);
return MetadataGenerator.errorResult(e.getMessage());
}
return MetadataGenerator.errorResult("Fetch schema table name is not set");
}

private TNetworkAddress getClientAddr() {
Expand Down