Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented May 21, 2024

Proposed changes

Data source properties do not persist in edit log will affect the alter command and fail to take effect in the following two scenarios:

  1. FE leader change result in the loss of values changed by the alter command.
  • Progress is {"0":"39"}
  • use ALTER ROUTINE LOAD FOR lineitem FROM kafka ( "kafka_partitions" = "0", "kafka_offsets" = "100"); to alter progress
  • fe down and leader change.
  • kafka offsets is the value before the alter change. which is {"0":"39"}, except is {"0":"99"}
  1. Restarting FE may also result in the loss of values changed by the alter command.

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@sollhui
Copy link
Contributor Author

sollhui commented May 21, 2024

run buildall

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-DS: Total hot run time: 179486 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1902339e6ae61eeebd8a972ca2845017d82b77a9, data reload: false

query1	914	379	354	354
query2	6271	2442	2430	2430
query3	6629	220	212	212
query4	23059	21845	21933	21845
query5	3565	418	442	418
query6	279	174	177	174
query7	4544	299	301	299
query8	244	181	198	181
query9	8659	2437	2490	2437
query10	430	241	247	241
query11	11726	11207	11498	11207
query12	119	90	84	84
query13	1696	366	363	363
query14	10518	8634	8519	8519
query15	267	175	175	175
query16	8147	257	246	246
query17	1689	564	551	551
query18	2087	288	283	283
query19	204	148	151	148
query20	91	85	84	84
query21	195	129	128	128
query22	4966	4791	4778	4778
query23	34048	33481	33532	33481
query24	10827	2892	2914	2892
query25	566	382	360	360
query26	703	150	150	150
query27	2175	313	309	309
query28	5988	2036	2023	2023
query29	841	612	599	599
query30	261	168	187	168
query31	965	734	754	734
query32	88	49	52	49
query33	734	237	245	237
query34	1048	470	469	469
query35	791	659	663	659
query36	1073	908	919	908
query37	106	67	66	66
query38	2892	2754	2731	2731
query39	1600	1569	1552	1552
query40	197	122	127	122
query41	43	42	42	42
query42	101	94	94	94
query43	573	573	512	512
query44	1243	720	729	720
query45	262	257	241	241
query46	1101	712	700	700
query47	1938	1836	1834	1834
query48	364	309	295	295
query49	861	389	377	377
query50	745	399	384	384
query51	6810	6746	6723	6723
query52	98	90	90	90
query53	355	278	282	278
query54	899	411	442	411
query55	73	73	71	71
query56	250	221	216	216
query57	1241	1154	1136	1136
query58	229	192	204	192
query59	3329	3003	3230	3003
query60	250	228	223	223
query61	89	85	86	85
query62	672	477	461	461
query63	310	282	272	272
query64	8685	2286	1697	1697
query65	3146	3097	3097	3097
query66	812	325	327	325
query67	15301	14915	15097	14915
query68	4501	525	534	525
query69	477	301	296	296
query70	1162	1145	1123	1123
query71	408	262	263	262
query72	7236	2633	2339	2339
query73	708	314	316	314
query74	6673	6281	6222	6222
query75	3349	2607	2620	2607
query76	2364	1030	1010	1010
query77	389	263	263	263
query78	10660	10243	10019	10019
query79	2517	509	523	509
query80	1096	420	426	420
query81	535	245	240	240
query82	736	90	92	90
query83	224	160	163	160
query84	239	79	84	79
query85	1432	271	261	261
query86	529	299	306	299
query87	3352	3107	3096	3096
query88	3980	2312	2329	2312
query89	460	376	366	366
query90	1939	186	182	182
query91	121	93	97	93
query92	53	48	45	45
query93	1931	495	480	480
query94	1076	172	171	171
query95	388	289	305	289
query96	587	261	261	261
query97	3199	2987	3000	2987
query98	240	217	216	216
query99	1177	893	890	890
Total cold run time: 274720 ms
Total hot run time: 179486 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1902339e6ae61eeebd8a972ca2845017d82b77a9, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.23	0.05	0.05
query4	1.68	0.06	0.06
query5	0.49	0.50	0.50
query6	1.12	0.72	0.72
query7	0.02	0.02	0.02
query8	0.05	0.05	0.05
query9	0.54	0.49	0.48
query10	0.54	0.54	0.53
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.59	0.59	0.60
query14	0.78	0.77	0.79
query15	0.83	0.80	0.81
query16	0.38	0.37	0.37
query17	1.02	1.00	1.02
query18	0.22	0.25	0.24
query19	1.86	1.74	1.79
query20	0.01	0.01	0.01
query21	15.64	0.67	0.66
query22	4.40	7.49	1.97
query23	18.24	1.50	1.30
query24	1.53	0.36	0.21
query25	0.14	0.08	0.09
query26	0.27	0.17	0.17
query27	0.07	0.08	0.08
query28	13.32	1.01	0.99
query29	13.56	3.30	3.25
query30	0.24	0.05	0.05
query31	2.89	0.39	0.38
query32	3.28	0.47	0.47
query33	2.83	2.95	2.88
query34	17.10	4.42	4.42
query35	4.48	4.52	4.52
query36	0.68	0.47	0.46
query37	0.18	0.15	0.16
query38	0.15	0.14	0.15
query39	0.04	0.03	0.04
query40	0.16	0.14	0.14
query41	0.09	0.05	0.04
query42	0.05	0.04	0.05
query43	0.05	0.04	0.03
Total cold run time: 110.17 s
Total hot run time: 30.68 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 21, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants