Skip to content

Conversation

@ByteYue
Copy link
Contributor

@ByteYue ByteYue commented May 22, 2024

Proposed changes

Issue Number: close #xxx

We're intended to extent the OSS support ability limit to S3-not compatible cloud vendor like Azure. This pr is the first step which introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file and BE feature enhancement would come soon.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

dataroaring
dataroaring previously approved these changes May 22, 2024
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

1 similar comment
@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@dataroaring
Copy link
Contributor

run buildall

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@github-actions
Copy link
Contributor

clang-tidy review says "All clean, LGTM! 👍"

@ByteYue
Copy link
Contributor Author

ByteYue commented May 29, 2024

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 29, 2024
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@ByteYue
Copy link
Contributor Author

ByteYue commented May 29, 2024

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 35.99% (9148/25419)
Line Coverage: 27.43% (75140/273910)
Region Coverage: 26.65% (38896/145961)
Branch Coverage: 23.48% (19796/84310)
Coverage Report: http://coverage.selectdb-in.cc/coverage/989af1ac75b07127531716566b0845f60e69cd50_989af1ac75b07127531716566b0845f60e69cd50/report/index.html

@doris-robot
Copy link

TPC-H: Total hot run time: 39990 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 989af1ac75b07127531716566b0845f60e69cd50, data reload: false

------ Round 1 ----------------------------------
q1	18192	4437	4373	4373
q2	2676	204	187	187
q3	12101	1141	1049	1049
q4	10588	851	744	744
q5	7836	2729	2676	2676
q6	225	135	141	135
q7	955	597	595	595
q8	9224	2065	2063	2063
q9	8802	6498	6469	6469
q10	8996	3712	3705	3705
q11	455	246	246	246
q12	431	222	221	221
q13	17753	3024	2978	2978
q14	266	218	222	218
q15	516	484	470	470
q16	498	386	386	386
q17	968	688	678	678
q18	7983	7502	7434	7434
q19	7111	1590	1514	1514
q20	657	316	315	315
q21	4881	3207	3233	3207
q22	380	327	330	327
Total cold run time: 121494 ms
Total hot run time: 39990 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4322	4238	4198	4198
q2	370	272	273	272
q3	2987	2807	2772	2772
q4	1914	1581	1654	1581
q5	5270	5300	5303	5300
q6	221	130	129	129
q7	2140	1723	1754	1723
q8	3202	3327	3339	3327
q9	8316	8380	8359	8359
q10	3876	3658	3645	3645
q11	599	484	493	484
q12	766	619	596	596
q13	17289	2994	3000	2994
q14	304	273	274	273
q15	524	475	473	473
q16	470	412	419	412
q17	1749	1471	1480	1471
q18	7672	7669	7453	7453
q19	1687	1559	1570	1559
q20	1982	1796	1806	1796
q21	5896	4795	4717	4717
q22	595	537	555	537
Total cold run time: 72151 ms
Total hot run time: 54071 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169684 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 989af1ac75b07127531716566b0845f60e69cd50, data reload: false

query1	924	375	364	364
query2	6453	2453	2365	2365
query3	6653	212	208	208
query4	19195	17439	17361	17361
query5	4194	425	418	418
query6	244	158	158	158
query7	4595	286	291	286
query8	322	290	284	284
query9	8500	2384	2365	2365
query10	451	309	253	253
query11	10526	10372	10024	10024
query12	131	87	85	85
query13	1642	353	360	353
query14	9943	7768	6936	6936
query15	247	186	189	186
query16	7985	269	251	251
query17	1857	515	511	511
query18	1861	296	280	280
query19	198	151	148	148
query20	91	87	86	86
query21	195	133	129	129
query22	4302	4169	4107	4107
query23	33560	33101	33043	33043
query24	12098	2809	2837	2809
query25	666	347	355	347
query26	1690	151	157	151
query27	2880	315	313	313
query28	7515	2030	2027	2027
query29	1003	590	592	590
query30	306	149	152	149
query31	977	791	752	752
query32	94	51	52	51
query33	757	266	256	256
query34	1052	490	467	467
query35	729	614	604	604
query36	1075	926	939	926
query37	272	66	72	66
query38	2880	2786	2756	2756
query39	857	808	807	807
query40	282	126	122	122
query41	55	50	52	50
query42	116	100	102	100
query43	565	589	576	576
query44	1173	743	752	743
query45	200	171	175	171
query46	1072	735	727	727
query47	1828	1758	1789	1758
query48	369	294	289	289
query49	1193	385	380	380
query50	772	380	385	380
query51	6850	6795	6689	6689
query52	105	94	91	91
query53	353	288	282	282
query54	996	466	413	413
query55	71	70	75	70
query56	252	244	242	242
query57	1128	1020	1043	1020
query58	236	205	208	205
query59	3405	3158	3324	3158
query60	280	251	250	250
query61	86	83	85	83
query62	651	427	468	427
query63	314	295	298	295
query64	9743	2246	1693	1693
query65	3182	3073	3110	3073
query66	1367	325	328	325
query67	15161	15060	15073	15060
query68	4512	519	530	519
query69	442	268	269	268
query70	1188	1088	1115	1088
query71	382	262	264	262
query72	7998	2727	2537	2537
query73	714	317	322	317
query74	6082	5666	5694	5666
query75	3319	2616	2621	2616
query76	2838	981	945	945
query77	394	275	270	270
query78	10160	9838	9723	9723
query79	2561	512	514	512
query80	948	433	426	426
query81	516	216	219	216
query82	836	95	95	95
query83	265	174	177	174
query84	240	88	83	83
query85	1512	271	258	258
query86	462	318	313	313
query87	3316	3075	3104	3075
query88	4168	2355	2357	2355
query89	472	384	400	384
query90	1951	188	186	186
query91	135	108	109	108
query92	58	50	50	50
query93	1756	501	494	494
query94	1207	205	194	194
query95	409	392	302	302
query96	590	274	258	258
query97	3149	3025	2984	2984
query98	232	218	209	209
query99	1100	853	853	853
Total cold run time: 274637 ms
Total hot run time: 169684 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.79 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 989af1ac75b07127531716566b0845f60e69cd50, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.24	0.05	0.06
query4	1.67	0.07	0.07
query5	0.50	0.47	0.50
query6	1.13	0.73	0.72
query7	0.01	0.01	0.01
query8	0.05	0.04	0.05
query9	0.52	0.51	0.50
query10	0.54	0.55	0.55
query11	0.15	0.11	0.12
query12	0.14	0.11	0.13
query13	0.59	0.59	0.60
query14	0.78	0.78	0.78
query15	0.83	0.82	0.81
query16	0.35	0.34	0.36
query17	0.99	0.94	0.97
query18	0.22	0.25	0.24
query19	1.81	1.66	1.67
query20	0.02	0.01	0.02
query21	15.70	0.67	0.67
query22	4.26	6.36	2.24
query23	18.32	1.43	1.23
query24	1.87	0.21	0.22
query25	0.14	0.09	0.09
query26	0.27	0.16	0.17
query27	0.08	0.07	0.08
query28	13.33	1.02	1.00
query29	13.13	3.30	3.28
query30	0.24	0.06	0.05
query31	2.86	0.39	0.38
query32	3.31	0.47	0.46
query33	2.91	2.87	2.91
query34	17.10	4.46	4.44
query35	4.45	4.54	4.53
query36	0.65	0.46	0.45
query37	0.19	0.16	0.16
query38	0.15	0.15	0.15
query39	0.04	0.03	0.04
query40	0.16	0.15	0.14
query41	0.09	0.05	0.04
query42	0.06	0.04	0.05
query43	0.04	0.04	0.03
Total cold run time: 110.01 s
Total hot run time: 30.79 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 5ab2646 into apache:master May 30, 2024
ByteYue added a commit to ByteYue/doris that referenced this pull request May 30, 2024
We're intended to extent the OSS support ability limit to S3-not
compatible cloud vendor like Azure. This pr is the first step which
introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file
and BE feature enhancement would come soon.

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
dataroaring pushed a commit that referenced this pull request May 31, 2024
We're intended to extent the OSS support ability limit to S3-not
compatible cloud vendor like Azure. This pr is the first step which
introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file
and BE feature enhancement would come soon.

Co-authored-by: zy-kkk <zhongyk10@gmail.com>
ByteYue added a commit to ByteYue/doris that referenced this pull request Jun 3, 2024
yiguolei pushed a commit that referenced this pull request Jun 3, 2024
…35826)

## Proposed changes

Issue Number: close #xxx

<!--Describe your changes.-->

This reverts commit #35641 because of the compilation of such is not
successful on arm plateform.
morningman added a commit that referenced this pull request Jun 6, 2024
This PR #35208 introduce azure core C++ sdk, it needs a higher version
of git to compile.
This PR add new repo for centos7 to be able to `yum install git` with
newer version.
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
This PR #35208 introduce azure core C++ sdk, it needs a higher version
of git to compile.
This PR add new repo for centos7 to be able to `yum install git` with
newer version.
morningman added a commit to morningman/doris that referenced this pull request Jun 27, 2024
This PR apache#35208 introduce azure core C++ sdk, it needs a higher version
of git to compile.
This PR add new repo for centos7 to be able to `yum install git` with
newer version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants