-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feature-wip](Cloud) Introduce azure core C++ sdk #35208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39990 ms |
TPC-DS: Total hot run time: 169684 ms |
ClickBench: Total hot run time: 30.79 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We're intended to extent the OSS support ability limit to S3-not compatible cloud vendor like Azure. This pr is the first step which introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file and BE feature enhancement would come soon. Co-authored-by: zy-kkk <zhongyk10@gmail.com>
We're intended to extent the OSS support ability limit to S3-not compatible cloud vendor like Azure. This pr is the first step which introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file and BE feature enhancement would come soon. Co-authored-by: zy-kkk <zhongyk10@gmail.com>
…) (apache#35641)" This reverts commit 2e4c2a6.
This PR #35208 introduce azure core C++ sdk, it needs a higher version of git to compile. This PR add new repo for centos7 to be able to `yum install git` with newer version.
This PR #35208 introduce azure core C++ sdk, it needs a higher version of git to compile. This PR add new repo for centos7 to be able to `yum install git` with newer version.
This PR apache#35208 introduce azure core C++ sdk, it needs a higher version of git to compile. This PR add new repo for centos7 to be able to `yum install git` with newer version.
Proposed changes
Issue Number: close #xxx
We're intended to extent the OSS support ability limit to S3-not compatible cloud vendor like Azure. This pr is the first step which introduces the Azure C++ sdk to BE. Consequent pr abort the CMake file and BE feature enhancement would come soon.
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...