Skip to content

Conversation

@airborne12
Copy link
Member

@airborne12 airborne12 commented May 23, 2024

Proposed changes

Issue Number: close #xxx

This pull request changes the default storage format for inverted indexes to V2. The V2 format enhances efficiency by merging all index files within a single segment into one file. This update aims to reduce IO cost when writing inverted index files, especially for cloud mode.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39958 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5061c38345c30689f8efbf8c061289d8ba96e380, data reload: false

------ Round 1 ----------------------------------
q1	17955	4373	4279	4279
q2	2016	187	189	187
q3	10696	1224	1260	1224
q4	10666	789	789	789
q5	7892	2695	2725	2695
q6	224	131	133	131
q7	957	606	600	600
q8	9477	2111	2101	2101
q9	9241	6581	6608	6581
q10	9865	3693	3708	3693
q11	461	248	230	230
q12	460	221	215	215
q13	18844	2980	2996	2980
q14	254	218	221	218
q15	517	472	472	472
q16	522	381	379	379
q17	956	652	614	614
q18	8062	7440	7295	7295
q19	1725	1511	1533	1511
q20	649	306	299	299
q21	4935	3905	3188	3188
q22	350	277	287	277
Total cold run time: 116724 ms
Total hot run time: 39958 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4260	4226	4221	4221
q2	364	267	260	260
q3	2943	2797	2709	2709
q4	1863	1568	1638	1568
q5	5253	5242	5274	5242
q6	213	124	128	124
q7	2112	1730	1732	1730
q8	3187	3291	3613	3291
q9	8297	8273	8350	8273
q10	3895	3678	3711	3678
q11	573	489	484	484
q12	736	607	588	588
q13	16381	2993	2977	2977
q14	296	268	251	251
q15	507	470	473	470
q16	488	420	414	414
q17	1757	1457	1476	1457
q18	7758	7645	7517	7517
q19	2413	1581	1537	1537
q20	1985	1754	1800	1754
q21	10380	4815	4741	4741
q22	586	498	491	491
Total cold run time: 76247 ms
Total hot run time: 53777 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 171687 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5061c38345c30689f8efbf8c061289d8ba96e380, data reload: false

query1	921	383	376	376
query2	6461	2456	2320	2320
query3	6650	203	205	203
query4	20300	17407	17380	17380
query5	4199	418	429	418
query6	246	156	150	150
query7	4584	304	294	294
query8	245	190	183	183
query9	8668	2451	2432	2432
query10	447	284	287	284
query11	10421	9935	10036	9935
query12	133	88	88	88
query13	1637	372	357	357
query14	10020	6946	6831	6831
query15	211	172	174	172
query16	7827	264	257	257
query17	1688	516	518	516
query18	1908	271	284	271
query19	215	183	156	156
query20	95	83	85	83
query21	198	127	130	127
query22	4262	4005	3823	3823
query23	33562	32978	33077	32978
query24	12203	2789	2877	2789
query25	676	348	377	348
query26	1791	161	156	156
query27	3029	317	320	317
query28	7580	2080	2099	2080
query29	1113	621	593	593
query30	276	166	176	166
query31	976	757	743	743
query32	88	55	55	55
query33	773	290	280	280
query34	1000	477	484	477
query35	765	619	603	603
query36	1081	896	914	896
query37	298	74	74	74
query38	2969	2802	2766	2766
query39	849	796	810	796
query40	277	133	130	130
query41	49	47	46	46
query42	108	97	98	97
query43	615	530	513	513
query44	1207	731	735	731
query45	184	168	166	166
query46	1075	720	702	702
query47	1868	1751	1786	1751
query48	376	304	296	296
query49	1200	384	384	384
query50	781	403	393	393
query51	6663	6696	6554	6554
query52	103	89	89	89
query53	346	287	285	285
query54	917	441	435	435
query55	76	74	72	72
query56	257	249	252	249
query57	1119	1062	1023	1023
query58	264	225	207	207
query59	3632	3067	3326	3067
query60	281	273	249	249
query61	91	85	87	85
query62	636	441	450	441
query63	304	282	285	282
query64	9823	2240	1741	1741
query65	3199	3094	3170	3094
query66	1363	331	324	324
query67	15432	14801	14811	14801
query68	4532	534	542	534
query69	432	264	263	263
query70	1114	1084	1177	1084
query71	397	271	271	271
query72	7794	5492	5632	5492
query73	734	323	327	323
query74	6063	5572	5509	5509
query75	3333	2611	2654	2611
query76	2638	1031	1014	1014
query77	407	264	264	264
query78	10299	9828	9645	9645
query79	2054	503	516	503
query80	806	444	439	439
query81	518	250	248	248
query82	1320	95	94	94
query83	192	175	169	169
query84	242	85	87	85
query85	1533	267	261	261
query86	503	300	302	300
query87	3235	3129	3105	3105
query88	4025	2406	2425	2406
query89	466	395	376	376
query90	1967	188	191	188
query91	126	100	96	96
query92	66	51	53	51
query93	2026	522	500	500
query94	1236	197	195	195
query95	422	325	327	325
query96	587	272	269	269
query97	3243	3035	3022	3022
query98	253	239	216	216
query99	1190	849	855	849
Total cold run time: 276364 ms
Total hot run time: 171687 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.38 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5061c38345c30689f8efbf8c061289d8ba96e380, data reload: false

query1	0.04	0.03	0.03
query2	0.10	0.05	0.04
query3	0.23	0.05	0.05
query4	1.67	0.10	0.09
query5	0.49	0.50	0.52
query6	1.13	0.72	0.72
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.54	0.56	0.55
query11	0.15	0.12	0.11
query12	0.14	0.11	0.12
query13	0.59	0.59	0.60
query14	0.80	0.78	0.79
query15	0.83	0.81	0.82
query16	0.37	0.37	0.38
query17	1.02	0.95	1.04
query18	0.22	0.22	0.26
query19	1.85	1.69	1.74
query20	0.02	0.01	0.01
query21	15.72	0.66	0.66
query22	4.19	7.66	1.75
query23	18.30	1.32	1.29
query24	1.41	0.41	0.22
query25	0.13	0.08	0.08
query26	0.28	0.17	0.17
query27	0.08	0.08	0.08
query28	13.26	1.01	0.99
query29	13.20	3.28	3.29
query30	0.26	0.07	0.05
query31	2.87	0.38	0.39
query32	3.29	0.48	0.46
query33	2.87	2.93	2.90
query34	17.10	4.42	4.38
query35	4.46	4.53	4.48
query36	0.66	0.46	0.46
query37	0.17	0.15	0.15
query38	0.16	0.15	0.15
query39	0.05	0.03	0.03
query40	0.16	0.14	0.14
query41	0.10	0.05	0.05
query42	0.05	0.04	0.05
query43	0.04	0.04	0.04
Total cold run time: 109.61 s
Total hot run time: 30.38 s

@airborne12
Copy link
Member Author

run buildall

Copy link
Contributor

@zzzxl1993 zzzxl1993 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 42134 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0f40c71a8127cf47f38ebbdf6deceb20c3f1ea52, data reload: false

------ Round 1 ----------------------------------
q1	17600	5002	4290	4290
q2	2021	192	201	192
q3	10482	1210	1267	1210
q4	10202	812	847	812
q5	7458	2768	2759	2759
q6	231	129	131	129
q7	965	613	604	604
q8	9222	2159	2122	2122
q9	9397	6705	6678	6678
q10	9147	3905	3831	3831
q11	459	266	236	236
q12	491	219	231	219
q13	17318	3298	3199	3199
q14	270	234	224	224
q15	528	486	490	486
q16	519	405	406	405
q17	991	691	731	691
q18	8384	7906	7980	7906
q19	6933	1579	1566	1566
q20	641	317	319	317
q21	5274	3970	4120	3970
q22	363	294	288	288
Total cold run time: 118896 ms
Total hot run time: 42134 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4535	4480	4432	4432
q2	381	268	257	257
q3	3193	2951	2798	2798
q4	2009	1677	1587	1587
q5	5332	5686	5485	5485
q6	216	127	119	119
q7	2155	1875	1860	1860
q8	3254	3426	3380	3380
q9	8607	8628	8673	8628
q10	4065	3844	3702	3702
q11	582	500	492	492
q12	797	619	637	619
q13	15987	3198	3179	3179
q14	311	267	285	267
q15	526	483	483	483
q16	484	457	449	449
q17	1834	1517	1515	1515
q18	8070	7728	7555	7555
q19	1684	1578	1577	1577
q20	2011	1809	1780	1780
q21	8662	4697	4851	4697
q22	568	471	478	471
Total cold run time: 75263 ms
Total hot run time: 55332 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 169739 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0f40c71a8127cf47f38ebbdf6deceb20c3f1ea52, data reload: false

query1	911	379	375	375
query2	6433	2546	2362	2362
query3	6635	217	217	217
query4	19263	17331	17250	17250
query5	4120	420	426	420
query6	248	154	161	154
query7	4575	308	291	291
query8	253	195	189	189
query9	8409	2377	2383	2377
query10	462	292	290	290
query11	10625	10113	10275	10113
query12	141	91	88	88
query13	1666	364	362	362
query14	9327	7090	6922	6922
query15	222	167	171	167
query16	7749	271	269	269
query17	1355	519	510	510
query18	1938	274	271	271
query19	199	155	154	154
query20	95	85	87	85
query21	192	131	130	130
query22	4265	3968	3969	3968
query23	33651	32986	33084	32986
query24	11979	2830	2778	2778
query25	642	353	367	353
query26	1699	160	161	160
query27	2927	328	326	326
query28	7514	2051	2055	2051
query29	1064	613	590	590
query30	255	175	176	175
query31	959	745	769	745
query32	98	54	51	51
query33	755	260	257	257
query34	1014	487	471	471
query35	733	592	597	592
query36	1040	935	911	911
query37	269	69	72	69
query38	2915	2772	2765	2765
query39	858	795	798	795
query40	241	131	129	129
query41	50	48	49	48
query42	104	96	98	96
query43	575	544	553	544
query44	1245	723	743	723
query45	181	169	169	169
query46	1091	751	758	751
query47	1848	1762	1791	1762
query48	368	293	286	286
query49	974	401	381	381
query50	768	380	383	380
query51	6939	6880	6697	6697
query52	109	90	92	90
query53	354	292	288	288
query54	954	424	426	424
query55	74	73	73	73
query56	253	240	242	240
query57	1131	1041	1018	1018
query58	243	209	223	209
query59	3609	3183	3334	3183
query60	297	258	242	242
query61	87	87	87	87
query62	633	429	467	429
query63	310	284	287	284
query64	9645	2248	1705	1705
query65	3166	3072	3125	3072
query66	1324	331	329	329
query67	15105	14961	14898	14898
query68	4634	543	535	535
query69	486	270	262	262
query70	1188	1166	1128	1128
query71	383	274	261	261
query72	7689	5595	2702	2702
query73	728	327	322	322
query74	6088	5667	5696	5667
query75	3366	2646	2661	2646
query76	3079	979	1079	979
query77	601	273	317	273
query78	10186	10109	9802	9802
query79	2733	520	512	512
query80	1925	459	429	429
query81	545	239	242	239
query82	1056	98	94	94
query83	300	173	177	173
query84	275	90	84	84
query85	1550	271	251	251
query86	478	331	314	314
query87	3339	3113	3137	3113
query88	4009	2326	2338	2326
query89	496	395	381	381
query90	1978	186	194	186
query91	132	108	108	108
query92	62	48	49	48
query93	2248	496	503	496
query94	1268	195	196	195
query95	418	363	301	301
query96	587	266	268	266
query97	3223	3016	3079	3016
query98	242	219	218	218
query99	1200	869	836	836
Total cold run time: 275625 ms
Total hot run time: 169739 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0f40c71a8127cf47f38ebbdf6deceb20c3f1ea52, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.08	0.09
query5	0.51	0.48	0.50
query6	1.12	0.73	0.72
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.54	0.50	0.48
query10	0.54	0.56	0.54
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.60	0.59	0.59
query14	0.77	0.77	0.79
query15	0.84	0.81	0.81
query16	0.34	0.37	0.37
query17	0.97	0.96	0.96
query18	0.21	0.25	0.23
query19	1.86	1.72	1.71
query20	0.01	0.01	0.01
query21	15.65	0.67	0.65
query22	4.51	7.27	2.03
query23	18.32	1.37	1.39
query24	1.81	0.22	0.22
query25	0.16	0.08	0.08
query26	0.26	0.16	0.17
query27	0.08	0.08	0.08
query28	13.36	1.02	1.00
query29	13.81	3.33	3.31
query30	0.24	0.06	0.06
query31	2.89	0.39	0.40
query32	3.25	0.47	0.47
query33	2.83	2.90	2.96
query34	17.10	4.40	4.42
query35	4.55	4.48	4.62
query36	0.66	0.46	0.46
query37	0.17	0.15	0.15
query38	0.15	0.15	0.15
query39	0.05	0.04	0.03
query40	0.16	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.05	0.05
query43	0.04	0.03	0.04
Total cold run time: 110.91 s
Total hot run time: 30.82 s

qidaye
qidaye previously approved these changes May 24, 2024
Copy link
Contributor

@qidaye qidaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 24, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@qidaye
Copy link
Contributor

qidaye commented May 24, 2024

run p0

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label May 24, 2024
@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41969 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d1f5a383269881359373eba82db1efaebd8e0708, data reload: false

------ Round 1 ----------------------------------
q1	17585	4392	4225	4225
q2	2007	184	188	184
q3	10454	1240	1240	1240
q4	10206	812	788	788
q5	7475	2705	2671	2671
q6	220	130	136	130
q7	981	614	605	605
q8	9230	2126	2095	2095
q9	9529	6729	6694	6694
q10	9596	3932	3835	3835
q11	449	250	249	249
q12	481	224	237	224
q13	17485	3213	3295	3213
q14	252	201	217	201
q15	511	473	465	465
q16	483	399	408	399
q17	970	707	718	707
q18	8374	7938	7888	7888
q19	3529	1588	1540	1540
q20	654	329	317	317
q21	5183	4024	4043	4024
q22	370	283	275	275
Total cold run time: 116024 ms
Total hot run time: 41969 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4505	4393	4422	4393
q2	370	266	269	266
q3	3133	2985	2765	2765
q4	1938	1617	1642	1617
q5	5475	5528	5516	5516
q6	219	127	123	123
q7	2201	1882	1868	1868
q8	3168	3352	3381	3352
q9	8660	8681	8569	8569
q10	3868	3886	3836	3836
q11	594	500	494	494
q12	809	637	626	626
q13	15868	3208	3240	3208
q14	314	293	268	268
q15	520	481	490	481
q16	497	433	425	425
q17	1768	1492	1487	1487
q18	7772	7698	7495	7495
q19	1710	1641	1568	1568
q20	2029	1836	1812	1812
q21	8543	4741	4792	4741
q22	574	473	494	473
Total cold run time: 74535 ms
Total hot run time: 55383 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 170571 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d1f5a383269881359373eba82db1efaebd8e0708, data reload: false

query1	925	381	378	378
query2	6440	2657	2405	2405
query3	6798	217	222	217
query4	23551	18211	18128	18128
query5	6065	435	435	435
query6	247	158	151	151
query7	4990	315	308	308
query8	988	195	189	189
query9	11213	2435	2431	2431
query10	1041	291	280	280
query11	10888	10183	10143	10143
query12	141	99	88	88
query13	1648	373	370	370
query14	8893	7318	7503	7318
query15	246	167	170	167
query16	8139	257	257	257
query17	1824	521	513	513
query18	2100	273	311	273
query19	329	156	150	150
query20	100	80	83	80
query21	194	130	130	130
query22	4198	3903	4079	3903
query23	33877	33029	32861	32861
query24	9681	2896	2760	2760
query25	546	350	355	350
query26	688	157	155	155
query27	2093	338	326	326
query28	5834	2099	2068	2068
query29	847	619	625	619
query30	237	168	173	168
query31	932	742	715	715
query32	90	52	52	52
query33	655	264	254	254
query34	853	475	486	475
query35	697	608	628	608
query36	1071	924	923	923
query37	105	71	68	68
query38	2913	2797	2748	2748
query39	829	788	779	779
query40	198	124	127	124
query41	46	43	47	43
query42	105	98	98	98
query43	590	552	565	552
query44	1103	731	755	731
query45	180	169	162	162
query46	1067	716	724	716
query47	1849	1774	1780	1774
query48	363	300	301	300
query49	817	374	379	374
query50	771	403	391	391
query51	6622	6642	6651	6642
query52	102	94	91	91
query53	349	293	293	293
query54	850	429	425	425
query55	72	72	71	71
query56	260	244	240	240
query57	1097	1052	1039	1039
query58	235	228	206	206
query59	3501	3018	3146	3018
query60	272	265	248	248
query61	91	86	89	86
query62	594	450	455	450
query63	310	290	289	289
query64	8490	2229	1777	1777
query65	3148	3102	3089	3089
query66	795	327	318	318
query67	15080	14859	14860	14859
query68	4550	547	543	543
query69	479	266	265	265
query70	1137	1148	1128	1128
query71	387	275	271	271
query72	7645	2707	2480	2480
query73	723	325	326	325
query74	5995	5665	5725	5665
query75	3358	2600	2618	2600
query76	2682	1033	966	966
query77	593	271	276	271
query78	10176	10029	9800	9800
query79	1686	531	518	518
query80	839	473	433	433
query81	550	235	238	235
query82	467	101	95	95
query83	243	172	168	168
query84	247	83	83	83
query85	1160	272	272	272
query86	440	305	322	305
query87	3282	3116	3137	3116
query88	4011	2332	2353	2332
query89	476	381	375	375
query90	2024	196	191	191
query91	122	97	94	94
query92	63	49	50	49
query93	1773	522	522	522
query94	1255	184	184	184
query95	396	313	312	312
query96	585	270	270	270
query97	3203	3000	3011	3000
query98	247	219	217	217
query99	1138	837	867	837
Total cold run time: 273795 ms
Total hot run time: 170571 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.82 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d1f5a383269881359373eba82db1efaebd8e0708, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.03	0.04
query3	0.23	0.05	0.05
query4	1.68	0.07	0.07
query5	0.50	0.50	0.52
query6	1.12	0.72	0.74
query7	0.02	0.01	0.02
query8	0.05	0.03	0.04
query9	0.54	0.50	0.50
query10	0.54	0.56	0.54
query11	0.16	0.12	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.58
query14	0.80	0.79	0.77
query15	0.82	0.81	0.80
query16	0.34	0.35	0.36
query17	0.93	1.01	0.93
query18	0.22	0.25	0.24
query19	1.81	1.75	1.82
query20	0.01	0.01	0.02
query21	15.43	0.70	0.67
query22	4.66	6.39	2.24
query23	18.28	1.35	1.19
query24	1.61	0.26	0.31
query25	0.14	0.08	0.07
query26	0.26	0.17	0.16
query27	0.08	0.08	0.08
query28	13.22	1.03	0.99
query29	12.82	3.32	3.28
query30	0.25	0.05	0.05
query31	2.87	0.38	0.40
query32	3.28	0.47	0.47
query33	2.87	2.84	2.94
query34	16.92	4.44	4.41
query35	4.49	4.52	4.53
query36	0.69	0.48	0.48
query37	0.18	0.16	0.15
query38	0.14	0.14	0.15
query39	0.05	0.03	0.04
query40	0.16	0.15	0.14
query41	0.09	0.04	0.05
query42	0.05	0.04	0.04
query43	0.04	0.04	0.04
Total cold run time: 109.2 s
Total hot run time: 30.82 s

@airborne12
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41475 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0cd17ad35ad593ac1b61d212dd5a6e6bbea9d2af, data reload: false

------ Round 1 ----------------------------------
q1	17911	5254	4468	4468
q2	2027	212	194	194
q3	5304	1258	1375	1258
q4	10123	832	833	832
q5	7539	2766	2703	2703
q6	228	137	132	132
q7	998	619	615	615
q8	9264	2145	2110	2110
q9	9284	6770	6824	6770
q10	9126	3941	3935	3935
q11	473	249	231	231
q12	452	223	220	220
q13	17761	3078	3108	3078
q14	274	222	224	222
q15	523	467	483	467
q16	548	398	381	381
q17	1004	655	760	655
q18	8425	7983	7841	7841
q19	7614	1603	1500	1500
q20	676	341	337	337
q21	5133	3899	3252	3252
q22	340	274	280	274
Total cold run time: 115027 ms
Total hot run time: 41475 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4541	4401	4485	4401
q2	378	287	283	283
q3	3153	2928	2980	2928
q4	1976	1628	1603	1603
q5	5301	5334	5314	5314
q6	210	122	124	122
q7	2220	1744	1729	1729
q8	3180	3343	3314	3314
q9	8339	8368	8376	8368
q10	3901	3672	3692	3672
q11	563	472	489	472
q12	773	582	620	582
q13	15869	2961	2970	2961
q14	279	266	249	249
q15	517	469	465	465
q16	481	407	407	407
q17	1768	1473	1496	1473
q18	7727	7705	7491	7491
q19	2628	1562	1543	1543
q20	1979	1792	1764	1764
q21	4980	4771	4748	4748
q22	576	480	489	480
Total cold run time: 71339 ms
Total hot run time: 54369 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 168630 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 0cd17ad35ad593ac1b61d212dd5a6e6bbea9d2af, data reload: false

query1	914	381	364	364
query2	6447	2465	2334	2334
query3	6645	203	205	203
query4	18998	17445	17325	17325
query5	4095	415	417	415
query6	245	155	154	154
query7	4589	297	297	297
query8	243	187	180	180
query9	8549	2400	2401	2400
query10	454	279	268	268
query11	10529	10160	10152	10152
query12	135	97	92	92
query13	1639	354	348	348
query14	10058	6516	6861	6516
query15	227	167	181	167
query16	7796	263	250	250
query17	1498	523	528	523
query18	1920	277	267	267
query19	208	164	154	154
query20	91	100	86	86
query21	204	133	133	133
query22	4241	4006	4114	4006
query23	34415	33075	32812	32812
query24	6867	2860	2812	2812
query25	576	348	385	348
query26	706	154	154	154
query27	2033	313	320	313
query28	3767	2080	2090	2080
query29	863	611	602	602
query30	301	171	175	171
query31	965	742	736	736
query32	94	51	52	51
query33	500	269	258	258
query34	862	466	469	466
query35	702	622	588	588
query36	1053	926	895	895
query37	103	70	74	70
query38	2911	2791	2758	2758
query39	881	793	800	793
query40	196	124	131	124
query41	46	51	50	50
query42	105	98	96	96
query43	611	555	529	529
query44	1070	727	748	727
query45	180	164	166	164
query46	1051	705	733	705
query47	1855	1758	1783	1758
query48	360	294	297	294
query49	846	381	385	381
query50	764	386	383	383
query51	6710	6704	6535	6535
query52	103	91	92	91
query53	349	276	285	276
query54	528	432	427	427
query55	79	75	73	73
query56	305	237	257	237
query57	1128	1032	1052	1032
query58	228	202	207	202
query59	3237	3213	3052	3052
query60	276	259	247	247
query61	87	85	84	84
query62	578	439	443	439
query63	304	283	290	283
query64	8595	2201	1699	1699
query65	3151	3074	3053	3053
query66	784	332	320	320
query67	15260	14958	14941	14941
query68	4633	542	534	534
query69	453	267	265	265
query70	1134	1170	1146	1146
query71	398	273	267	267
query72	7899	5253	2732	2732
query73	717	316	313	313
query74	6098	5559	5570	5559
query75	3301	2535	2624	2535
query76	2422	1058	1024	1024
query77	553	280	275	275
query78	10321	10178	9720	9720
query79	2774	511	516	511
query80	1975	436	447	436
query81	530	240	248	240
query82	1232	96	95	95
query83	291	174	166	166
query84	267	89	85	85
query85	1160	261	304	261
query86	456	327	309	309
query87	3280	3109	3067	3067
query88	4061	2327	2339	2327
query89	468	375	396	375
query90	2057	194	185	185
query91	123	95	95	95
query92	63	50	48	48
query93	2687	519	494	494
query94	1198	179	183	179
query95	392	307	312	307
query96	609	265	270	265
query97	3195	3030	3019	3019
query98	239	225	214	214
query99	1145	839	883	839
Total cold run time: 262241 ms
Total hot run time: 168630 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.27 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 0cd17ad35ad593ac1b61d212dd5a6e6bbea9d2af, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.03
query3	0.23	0.05	0.05
query4	1.68	0.08	0.07
query5	0.50	0.49	0.50
query6	1.12	0.72	0.73
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.54	0.49	0.50
query10	0.55	0.56	0.54
query11	0.15	0.12	0.11
query12	0.14	0.12	0.12
query13	0.58	0.60	0.59
query14	0.79	0.77	0.78
query15	0.83	0.82	0.81
query16	0.36	0.36	0.37
query17	0.95	1.04	0.95
query18	0.23	0.23	0.26
query19	1.83	1.69	1.69
query20	0.01	0.01	0.01
query21	15.76	0.65	0.64
query22	4.14	7.29	1.62
query23	18.31	1.38	1.34
query24	2.07	0.21	0.21
query25	0.16	0.09	0.09
query26	0.27	0.17	0.17
query27	0.08	0.08	0.07
query28	13.24	1.00	1.00
query29	13.74	3.40	3.33
query30	0.24	0.06	0.05
query31	2.86	0.40	0.38
query32	3.30	0.46	0.46
query33	2.87	2.90	2.88
query34	17.11	4.37	4.38
query35	4.50	4.50	4.60
query36	0.66	0.48	0.46
query37	0.17	0.15	0.16
query38	0.15	0.14	0.14
query39	0.05	0.03	0.04
query40	0.16	0.14	0.15
query41	0.09	0.05	0.04
query42	0.05	0.05	0.04
query43	0.05	0.04	0.04
Total cold run time: 110.71 s
Total hot run time: 30.27 s

xiaokang
xiaokang previously approved these changes May 26, 2024
Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label May 26, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@doris-robot
Copy link

ClickBench: Total hot run time: 29.96 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43e70649afef93b4adc68ff3d1c5e66329d6933a, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.24	0.04	0.04
query4	1.68	0.07	0.07
query5	0.50	0.47	0.51
query6	1.12	0.72	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.55	0.55	0.54
query11	0.16	0.12	0.11
query12	0.14	0.12	0.13
query13	0.59	0.59	0.60
query14	0.76	0.77	0.77
query15	0.82	0.81	0.80
query16	0.35	0.37	0.34
query17	1.01	0.95	0.98
query18	0.22	0.24	0.22
query19	1.83	1.69	1.80
query20	0.01	0.01	0.01
query21	15.46	0.73	0.67
query22	4.38	7.79	1.46
query23	18.34	1.40	1.21
query24	1.93	0.20	0.21
query25	0.15	0.08	0.07
query26	0.27	0.18	0.17
query27	0.08	0.07	0.07
query28	13.36	1.02	1.00
query29	13.22	3.27	3.30
query30	0.24	0.07	0.05
query31	2.86	0.38	0.40
query32	3.27	0.48	0.47
query33	2.86	2.97	2.89
query34	17.19	4.42	4.46
query35	4.48	4.55	4.52
query36	0.65	0.47	0.48
query37	0.19	0.15	0.16
query38	0.15	0.14	0.15
query39	0.04	0.04	0.04
query40	0.19	0.13	0.14
query41	0.10	0.05	0.05
query42	0.06	0.05	0.05
query43	0.04	0.04	0.04
Total cold run time: 110.22 s
Total hot run time: 29.96 s

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40079 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1162906a6e3e97e6f80ffa7745809e361d4c7267, data reload: false

------ Round 1 ----------------------------------
q1	18075	4611	4334	4334
q2	2032	194	201	194
q3	10451	1236	1123	1123
q4	10153	755	781	755
q5	7482	2658	2714	2658
q6	216	130	132	130
q7	955	604	599	599
q8	9223	2127	2108	2108
q9	8782	6537	6515	6515
q10	8942	3729	3725	3725
q11	453	238	236	236
q12	399	233	235	233
q13	17794	3018	2975	2975
q14	282	228	222	222
q15	508	476	473	473
q16	514	378	382	378
q17	975	642	696	642
q18	8243	7604	7437	7437
q19	7763	1526	1487	1487
q20	664	314	310	310
q21	4991	3272	3218	3218
q22	381	327	334	327
Total cold run time: 119278 ms
Total hot run time: 40079 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4376	4241	4216	4216
q2	375	281	265	265
q3	2998	2758	2734	2734
q4	1883	1636	1566	1566
q5	5260	5295	5311	5295
q6	213	128	128	128
q7	2116	1765	1777	1765
q8	3224	3353	3369	3353
q9	8429	8388	8390	8388
q10	3902	3647	3613	3613
q11	594	478	481	478
q12	797	613	622	613
q13	17685	2976	2970	2970
q14	296	264	271	264
q15	505	478	473	473
q16	497	411	411	411
q17	1801	1488	1476	1476
q18	7683	7463	7371	7371
q19	1728	1487	1608	1487
q20	1985	1797	1775	1775
q21	4941	4765	4665	4665
q22	651	540	561	540
Total cold run time: 71939 ms
Total hot run time: 53846 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.42% (8986/24675)
Line Coverage: 27.93% (73388/262763)
Region Coverage: 27.37% (38010/138875)
Branch Coverage: 23.96% (19291/80510)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1162906a6e3e97e6f80ffa7745809e361d4c7267_1162906a6e3e97e6f80ffa7745809e361d4c7267/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 173342 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1162906a6e3e97e6f80ffa7745809e361d4c7267, data reload: false

query1	929	379	372	372
query2	6455	2426	2423	2423
query3	6649	207	210	207
query4	19115	17248	17395	17248
query5	4127	451	450	450
query6	255	158	153	153
query7	4585	302	290	290
query8	333	298	309	298
query9	8490	2440	2420	2420
query10	460	302	278	278
query11	10547	10029	10110	10029
query12	142	88	85	85
query13	1631	361	350	350
query14	8611	7754	7543	7543
query15	226	194	186	186
query16	7949	256	261	256
query17	1859	546	536	536
query18	1968	264	267	264
query19	203	154	154	154
query20	90	91	86	86
query21	212	125	136	125
query22	4392	4117	3995	3995
query23	33767	33199	32905	32905
query24	10663	2862	2851	2851
query25	645	368	400	368
query26	1426	189	149	149
query27	2979	324	324	324
query28	7356	2057	2059	2057
query29	937	621	611	611
query30	271	148	151	148
query31	949	742	712	712
query32	86	51	59	51
query33	759	269	267	267
query34	1038	478	465	465
query35	759	644	604	604
query36	1106	913	918	913
query37	151	70	70	70
query38	2875	2785	2703	2703
query39	878	792	786	786
query40	206	122	124	122
query41	55	45	44	44
query42	123	96	95	95
query43	597	539	536	536
query44	1219	741	755	741
query45	194	164	168	164
query46	1080	720	711	711
query47	1874	1755	1780	1755
query48	396	306	291	291
query49	1074	393	406	393
query50	803	386	391	386
query51	6760	6608	6634	6608
query52	105	86	93	86
query53	353	290	295	290
query54	880	450	442	442
query55	74	72	73	72
query56	281	256	252	252
query57	1105	1082	1063	1063
query58	252	248	243	243
query59	3408	3275	3383	3275
query60	295	264	271	264
query61	103	83	89	83
query62	630	449	456	449
query63	320	292	292	292
query64	8953	2285	1696	1696
query65	3176	3136	3130	3130
query66	1222	325	322	322
query67	15509	15169	14944	14944
query68	4564	538	543	538
query69	457	293	327	293
query70	1182	1092	1095	1092
query71	404	281	276	276
query72	7130	5632	5653	5632
query73	750	323	319	319
query74	5972	5479	5446	5446
query75	3451	2657	2659	2657
query76	2895	1018	955	955
query77	486	294	288	288
query78	10266	9867	9808	9808
query79	2569	514	516	514
query80	1166	465	450	450
query81	590	221	220	220
query82	731	101	105	101
query83	236	169	166	166
query84	246	86	83	83
query85	1914	261	270	261
query86	526	297	311	297
query87	3271	3126	3070	3070
query88	3867	2356	2363	2356
query89	472	408	387	387
query90	1849	199	193	193
query91	127	103	109	103
query92	66	50	52	50
query93	1907	518	506	506
query94	1223	197	199	197
query95	414	391	312	312
query96	581	271	267	267
query97	3185	2988	3060	2988
query98	246	210	209	209
query99	1189	827	839	827
Total cold run time: 270852 ms
Total hot run time: 173342 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.16 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1162906a6e3e97e6f80ffa7745809e361d4c7267, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.03	0.04
query3	0.23	0.05	0.04
query4	1.67	0.06	0.07
query5	0.49	0.50	0.50
query6	1.12	0.72	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.04
query9	0.54	0.50	0.50
query10	0.54	0.54	0.55
query11	0.15	0.10	0.11
query12	0.14	0.12	0.12
query13	0.59	0.59	0.60
query14	0.78	0.81	0.79
query15	0.82	0.82	0.82
query16	0.36	0.36	0.36
query17	0.97	0.98	0.96
query18	0.21	0.25	0.24
query19	1.78	1.67	1.68
query20	0.01	0.02	0.01
query21	15.67	0.66	0.64
query22	4.02	7.81	1.71
query23	18.20	1.35	1.22
query24	1.90	0.24	0.20
query25	0.15	0.09	0.07
query26	0.28	0.17	0.18
query27	0.07	0.09	0.08
query28	13.24	1.01	0.98
query29	13.40	3.30	3.26
query30	0.24	0.06	0.06
query31	2.86	0.40	0.38
query32	3.26	0.47	0.48
query33	2.93	2.92	2.88
query34	16.94	4.40	4.41
query35	4.54	4.46	4.52
query36	0.64	0.46	0.46
query37	0.16	0.15	0.15
query38	0.16	0.14	0.15
query39	0.05	0.03	0.04
query40	0.17	0.15	0.15
query41	0.09	0.05	0.04
query42	0.06	0.05	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.65 s
Total hot run time: 30.16 s

@airborne12
Copy link
Member Author

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

TPC-H: Total hot run time: 40132 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit f8ac28bf88644f259afeb0ade6af2b08c8189471, data reload: false

------ Round 1 ----------------------------------
q1	18071	4849	4418	4418
q2	3016	199	206	199
q3	11203	1138	1145	1138
q4	10361	773	823	773
q5	7796	2723	2643	2643
q6	221	137	140	137
q7	988	621	608	608
q8	9251	2125	2105	2105
q9	8952	6511	6484	6484
q10	8912	3699	3744	3699
q11	456	242	236	236
q12	421	236	225	225
q13	18837	2996	3012	2996
q14	260	227	236	227
q15	516	479	486	479
q16	536	393	387	387
q17	986	709	722	709
q18	8072	7494	7377	7377
q19	8694	1574	1467	1467
q20	657	313	306	306
q21	4959	3991	3187	3187
q22	395	333	332	332
Total cold run time: 123560 ms
Total hot run time: 40132 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4400	4245	4193	4193
q2	369	273	271	271
q3	2982	2715	2769	2715
q4	1889	1629	1653	1629
q5	5290	5289	5325	5289
q6	215	125	132	125
q7	2085	1723	1743	1723
q8	3226	3317	3303	3303
q9	8352	8377	8345	8345
q10	3878	3701	3646	3646
q11	569	493	488	488
q12	767	589	591	589
q13	17526	2972	2953	2953
q14	300	256	267	256
q15	512	465	482	465
q16	469	411	409	409
q17	1785	1498	1506	1498
q18	7622	7435	7406	7406
q19	2486	1597	1657	1597
q20	2020	1780	1765	1765
q21	4843	4683	4607	4607
q22	635	527	526	526
Total cold run time: 72220 ms
Total hot run time: 53798 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.40% (8983/24676)
Line Coverage: 27.92% (73398/262847)
Region Coverage: 27.35% (38001/138922)
Branch Coverage: 23.95% (19290/80530)
Coverage Report: http://coverage.selectdb-in.cc/coverage/f8ac28bf88644f259afeb0ade6af2b08c8189471_f8ac28bf88644f259afeb0ade6af2b08c8189471/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 171092 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit f8ac28bf88644f259afeb0ade6af2b08c8189471, data reload: false

query1	936	378	376	376
query2	6456	2432	2315	2315
query3	6658	209	204	204
query4	19799	17367	17292	17292
query5	4106	480	467	467
query6	242	162	160	160
query7	4590	296	287	287
query8	324	291	287	287
query9	8467	2415	2401	2401
query10	431	303	265	265
query11	10437	9937	9949	9937
query12	135	87	90	87
query13	1629	350	356	350
query14	10132	6861	6095	6095
query15	230	187	183	183
query16	7666	268	266	266
query17	1394	534	532	532
query18	1969	278	274	274
query19	204	155	161	155
query20	98	95	93	93
query21	209	131	132	131
query22	4218	3952	4132	3952
query23	33838	33067	32869	32869
query24	12312	2762	2763	2762
query25	670	356	379	356
query26	1825	153	153	153
query27	3106	309	312	309
query28	7552	2049	2044	2044
query29	1175	622	592	592
query30	290	151	150	150
query31	950	752	726	726
query32	94	52	57	52
query33	753	279	269	269
query34	1041	478	468	468
query35	740	642	627	627
query36	1075	905	933	905
query37	293	71	69	69
query38	2877	2734	2736	2734
query39	853	794	785	785
query40	275	126	125	125
query41	59	53	52	52
query42	125	95	102	95
query43	580	551	553	551
query44	1257	752	741	741
query45	202	176	168	168
query46	1093	721	702	702
query47	1828	1758	1780	1758
query48	355	288	308	288
query49	1199	393	420	393
query50	780	387	395	387
query51	6825	6714	6675	6675
query52	100	93	93	93
query53	356	291	288	288
query54	978	443	431	431
query55	76	74	75	74
query56	284	290	263	263
query57	1145	1036	1068	1036
query58	261	245	238	238
query59	3496	3090	3130	3090
query60	294	274	292	274
query61	89	87	94	87
query62	653	454	423	423
query63	316	293	289	289
query64	9873	2309	1908	1908
query65	3180	3134	3111	3111
query66	1343	329	328	328
query67	15451	14851	14811	14811
query68	4515	545	538	538
query69	455	296	297	296
query70	1163	1151	1102	1102
query71	402	291	289	289
query72	7158	5402	5706	5402
query73	739	323	321	321
query74	5901	5567	5430	5430
query75	3361	2619	2664	2619
query76	2734	900	921	900
query77	439	299	293	293
query78	10206	9973	9689	9689
query79	2606	520	513	513
query80	2096	462	478	462
query81	581	226	224	224
query82	661	105	100	100
query83	272	186	169	169
query84	264	83	80	80
query85	2047	278	270	270
query86	499	319	295	295
query87	3256	3095	3070	3070
query88	4131	2348	2334	2334
query89	485	393	382	382
query90	1823	194	191	191
query91	143	100	148	100
query92	59	49	57	49
query93	2344	510	501	501
query94	1282	191	183	183
query95	407	314	307	307
query96	595	271	266	266
query97	3165	3055	2998	2998
query98	234	221	222	221
query99	1339	840	847	840
Total cold run time: 277609 ms
Total hot run time: 171092 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit f8ac28bf88644f259afeb0ade6af2b08c8189471, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.68	0.06	0.07
query5	0.50	0.48	0.48
query6	1.13	0.73	0.73
query7	0.02	0.01	0.01
query8	0.06	0.04	0.04
query9	0.55	0.48	0.49
query10	0.55	0.56	0.55
query11	0.15	0.11	0.12
query12	0.14	0.12	0.12
query13	0.59	0.59	0.61
query14	0.76	0.77	0.79
query15	0.84	0.81	0.81
query16	0.35	0.37	0.34
query17	1.02	1.04	1.04
query18	0.22	0.25	0.24
query19	1.90	1.82	1.83
query20	0.02	0.01	0.01
query21	15.60	0.64	0.64
query22	3.96	7.23	2.03
query23	18.66	1.34	1.29
query24	1.84	0.21	0.22
query25	0.15	0.08	0.08
query26	0.27	0.17	0.18
query27	0.09	0.09	0.08
query28	13.31	1.00	1.00
query29	13.19	3.30	3.30
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.30	0.47	0.46
query33	2.84	2.92	2.89
query34	17.03	4.39	4.39
query35	4.46	4.46	4.47
query36	0.65	0.46	0.46
query37	0.17	0.15	0.14
query38	0.14	0.14	0.14
query39	0.04	0.04	0.03
query40	0.16	0.15	0.14
query41	0.09	0.05	0.05
query42	0.06	0.06	0.05
query43	0.04	0.04	0.03
Total cold run time: 109.98 s
Total hot run time: 30.8 s

Copy link
Contributor

@xiaokang xiaokang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qidaye qidaye merged commit b49a83d into apache:master Jun 6, 2024
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
… v2 (#35303)

This pull request changes the default storage format for inverted
indexes to V2. The V2 format enhances efficiency by merging all index
files within a single segment into one file. This update aims to reduce
IO cost when writing inverted index files, especially for cloud mode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged not-merge/2.1 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants