Skip to content

Conversation

@Vallishp
Copy link
Contributor

Issue Number: close #xxx
improve regression check point for bug #35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty.
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@Vallishp
Copy link
Contributor Author

run buildall

@morningman morningman force-pushed the master_reggress_show branch from a94bdd0 to 57f4405 Compare June 1, 2024 15:46
@morningman
Copy link
Contributor

run buildall

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2024

PR approved by anyone and no changes requested.

@zy-kkk zy-kkk merged commit 8cae084 into apache:master Jun 2, 2024
dataroaring pushed a commit that referenced this pull request Jun 4, 2024
…atus and Show create procedure command (#35395)

improve regression check point for bug #35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty. 
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.
seawinde pushed a commit to seawinde/doris that referenced this pull request Jun 5, 2024
…atus and Show create procedure command (apache#35395)

improve regression check point for bug apache#35350

Added EmptySet checkpoint for SHOW PROCEDURE STATUS and SHOW CREATE PROCEDURE commands.

If empty set return the result in groovy check point will be empty. 
if return OK query, the result will contains [0]
added empty check for result for cases where both command return 0 rows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants