Skip to content

[fix](Nereids) fix Illegal aggregate node: group by and output is empty #35497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
May 28, 2024
Merged

[fix](Nereids) fix Illegal aggregate node: group by and output is empty #35497

morrySnow merged 1 commit into from
May 28, 2024

Conversation

@924060929
Copy link
Contributor

@924060929 924060929 commented May 28, 2024

fix Illegal aggregate node: group by and output is empty, introduced by #33091

@doris-robot
Copy link

doris-robot commented May 28, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@924060929
Copy link
Contributor Author

924060929 commented May 28, 2024

run buildall

@924060929 924060929 mentioned this pull request May 28, 2024
Merged
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

HappenLee
HappenLee approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 28, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

PR approved by anyone and no changes requested.

xiaokang pushed a commit that referenced this pull request May 28, 2024
@924060929
[fix](Nereids) fix Illegal aggregate node: group by and output is empty
2de8432 
#35497 (#35498)
@924060929
Copy link
Contributor Author

924060929 commented May 28, 2024

run buildall

@github-actions
Copy link
Contributor

github-actions bot commented May 28, 2024

clang-tidy review says "All clean, LGTM! 👍"

@doris-robot
Copy link

doris-robot commented May 28, 2024

TeamCity be ut coverage result:
Function Coverage: 35.76% (9003/25173)
Line Coverage: 27.39% (74546/272175)
Region Coverage: 26.61% (38571/144929)
Branch Coverage: 23.48% (19671/83784)
Coverage Report: http://coverage.selectdb-in.cc/coverage/43165f2ffbe4dfd60192f36fd2229c212cebafff_43165f2ffbe4dfd60192f36fd2229c212cebafff/report/index.html

@doris-robot
Copy link

doris-robot commented May 28, 2024

TPC-H: Total hot run time: 42007 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 43165f2ffbe4dfd60192f36fd2229c212cebafff, data reload: false

------ Round 1 ----------------------------------
q1	17600	4366	4274	4274
q2	2027	202	196	196
q3	10434	1243	1228	1228
q4	10196	827	827	827
q5	7513	2723	2739	2723
q6	236	130	131	130
q7	956	602	614	602
q8	9231	2112	2155	2112
q9	9495	6664	6673	6664
q10	9143	3977	3845	3845
q11	459	244	244	244
q12	460	231	224	224
q13	17224	3275	3196	3196
q14	267	226	223	223
q15	525	492	480	480
q16	506	396	398	396
q17	998	731	685	685
q18	8343	7936	7717	7717
q19	9282	1581	1487	1487
q20	855	323	308	308
q21	5232	4155	4180	4155
q22	363	291	296	291
Total cold run time: 121345 ms
Total hot run time: 42007 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4500	4388	4442	4388
q2	425	296	268	268
q3	3132	2885	2862	2862
q4	1981	1743	1632	1632
q5	5336	5537	5505	5505
q6	217	123	130	123
q7	2204	1822	1826	1822
q8	3245	3382	3401	3382
q9	8686	8638	8703	8638
q10	4054	3833	3763	3763
q11	592	489	496	489
q12	754	606	607	606
q13	16020	3177	3118	3118
q14	285	278	272	272
q15	520	475	478	475
q16	478	429	415	415
q17	1814	1527	1526	1526
q18	8150	7493	7256	7256
q19	1664	1558	1575	1558
q20	2010	1791	1779	1779
q21	7788	4790	4753	4753
q22	577	501	501	501
Total cold run time: 74432 ms
Total hot run time: 55131 ms

@doris-robot
Copy link

doris-robot commented May 28, 2024

TPC-DS: Total hot run time: 172030 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 43165f2ffbe4dfd60192f36fd2229c212cebafff, data reload: false

query1	922	379	380	379
query2	6431	2515	2231	2231
query3	6629	204	207	204
query4	19279	17377	17207	17207
query5	4134	427	436	427
query6	242	157	153	153
query7	4590	304	293	293
query8	246	195	192	192
query9	8796	2463	2448	2448
query10	454	306	280	280
query11	10527	9966	10080	9966
query12	141	96	88	88
query13	1662	382	362	362
query14	10253	7558	6273	6273
query15	236	174	169	169
query16	7980	258	271	258
query17	1716	524	513	513
query18	2073	279	278	278
query19	199	156	151	151
query20	93	87	88	87
query21	194	141	131	131
query22	4280	3948	3974	3948
query23	33985	33101	33058	33058
query24	10691	2875	2916	2875
query25	553	363	367	363
query26	702	161	158	158
query27	2209	323	329	323
query28	6032	2088	2090	2088
query29	849	641	613	613
query30	238	153	149	149
query31	977	778	742	742
query32	94	54	53	53
query33	654	274	265	265
query34	850	494	487	487
query35	733	617	602	602
query36	1048	913	923	913
query37	102	67	66	66
query38	2860	2780	2746	2746
query39	825	788	811	788
query40	197	128	129	128
query41	48	45	44	44
query42	108	100	98	98
query43	603	572	554	554
query44	1103	737	751	737
query45	186	167	161	161
query46	1064	761	734	734
query47	1867	1733	1754	1733
query48	381	317	307	307
query49	849	396	407	396
query50	793	407	404	404
query51	6911	6804	6946	6804
query52	114	94	96	94
query53	354	298	303	298
query54	860	451	451	451
query55	76	77	75	75
query56	289	266	276	266
query57	1146	1037	1066	1037
query58	246	233	221	221
query59	3417	3276	3013	3013
query60	299	262	261	261
query61	90	86	90	86
query62	605	468	447	447
query63	311	291	300	291
query64	8522	2215	1748	1748
query65	3187	3163	3137	3137
query66	774	330	332	330
query67	15213	14905	15037	14905
query68	4539	552	546	546
query69	453	273	312	273
query70	1166	1075	1162	1075
query71	373	278	271	271
query72	7600	5728	5418	5418
query73	726	329	330	329
query74	6054	5566	5721	5566
query75	3317	2668	2634	2634
query76	2338	981	999	981
query77	406	291	267	267
query78	10308	9865	9834	9834
query79	2011	522	529	522
query80	1232	461	447	447
query81	542	223	216	216
query82	663	92	95	92
query83	248	172	167	167
query84	248	85	82	82
query85	2035	266	266	266
query86	515	308	303	303
query87	3294	3108	3129	3108
query88	4400	2451	2446	2446
query89	478	394	384	384
query90	2051	185	189	185
query91	129	97	100	97
query92	65	52	58	52
query93	2434	522	506	506
query94	1302	189	190	189
query95	409	325	322	322
query96	592	269	272	269
query97	3172	3025	3046	3025
query98	253	225	218	218
query99	1171	859	853	853
Total cold run time: 268616 ms
Total hot run time: 172030 ms

@doris-robot
Copy link

doris-robot commented May 28, 2024

ClickBench: Total hot run time: 30.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 43165f2ffbe4dfd60192f36fd2229c212cebafff, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.23	0.05	0.05
query4	1.67	0.08	0.06
query5	0.49	0.47	0.50
query6	1.13	0.72	0.73
query7	0.02	0.01	0.02
query8	0.06	0.04	0.04
query9	0.53	0.51	0.49
query10	0.55	0.54	0.54
query11	0.16	0.11	0.12
query12	0.14	0.11	0.12
query13	0.59	0.59	0.61
query14	0.77	0.77	0.81
query15	0.82	0.81	0.82
query16	0.37	0.35	0.36
query17	0.94	1.02	1.00
query18	0.23	0.23	0.26
query19	1.90	1.79	1.70
query20	0.02	0.01	0.01
query21	15.44	0.69	0.68
query22	4.17	7.79	1.95
query23	18.26	1.36	1.19
query24	1.59	0.25	0.21
query25	0.14	0.08	0.08
query26	0.24	0.16	0.16
query27	0.07	0.07	0.09
query28	13.47	1.00	0.98
query29	12.84	3.35	3.31
query30	0.24	0.06	0.06
query31	2.88	0.39	0.38
query32	3.32	0.46	0.46
query33	2.89	2.92	2.89
query34	17.21	4.38	4.40
query35	4.52	4.49	4.71
query36	0.68	0.47	0.46
query37	0.17	0.15	0.15
query38	0.16	0.14	0.14
query39	0.04	0.03	0.04
query40	0.17	0.13	0.14
query41	0.09	0.05	0.04
query42	0.04	0.05	0.05
query43	0.04	0.03	0.03
Total cold run time: 109.41 s
Total hot run time: 30.45 s

@morrySnow morrySnow merged commit dc1a708 into apache:master May 28, 2024
@924060929 924060929 deleted the master-test branch May 28, 2024 12:10
yiguolei pushed a commit that referenced this pull request May 29, 2024
@924060929 @Doris-Extras
[fix](Nereids) fix Illegal aggregate node: group by and output is emp…
589518f 
…ty (#35497)

fix Illegal aggregate node: group by and output is empty.
introduced by #33091
dataroaring pushed a commit that referenced this pull request May 31, 2024
@924060929 @dataroaring
[fix](Nereids) fix Illegal aggregate node: group by and output is emp…
9b08910 
…ty (#35497)

fix Illegal aggregate node: group by and output is empty.
introduced by #33091
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@924060929
[fix](Nereids) fix Illegal aggregate node: group by and output is empty
6c8965f 
apache#35497 (apache#35498)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.0.11-merged dev/2.1.4-merged dev/3.0.0-merged p0_b reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@924060929 @doris-robot @HappenLee @morrySnow @xiaokang @dataroaring