-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](Nereids) prune not required window expressions on window operator #35504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
771dce1 to
23967e7
Compare
|
run buildall |
TPC-H: Total hot run time: 41066 ms |
TPC-DS: Total hot run time: 169634 ms |
ClickBench: Total hot run time: 30.5 s |
23967e7 to
9031fce
Compare
|
run buildall |
TPC-H: Total hot run time: 41397 ms |
TPC-DS: Total hot run time: 169745 ms |
ClickBench: Total hot run time: 30.39 s |
|
run buildall |
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/ColumnPruning.java
Outdated
Show resolved
Hide resolved
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 41077 ms |
TPC-DS: Total hot run time: 168642 ms |
ClickBench: Total hot run time: 30.43 s |
if window expression is not required by its parent, we should prune this column. If all window expressions of window operator are pruned, we remove this window operator directly.
9031fce to
fbadb21
Compare
|
run buildall |
|
does this rule apply before the rule to choose column for count()? |
TPC-H: Total hot run time: 40768 ms |
TPC-DS: Total hot run time: 167867 ms |
ClickBench: Total hot run time: 29.99 s |
|
PR approved by at least one committer and no changes requested. |
…or (#35504) if window expression is not required by its parent, we should prune this column. If all window expressions of window operator are pruned, we remove this window operator directly.
…or (apache#35577) pick from master apache#35504 if window expression is not required by its parent, we should prune this column. If all window expressions of window operator are pruned, we remove this window operator directly.
if window expression is not required by its parent, we should prune this column. If all window expressions of window operator are pruned, we remove this window operator directly.