Skip to content

Conversation

@kaka11chen
Copy link
Contributor

Proposed changes

backport #35335

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.84% (8100/21408)
Line Coverage: 29.49% (66133/224285)
Region Coverage: 28.98% (34095/117643)
Branch Coverage: 24.83% (17501/70480)
Coverage Report: http://coverage.selectdb-in.cc/coverage/64ca73ac490bd1b36c2c628fda41d3f33a1c34fe_64ca73ac490bd1b36c2c628fda41d3f33a1c34fe/report/index.html

…function in parquet and orc reader. (apache#35335)

The following sql and when the dictionary column contains functions related to null, the results will be incorrect.
```
select * from ( select IF(o_orderpriority IS NULL, 'null', o_orderpriority) AS o_orderpriority from test_string_dict_filter_orc ) as A where o_orderpriority = 'null';
```
```
select * from ( select IFNULL(o_orderpriority, 'null') AS o_orderpriority from test_string_dict_filter_parquet ) as A where o_orderpriority = 'null'
```
```
select * from ( select COALESCE(o_orderpriority, 'null') AS o_orderpriority from test_string_dict_filter_parquet ) as A where o_orderpriority = 'null';
```
@kaka11chen kaka11chen force-pushed the cherry-pick-35335-2.0 branch from 64ca73a to 84f2986 Compare May 28, 2024 10:03
@kaka11chen
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.81% (8099/21420)
Line Coverage: 29.46% (66121/224413)
Region Coverage: 28.96% (34086/117717)
Branch Coverage: 24.81% (17494/70520)
Coverage Report: http://coverage.selectdb-in.cc/coverage/84f2986621ec495776a7363af2a09313ed53ed6f_84f2986621ec495776a7363af2a09313ed53ed6f/report/index.html

@kaka11chen
Copy link
Contributor Author

run p0

@xiaokang xiaokang merged commit 69ddefe into apache:branch-2.0 May 28, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
…related functions in parquet and orc reader by disabling dictionary filtering when predicates contain functions apache#35335 (apache#35514)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants