Skip to content

[fix](multi-catalog)remove http scheme in oss endpoint #35525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
May 28, 2024
Merged

[fix](multi-catalog)remove http scheme in oss endpoint #35525

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fe/fe-core/src/main/java/org/apache/doris/datasource/property/PropertyConverter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ private static void putNewPropertiesForCompatibility(Map<String, String> props,
}

private static String getOssEndpoint(String region, boolean publicAccess) {
String prefix = "http://oss-";
String prefix = "oss-";
String suffix = ".aliyuncs.com";
if (!publicAccess) {
suffix = "-internal" + suffix;
Expand Down
4 changes: 2 additions & 2 deletions fe/fe-core/src/test/java/org/apache/doris/datasource/property/PropertyConverterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ public void testDlfPropertiesConverter() throws Exception {
Map<String, String> hdProps = catalog.getCatalogProperty().getHadoopProperties();
Assertions.assertEquals("akk", hdProps.get(OssProperties.ACCESS_KEY));
Assertions.assertEquals("skk", hdProps.get(OssProperties.SECRET_KEY));
Assertions.assertEquals("http://oss-cn-beijing-internal.aliyuncs.com",
Assertions.assertEquals("oss-cn-beijing-internal.aliyuncs.com",
hdProps.get(OssProperties.ENDPOINT));

String queryDlf2 = "create catalog hms_dlf2 properties (\n"
Expand Down Expand Up @@ -392,7 +392,7 @@ public void testDlfPropertiesConverter() throws Exception {
Map<String, String> hdProps3 = catalog3.getCatalogProperty().getHadoopProperties();
Assertions.assertEquals("akk", hdProps3.get(OssProperties.ACCESS_KEY));
Assertions.assertEquals("skk", hdProps3.get(OssProperties.SECRET_KEY));
Assertions.assertEquals("http://oss-cn-beijing-internal.aliyuncs.com", hdProps3.get(OssProperties.ENDPOINT));
Assertions.assertEquals("oss-cn-beijing-internal.aliyuncs.com", hdProps3.get(OssProperties.ENDPOINT));
}

@Test
Expand Down