[fix](segment cache) estimate momory consumed by segment #35647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory consumed in segment cache is 0 after https://github.com/apache/doris/pull/35432/files. The pr also tracks memory usage of column readers.
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| } | ||
| return OrdinalPageIndexIterator(this, left); | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
OrdinalIndexReader::~OrdinalIndexReader() {
^
| return OrdinalPageIndexIterator(this, left); | ||
| } | ||
|
|
||
| OrdinalIndexReader::~OrdinalIndexReader() { |
Contributor
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
OrdinalIndexReader::~OrdinalIndexReader() {
^
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
Contributor
Author
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41238 ms |
TPC-DS: Total hot run time: 172408 ms |
ClickBench: Total hot run time: 30.81 s |
yiguolei
approved these changes
May 31, 2024
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
Contributor
Author
|
run performance |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 41139 ms |
TPC-DS: Total hot run time: 172316 ms |
ClickBench: Total hot run time: 30.75 s |
Lchangliang
approved these changes
May 31, 2024
Contributor
|
LGTM |
xinyiZzz
reviewed
May 31, 2024
|
|
||
| namespace doris { | ||
|
|
||
| static bvar::Adder<size_t> g_total_rowset_num("doris_total_rowset_num"); |
Contributor
There was a problem hiding this comment.
BE metrics have a counter all_rowsets_num, is it same as bvar::doris_total_rowset_num?
update_rowsets_and_segments_num_metrics
xinyiZzz
reviewed
May 31, 2024
|
|
||
| namespace doris::segment_v2 { | ||
| bvar::Adder<size_t> g_total_segment_num("doris_total_segment_num"); | ||
| static bvar::Adder<size_t> g_total_segment_num("doris_total_segment_num"); |
Contributor
There was a problem hiding this comment.
BE metrics have a counter all_segments_num, value is it same as bvar::doris_total_segment_num?
Contributor
|
run buildall |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 40730 ms |
TPC-DS: Total hot run time: 169670 ms |
ClickBench: Total hot run time: 30.41 s |
gavinchou
approved these changes
May 31, 2024
dataroaring
added a commit
that referenced
this pull request
May 31, 2024
The memory consumed in segment cache is 0 after https://github.com/apache/doris/pull/35432/files. The pr also tracks memory usage of column readers.
dataroaring
added a commit
to dataroaring/incubator-doris
that referenced
this pull request
Jun 1, 2024
The memory consumed in segment cache is 0 after https://github.com/apache/doris/pull/35432/files. The pr also tracks memory usage of column readers.
dataroaring
added a commit
that referenced
this pull request
Jun 1, 2024
…5751) The memory consumed in segment cache is 0 after https://github.com/apache/doris/pull/35432/files. The pr also tracks memory usage of column readers.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
The memory consumed in segment cache is 0 after https://github.com/apache/doris/pull/35432/files. The pr also tracks memory usage of column readers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory consumed in segment cache is 0 after
https://github.com/apache/doris/pull/35432/files.
The pr also tracks memory usage of column readers.
Proposed changes
Issue Number: close #xxx