[fix](rpc) fix transfer large data and enable transfer_large_data_by_brpc by default #35770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
|
TeamCity be ut coverage result: |
Contributor
|
run performance |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
yiguolei
approved these changes
Jun 3, 2024
Contributor
|
run performance |
TPC-H: Total hot run time: 42062 ms |
TPC-DS: Total hot run time: 170839 ms |
ClickBench: Total hot run time: 30.61 s |
dataroaring
pushed a commit
that referenced
this pull request
Jun 4, 2024
…brpc by default (#35770) ## Proposed changes Issue Number: close #xxx when send large data by rpc，load will report the following error: ``` add batch req success but status isn't ok, err: [INTERNAL_ERROR]PStatus: (172.200.0.1)[INTERNAL_ERROR]fail to add batch in load channel. unknown load_id=0000000000000000-0000000000000000. ``` The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use the brpc HTTP method. However, the block data was not removed during encoding, resulting in protobuf exceeding the length and encoding failure. The config of transfer_large_data_by_brpc was enabled by default on branch-2.0, so we also enable it on master.
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…brpc by default (apache#35770) ## Proposed changes Issue Number: close #xxx when send large data by rpc，load will report the following error: ``` add batch req success but status isn't ok, err: [INTERNAL_ERROR]PStatus: (172.200.0.1)[INTERNAL_ERROR]fail to add batch in load channel. unknown load_id=0000000000000000-0000000000000000. ``` The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use the brpc HTTP method. However, the block data was not removed during encoding, resulting in protobuf exceeding the length and encoding failure. The config of transfer_large_data_by_brpc was enabled by default on branch-2.0, so we also enable it on master.
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jun 12, 2024
…brpc by default (apache#35770) Issue Number: close #xxx when send large data by rpc，load will report the following error: ``` add batch req success but status isn't ok, err: [INTERNAL_ERROR]PStatus: (172.200.0.1)[INTERNAL_ERROR]fail to add batch in load channel. unknown load_id=0000000000000000-0000000000000000. ``` The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use the brpc HTTP method. However, the block data was not removed during encoding, resulting in protobuf exceeding the length and encoding failure. The config of transfer_large_data_by_brpc was enabled by default on branch-2.0, so we also enable it on master.
liaoxin01
added a commit
to liaoxin01/doris
that referenced
this pull request
Jun 12, 2024
…brpc by default (apache#35770) ## Proposed changes Issue Number: close #xxx when send large data by rpc，load will report the following error: ``` add batch req success but status isn't ok, err: [INTERNAL_ERROR]PStatus: (172.200.0.1)[INTERNAL_ERROR]fail to add batch in load channel. unknown load_id=0000000000000000-0000000000000000. ``` The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use the brpc HTTP method. However, the block data was not removed during encoding, resulting in protobuf exceeding the length and encoding failure. The config of transfer_large_data_by_brpc was enabled by default on branch-2.0, so we also enable it on master.
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…brpc by default apache#35770 (apache#36167) cherry pick from apache#35770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
when send large data by rpc，load will report the following error:
The maximum length of protobuf is 2GB. When it exceeds 2GB, we will use the brpc HTTP method. However, the block data was not removed during encoding, resulting in protobuf exceeding the length and encoding failure.
The config of transfer_large_data_by_brpc was enabled by default on branch-2.0, so we also enable it on master.