Skip to content

[fix](arrow-flight-sql) Fix pipelineX Unknown result sink type #35804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xinyiZzz merged 3 commits into from
Jun 5, 2024
Merged

[fix](arrow-flight-sql) Fix pipelineX Unknown result sink type #35804

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
26a26b3
1
xinyiZzz Jun 3, 2024
1193ae2
[fix](arrow-flight-sql) Fix pipelineX Unknown result sink type
xinyiZzz Jun 3, 2024
54a9b80
Merge branch 'master' into 20240603_fix_arrow_flight_unknow_type
xinyiZzz Jun 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion be/src/pipeline/exec/result_sink_operator.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@
#include "runtime/buffer_control_block.h"
#include "runtime/exec_env.h"
#include "runtime/result_buffer_mgr.h"
#include "util/arrow/row_batch.h"
#include "vec/exprs/vexpr.h"
#include "vec/exprs/vexpr_context.h"
#include "vec/sink/varrow_flight_result_writer.h"
#include "vec/sink/vmysql_result_writer.h"

namespace doris::pipeline {
Expand Down Expand Up @@ -61,7 +63,7 @@ Status ResultSinkLocalState::open(RuntimeState* state) {
}
// create writer based on sink type
switch (p._sink_type) {
case TResultSinkType::MYSQL_PROTOCAL:
case TResultSinkType::MYSQL_PROTOCAL: {
if (state->mysql_row_binary_format()) {
_writer.reset(new (std::nothrow) vectorized::VMysqlResultWriter<true>(
_sender.get(), _output_vexpr_ctxs, _profile));
Expand All @@ -70,6 +72,16 @@ Status ResultSinkLocalState::open(RuntimeState* state) {
_sender.get(), _output_vexpr_ctxs, _profile));
}
break;
}
case TResultSinkType::ARROW_FLIGHT_PROTOCAL: {
std::shared_ptr<arrow::Schema> arrow_schema;
RETURN_IF_ERROR(convert_expr_ctxs_arrow_schema(_output_vexpr_ctxs, &arrow_schema));
state->exec_env()->result_mgr()->register_arrow_schema(state->fragment_instance_id(),
arrow_schema);
_writer.reset(new (std::nothrow) vectorized::VArrowFlightResultWriter(
_sender.get(), _output_vexpr_ctxs, _profile, arrow_schema));
break;
}
default:
return Status::InternalError("Unknown result sink type");
}
Expand Down