-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](nereids)eliminate repeat node if there is only 1 grouping set and no grouping scalar function #35813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng set and no grouping scalar function
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40064 ms |
TPC-DS: Total hot run time: 170615 ms |
ClickBench: Total hot run time: 30.74 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40120 ms |
TPC-DS: Total hot run time: 170243 ms |
ClickBench: Total hot run time: 31.76 s |
morrySnow
reviewed
Jun 4, 2024
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/NormalizeRepeat.java
Outdated
Show resolved
Hide resolved
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/analysis/NormalizeRepeat.java
Outdated
Show resolved
Hide resolved
regression-test/suites/nereids_rules_p0/grouping_sets/grouping_normalize_test.groovy
Show resolved
Hide resolved
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41477 ms |
TPC-DS: Total hot run time: 173974 ms |
ClickBench: Total hot run time: 30.75 s |
morrySnow
approved these changes
Jun 4, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
feiniaofeiafei
approved these changes
Jun 4, 2024
seawinde
pushed a commit
to seawinde/doris
that referenced
this pull request
Jun 5, 2024
…as possible (apache#35813) if grouping sets only have one set and no group scalar function in project list, transform it to trivial aggregation for example, transform SELECT k1, k2, SUM(k3) FROM d_table GROUP BY GROUPING SETS ((k1, k2)); to SELECT k1, k2, SUM(k3) FROM d_table GROUP BY (k1, k2);
dataroaring
pushed a commit
that referenced
this pull request
Jun 7, 2024
…as possible (#35813) if grouping sets only have one set and no group scalar function in project list, transform it to trivial aggregation for example, transform SELECT k1, k2, SUM(k3) FROM d_table GROUP BY GROUPING SETS ((k1, k2)); to SELECT k1, k2, SUM(k3) FROM d_table GROUP BY (k1, k2);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.4-merged
dev/3.0.0-merged
reviewed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
convert
SELECT k1, k2, SUM(k3) FROM d_table GROUP BY GROUPING SETS ((k1, k2));to
SELECT k1, k2, SUM(k3) FROM d_table GROUP BY (k1, k2);