Skip to content

[bugfix](hive)fix the error message when creating hive table #35833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jun 6, 2024
Merged

[bugfix](hive)fix the error message when creating hive table #35833

morningman merged 1 commit into from
Jun 6, 2024

Conversation

@wuwenchi
Copy link
Contributor

@wuwenchi wuwenchi commented Jun 4, 2024 •
edited
Loading

Proposed changes

create table tb (id int, pt1 string, pt2 string, pt3 string) partition by list (pt1,pt2)();

error message before：
The order of partition fields in the schema must be consistent with the order defined in PARTITIONED BY LIST()
error message after:
The partition field must be at the end of the schema

@doris-robot
Copy link

doris-robot commented Jun 4, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@wuwenchi
Copy link
Contributor Author

wuwenchi commented Jun 4, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 4, 2024

TPC-H: Total hot run time: 41752 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 560e5f40892340c7d0a724f6d16fc25af05ff661, data reload: false

------ Round 1 ----------------------------------
q1	17602	4362	4322	4322
q2	2036	203	189	189
q3	10444	1279	1168	1168
q4	10191	817	754	754
q5	7499	2756	2719	2719
q6	218	137	137	137
q7	995	624	592	592
q8	9220	2171	2124	2124
q9	9400	6697	6802	6697
q10	9216	3910	3898	3898
q11	455	255	241	241
q12	520	229	230	229
q13	17235	3208	3250	3208
q14	286	240	227	227
q15	513	479	469	469
q16	470	382	393	382
q17	990	670	629	629
q18	8421	7891	7767	7767
q19	6344	1267	1355	1267
q20	664	319	319	319
q21	5208	4073	4171	4073
q22	421	341	356	341
Total cold run time: 118348 ms
Total hot run time: 41752 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4649	4399	4448	4399
q2	379	279	265	265
q3	3188	2984	3046	2984
q4	1934	1615	1607	1607
q5	5408	5554	5534	5534
q6	219	127	128	127
q7	2181	1915	1852	1852
q8	3236	3401	3405	3401
q9	8699	8591	8766	8591
q10	4090	3981	3765	3765
q11	608	508	504	504
q12	771	649	613	613
q13	17141	3127	3168	3127
q14	328	285	271	271
q15	528	483	483	483
q16	490	448	452	448
q17	1852	1514	1482	1482
q18	8177	7531	7303	7303
q19	1740	1670	1474	1474
q20	3017	1815	1792	1792
q21	5332	4623	4662	4623
q22	705	539	557	539
Total cold run time: 74672 ms
Total hot run time: 55184 ms

@doris-robot
Copy link

doris-robot commented Jun 4, 2024

TPC-DS: Total hot run time: 173272 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 560e5f40892340c7d0a724f6d16fc25af05ff661, data reload: false

query1	935	385	375	375
query2	6446	2534	2407	2407
query3	6642	202	202	202
query4	19375	17484	17258	17258
query5	4119	448	445	445
query6	249	156	168	156
query7	4596	299	289	289
query8	354	293	300	293
query9	8422	2381	2369	2369
query10	424	297	269	269
query11	10437	10032	10125	10032
query12	137	88	86	86
query13	1627	357	356	356
query14	10134	7667	7565	7565
query15	234	195	187	187
query16	7809	271	264	264
query17	1482	521	526	521
query18	1921	279	276	276
query19	206	167	159	159
query20	99	90	89	89
query21	212	146	128	128
query22	4413	4103	4067	4067
query23	33699	33191	33499	33191
query24	11058	2788	2792	2788
query25	677	366	359	359
query26	1392	152	151	151
query27	2990	311	307	307
query28	7589	2070	2075	2070
query29	941	622	592	592
query30	289	147	158	147
query31	978	747	705	705
query32	93	52	52	52
query33	761	283	279	279
query34	961	468	468	468
query35	765	634	650	634
query36	1116	937	941	937
query37	158	65	70	65
query38	2907	2729	2724	2724
query39	870	803	791	791
query40	213	127	123	123
query41	54	51	54	51
query42	121	94	97	94
query43	582	561	540	540
query44	1255	723	739	723
query45	195	164	164	164
query46	1082	705	726	705
query47	1850	1787	1796	1787
query48	369	291	301	291
query49	1005	395	409	395
query50	777	393	378	378
query51	6864	6773	6731	6731
query52	106	84	93	84
query53	358	284	282	282
query54	875	442	460	442
query55	74	70	76	70
query56	279	251	266	251
query57	1147	1073	1038	1038
query58	259	264	262	262
query59	3473	3128	3243	3128
query60	304	262	263	262
query61	91	86	89	86
query62	620	442	450	442
query63	324	288	287	287
query64	8993	2208	1728	1728
query65	3199	3105	3144	3105
query66	1035	336	329	329
query67	15540	14971	14864	14864
query68	4503	535	513	513
query69	585	409	344	344
query70	1132	1121	1147	1121
query71	415	279	285	279
query72	7234	5530	5378	5378
query73	769	323	316	316
query74	5864	5528	5458	5458
query75	3362	2652	2686	2652
query76	2344	895	890	890
query77	470	284	288	284
query78	10191	9988	9802	9802
query79	2142	498	503	498
query80	1002	470	450	450
query81	589	234	224	224
query82	770	101	99	99
query83	235	170	167	167
query84	253	89	84	84
query85	1976	289	309	289
query86	488	305	333	305
query87	3286	3109	3123	3109
query88	3872	2336	2316	2316
query89	475	383	384	383
query90	1852	182	188	182
query91	125	97	97	97
query92	63	49	48	48
query93	2538	517	498	498
query94	1236	188	187	187
query95	407	316	315	315
query96	600	263	259	259
query97	3200	2989	3046	2989
query98	255	233	216	216
query99	1140	836	825	825
Total cold run time: 271934 ms
Total hot run time: 173272 ms

@doris-robot
Copy link

doris-robot commented Jun 4, 2024

ClickBench: Total hot run time: 31.76 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 560e5f40892340c7d0a724f6d16fc25af05ff661, data reload: false

query1	0.04	0.03	0.03
query2	0.08	0.04	0.04
query3	0.23	0.06	0.05
query4	1.64	0.07	0.07
query5	0.50	0.48	0.50
query6	1.12	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.04	0.04
query9	0.56	0.47	0.48
query10	0.55	0.55	0.55
query11	0.16	0.12	0.12
query12	0.14	0.12	0.12
query13	0.60	0.59	0.59
query14	0.75	0.79	0.76
query15	0.84	0.82	0.81
query16	0.35	0.37	0.38
query17	0.97	0.98	0.98
query18	0.24	0.24	0.22
query19	1.82	1.75	1.72
query20	0.02	0.01	0.01
query21	15.75	0.67	0.65
query22	4.08	6.16	3.01
query23	18.26	1.39	1.36
query24	1.85	0.30	0.20
query25	0.14	0.08	0.08
query26	0.27	0.18	0.17
query27	0.08	0.07	0.09
query28	13.28	1.03	1.00
query29	13.38	3.36	3.33
query30	0.24	0.06	0.05
query31	2.86	0.38	0.39
query32	3.27	0.48	0.47
query33	2.87	2.87	2.88
query34	17.19	4.34	4.41
query35	4.53	4.54	4.59
query36	0.70	0.48	0.48
query37	0.18	0.16	0.16
query38	0.16	0.15	0.15
query39	0.05	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.04	0.05
query42	0.05	0.05	0.04
query43	0.05	0.04	0.03
Total cold run time: 110.18 s
Total hot run time: 31.76 s

morningman
morningman approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

PR approved by anyone and no changes requested.

kaka11chen
kaka11chen approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@kaka11chen kaka11chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit a41940e into apache:master Jun 6, 2024
@wuwenchi wuwenchi mentioned this pull request Jun 6, 2024
Merged
morningman pushed a commit that referenced this pull request Jun 6, 2024
@wuwenchi
[bugfix](hive)fix the error message when creating hive table for 2.1 (#…
726377a 
…35975)

bp #35833
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
@wuwenchi @dataroaring
[bugfix](hive)fix the error message when creating hive table (#35833)
1b4b294 
```
create table tb (id int, pt1 string, pt2 string, pt3 string) partition by list (pt1,pt2)();
```
error message before：
     `The order of partition fields in the schema must be consistent with the order defined in PARTITIONED BY LIST()` 
error message after: 
     `The partition field must be at the end of the schema`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaka11chen kaka11chen kaka11chen approved these changes

@morningman morningman morningman approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wuwenchi @doris-robot @kaka11chen @morningman @dataroaring