-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Chore](type) remove duplicate uint128/int128/uint256 defines #35841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
run buildall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
run buildall |
|
run buildall |
|
run buildall |
HappenLee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
## Proposed changes remove duplicate uint128/int128 defines
apache#46928) ### What problem does this PR solve? fix wrtong HashLen16 implement and add cityhash64 unit test HashLen16 was incorrectly modified in apache#35841, which would cause ngram indexes built in 2.0/2.1 to get incorrect results in 3.0
Proposed changes
remove duplicate uint128/int128 defines