Skip to content

Conversation

@BiteTheDDDDt
Copy link
Contributor

Proposed changes

remove duplicate uint128/int128 defines

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@BiteTheDDDDt BiteTheDDDDt changed the title [Chore](type) remove duplicate uint128/int128 defines [Chore](type) remove duplicate uint128/int128/uint256 defines Jun 4, 2024
@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

run buildall

Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 6, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit 3bd6c2b into apache:master Jun 6, 2024
dataroaring pushed a commit that referenced this pull request Jun 7, 2024
## Proposed changes
remove duplicate uint128/int128 defines
BiteTheDDDDt added a commit that referenced this pull request Jan 14, 2025
#46928)

### What problem does this PR solve?
fix wrtong HashLen16 implement and add cityhash64 unit test

HashLen16 was incorrectly modified in #35841, which would cause ngram
indexes built in 2.0/2.1 to get incorrect results in 3.0
github-actions bot pushed a commit that referenced this pull request Jan 14, 2025
#46928)

### What problem does this PR solve?
fix wrtong HashLen16 implement and add cityhash64 unit test

HashLen16 was incorrectly modified in #35841, which would cause ngram
indexes built in 2.0/2.1 to get incorrect results in 3.0
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
apache#46928)

### What problem does this PR solve?
fix wrtong HashLen16 implement and add cityhash64 unit test

HashLen16 was incorrectly modified in apache#35841, which would cause ngram
indexes built in 2.0/2.1 to get incorrect results in 3.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants