[fix](nereids)should not push down constant output expr in window expression #35948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 41012 ms |
TPC-DS: Total hot run time: 170212 ms |
ClickBench: Total hot run time: 30.69 s |
This was referenced Jun 6, 2024
morrySnow
approved these changes
Jun 6, 2024
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
morrySnow
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ression (#35964) pick from master #35948 SELECT 0 AS x1, (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE 0 END) AS x2 FROM t 0 AS x1 was pushed down to bottom project. Then it will be used to normalize case when expr, and change it to (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE x1 END) AS x2 the literal 0 was replaced by x1 accidentally. This pr fix it by keep constant expr in output list
morrySnow
pushed a commit
that referenced
this pull request
Jun 6, 2024
…ression (#35961) pick from master #35948 SELECT 0 AS x1, (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE 0 END) AS x2 FROM t 0 AS x1 was pushed down to bottom project. Then it will be used to normalize case when expr, and change it to (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE x1 END) AS x2 the literal 0 was replaced by x1 accidentally. This pr fix it by keep constant expr in output list
924060929
approved these changes
Jun 6, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 7, 2024
…ression (#35948) SELECT 0 AS x1, (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE 0 END) AS x2 FROM t 0 AS x1 was pushed down to bottom project. Then it will be used to normalize case when expr, and change it to (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE **x1** END) AS x2 the literal 0 was replaced by x1 accidentally. This pr fix it by keep constant expr in output list
morrySnow
pushed a commit
that referenced
this pull request
Jun 11, 2024
…datatype too (#36055) this pr revert #35948 and fix the bug in correct way. The root cause is decimal literal's comparison only compare value, we should also compare their datatype as well as datetime literal. suppose a=0 with type decimal(2,1) b=0 with type decimal(3,1) we have: a.equals(b) returns false
dataroaring
pushed a commit
that referenced
this pull request
Jun 13, 2024
…datatype too (#36055) this pr revert #35948 and fix the bug in correct way. The root cause is decimal literal's comparison only compare value, we should also compare their datatype as well as datetime literal. suppose a=0 with type decimal(2,1) b=0 with type decimal(3,1) we have: a.equals(b) returns false
mongo360
pushed a commit
to mongo360/doris
that referenced
this pull request
Aug 16, 2024
…ression (apache#35961) pick from master apache#35948 SELECT 0 AS x1, (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE 0 END) AS x2 FROM t 0 AS x1 was pushed down to bottom project. Then it will be used to normalize case when expr, and change it to (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE x1 END) AS x2 the literal 0 was replaced by x1 accidentally. This pr fix it by keep constant expr in output list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SELECT 0 AS x1, (CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE 0 END) AS x2 FROM t0 AS x1 was pushed down to bottom project. Then it will be used to normalize case when expr, and change it to
(CASE WHEN t.a IS NOT NULL THEN 1.0 / count(1) OVER (PARTITION BY t.b) ELSE x1 END) AS x2
the literal 0 was replaced by x1 accidentally. This pr fix it by keep constant expr in output list
Issue Number: close #xxx