Skip to content

[bugfix](hive)fix the error message when creating hive table for 2.1 #35975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
morningman merged 1 commit into from
Jun 6, 2024
Merged

[bugfix](hive)fix the error message when creating hive table for 2.1 #35975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions fe/fe-core/src/main/java/org/apache/doris/nereids/parser/PartitionTableInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,10 +204,10 @@ public void validatePartitionInfo(
}
List<ColumnDefinition> partitionInSchema = columns.subList(
columns.size() - partitionColumns.size(), columns.size());
if (partitionInSchema.stream().anyMatch(p -> !partitionColumns.contains(p.getName()))) {
throw new AnalysisException("The partition field must be at the end of the schema.");
}
for (int i = 0; i < partitionInSchema.size(); i++) {
if (!partitionColumns.contains(partitionInSchema.get(i).getName())) {
throw new AnalysisException("The partition field must be at the end of the schema.");
}
if (!partitionInSchema.get(i).getName().equals(partitionColumns.get(i))) {
throw new AnalysisException("The order of partition fields in the schema "
+ "must be consistent with the order defined in `PARTITIONED BY LIST()`");
Expand Down
14 changes: 14 additions & 0 deletions fe/fe-core/src/test/java/org/apache/doris/nereids/trees/plans/CreateTableCommandTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,5 +884,19 @@ public void testPartitionCheckForHive() {
} catch (Exception e) {
Assertions.assertEquals("partition key par1 is not exists", e.getMessage());
}

try {
getCreateTableStmt("CREATE TABLE `tb11`(\n"
+ " `c1` bigint,\n"
+ " `par1` int,\n"
+ " `par2` int,\n"
+ " `par3` int\n"
+ ") ENGINE = hive PARTITION BY LIST (\n"
+ " par1, par2\n"
+ ")();");
Assertions.assertTrue(false);
} catch (Exception e) {
Assertions.assertEquals("The partition field must be at the end of the schema.", e.getMessage());
}
}
}