Skip to content

[fix](nereids)decimal and datetime literal comparison should compare datatype too #36065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jun 11, 2024
Merged

[fix](nereids)decimal and datetime literal comparison should compare datatype too #36065

morrySnow merged 1 commit into from
Jun 11, 2024

Conversation

@starocean999
Copy link
Contributor

@starocean999 starocean999 commented Jun 7, 2024

pick from master #36055

Proposed changes

Issue Number: close #xxx

@doris-robot
Copy link

doris-robot commented Jun 7, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@starocean999
Copy link
Contributor Author

starocean999 commented Jun 7, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 7, 2024

TPC-H: Total hot run time: 49533 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5781df31ebc8ae49a02674588e17742449016a7a, data reload: false

------ Round 1 ----------------------------------
q1	17547	4361	4334	4334
q2	2089	168	148	148
q3	10386	1933	1992	1933
q4	10372	1222	1308	1222
q5	8394	3850	3899	3850
q6	243	124	127	124
q7	2040	1600	1578	1578
q8	9520	2712	2675	2675
q9	13837	11167	10225	10225
q10	8599	3489	3519	3489
q11	414	238	245	238
q12	471	306	304	304
q13	18334	3964	4046	3964
q14	360	326	339	326
q15	516	473	474	473
q16	670	588	578	578
q17	1123	901	927	901
q18	7199	6828	6851	6828
q19	1693	1551	1535	1535
q20	533	304	327	304
q21	4363	4196	4117	4117
q22	503	387	395	387
Total cold run time: 119206 ms
Total hot run time: 49533 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4289	4270	4294	4270
q2	320	222	226	222
q3	4190	4129	4144	4129
q4	2767	2742	2754	2742
q5	7172	7041	7033	7033
q6	242	122	123	122
q7	3251	2898	2841	2841
q8	4330	4425	4488	4425
q9	16819	16651	16648	16648
q10	4191	4263	4268	4263
q11	768	699	691	691
q12	1043	853	846	846
q13	5796	3751	3712	3712
q14	460	427	440	427
q15	511	462	461	461
q16	729	704	688	688
q17	3791	3896	3772	3772
q18	8847	8790	8825	8790
q19	1751	1703	1647	1647
q20	2346	2164	2140	2140
q21	8732	8430	8532	8430
q22	1024	908	944	908
Total cold run time: 83369 ms
Total hot run time: 79207 ms

@doris-robot
Copy link

doris-robot commented Jun 7, 2024

TPC-DS: Total hot run time: 203707 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5781df31ebc8ae49a02674588e17742449016a7a, data reload: false

query1	936	417	388	388
query2	6528	2809	2727	2727
query3	6916	214	207	207
query4	20684	17970	18029	17970
query5	19751	6555	6587	6555
query6	288	219	237	219
query7	4154	300	313	300
query8	262	276	251	251
query9	3162	2730	2654	2654
query10	429	310	322	310
query11	11307	10675	10690	10675
query12	125	83	76	76
query13	5598	694	698	694
query14	17701	13518	13232	13232
query15	363	220	224	220
query16	6464	293	284	284
query17	1717	1449	885	885
query18	2305	424	418	418
query19	210	158	153	153
query20	84	78	80	78
query21	195	98	92	92
query22	5226	4962	4994	4962
query23	32548	32027	31849	31849
query24	6908	6554	6508	6508
query25	522	435	431	431
query26	526	167	161	161
query27	1867	302	301	301
query28	6091	2357	2319	2319
query29	2859	2937	2835	2835
query30	238	169	173	169
query31	913	752	753	752
query32	69	70	61	61
query33	405	260	261	260
query34	856	472	473	472
query35	1107	967	896	896
query36	1260	1151	1156	1151
query37	92	60	61	60
query38	3068	2947	2895	2895
query39	1377	1340	1333	1333
query40	201	98	97	97
query41	39	39	37	37
query42	82	81	85	81
query43	882	757	802	757
query44	1127	716	717	716
query45	244	235	227	227
query46	1221	971	976	971
query47	1842	1877	1744	1744
query48	1005	738	712	712
query49	623	363	359	359
query50	877	612	622	612
query51	4768	4624	4656	4624
query52	105	84	96	84
query53	442	326	334	326
query54	2651	2461	2428	2428
query55	95	80	85	80
query56	226	231	210	210
query57	1226	1084	1237	1084
query58	227	197	201	197
query59	4260	4040	4175	4040
query60	219	205	217	205
query61	98	96	98	96
query62	747	476	478	476
query63	484	343	343	343
query64	2608	1560	1532	1532
query65	3602	3525	3539	3525
query66	794	378	392	378
query67	18037	15390	14816	14816
query68	10033	659	662	659
query69	564	356	371	356
query70	1837	1576	1521	1521
query71	408	305	319	305
query72	6503	3493	3483	3483
query73	742	327	324	324
query74	6307	5842	5927	5842
query75	5375	3670	3586	3586
query76	6388	1140	1197	1140
query77	1064	268	271	268
query78	12325	11913	12065	11913
query79	9559	646	646	646
query80	1128	405	403	403
query81	491	234	235	234
query82	1588	101	95	95
query83	174	133	133	133
query84	262	70	70	70
query85	887	323	321	321
query86	320	304	300	300
query87	3212	3009	3030	3009
query88	4770	2348	2342	2342
query89	481	302	286	286
query90	1891	208	222	208
query91	191	137	154	137
query92	63	55	54	54
query93	6978	562	610	562
query94	662	220	206	206
query95	1117	1077	1064	1064
query96	657	338	335	335
query97	6436	6385	6323	6323
query98	203	174	170	170
query99	3135	887	852	852
Total cold run time: 319594 ms
Total hot run time: 203707 ms

@doris-robot
Copy link

doris-robot commented Jun 7, 2024

ClickBench: Total hot run time: 31.12 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5781df31ebc8ae49a02674588e17742449016a7a, data reload: false

query1	0.02	0.02	0.02
query2	0.07	0.02	0.02
query3	0.25	0.04	0.05
query4	1.78	0.11	0.09
query5	0.55	0.52	0.52
query6	1.24	0.61	0.63
query7	0.01	0.02	0.01
query8	0.03	0.02	0.03
query9	0.54	0.50	0.48
query10	0.55	0.54	0.53
query11	0.12	0.09	0.09
query12	0.12	0.10	0.09
query13	0.62	0.62	0.60
query14	0.78	0.78	0.78
query15	0.78	0.78	0.76
query16	0.36	0.36	0.36
query17	1.00	1.03	1.01
query18	0.23	0.24	0.25
query19	1.91	1.85	1.85
query20	0.01	0.01	0.01
query21	15.48	0.57	0.56
query22	2.14	2.75	1.45
query23	17.28	1.04	0.94
query24	4.15	1.39	1.51
query25	0.29	0.14	0.04
query26	0.57	0.17	0.17
query27	0.05	0.04	0.04
query28	9.02	0.77	0.70
query29	12.70	2.36	2.39
query30	0.56	0.62	0.54
query31	2.81	0.39	0.37
query32	3.40	0.51	0.49
query33	3.07	3.09	3.11
query34	15.24	4.78	4.80
query35	4.86	4.82	4.86
query36	1.05	1.02	1.01
query37	0.06	0.05	0.04
query38	0.04	0.02	0.02
query39	0.02	0.01	0.02
query40	0.16	0.14	0.14
query41	0.07	0.02	0.01
query42	0.02	0.01	0.02
query43	0.02	0.01	0.02
Total cold run time: 104.03 s
Total hot run time: 31.12 s

@doris-robot
Copy link

doris-robot commented Jun 7, 2024

Load test result on machine: 'aliyun_ecs.c7a.8xlarge_32C64G'

Load test result on commit 5781df31ebc8ae49a02674588e17742449016a7a with default session variables
Stream load json:         20 seconds loaded 2358488459 Bytes, about 112 MB/s
Stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
Stream load parquet:      31 seconds loaded 861443392 Bytes, about 26 MB/s
Insert into select:       21.1 seconds inserted 10000000 Rows, about 473K ops/s

@morrySnow morrySnow merged commit 1bc27dd into apache:branch-2.0 Jun 11, 2024
mongo360 pushed a commit to mongo360/doris that referenced this pull request Aug 16, 2024
@starocean999
[fix](nereids)decimal and datetime literal comparison should compare …
123cc04 
…datatype too (apache#36065)

pick from master apache#36055

this pr revert apache#35961 and fix the bug in correct way.

The root cause is decimal literal's comparison only compare value, we should also compare their datatype as well as datetime literal.

suppose
a=0 with type decimal(2,1)
b=0 with type decimal(3,1)
we have:
a.equals(b) returns false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area/nereids

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@starocean999 @doris-robot @morrySnow