-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](InternalSchema) Compute nodes should not be used for Internal schema three replica #36130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
fe/fe-core/src/main/java/org/apache/doris/system/SystemInfoService.java
Outdated
Show resolved
Hide resolved
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
|
please replace screenshot with text |
Jibing-Li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
TPC-H: Total hot run time: 40050 ms |
TPC-DS: Total hot run time: 172180 ms |
ClickBench: Total hot run time: 30.34 s |
…chema three replica
…vice.java Co-authored-by: camby <104178625@qq.com>
|
run buildall |
TPC-H: Total hot run time: 40188 ms |
TPC-DS: Total hot run time: 173627 ms |
ClickBench: Total hot run time: 30.68 s |
…chema three replica (apache#36130) ## Proposed changes Issue Number: close #xxx When I add computing nodes to the cluster, a large number of warning logs will appear in the FE log, as shown below: ``` 2024-06-11 17:50:04,360 WARN (InternalSchemaInitializer|137) [InternalSchemaInitializer.modifyTblReplicaCount():146] Failed to scale replica of stats tbl:column_statistics to 3 org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = errCode = 2, detailMessage = Failed to find enough backend, please check the replication num,replication tag and storage medium and avail capacity of backends. Create failed replications: replication tag: {"location" : "default"}, replication num: 3, storage medium: null at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocationImpl(PropertyAnalyzer.java:1217) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocation(PropertyAnalyzer.java:1136) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.modifyTableReplicaAllocation(Env.java:4868) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.modifyTblReplicaCount(InternalSchemaInitializer.java:123) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.run(InternalSchemaInitializer.java:93) ~[doris-fe.jar:1.2-SNAPSHOT] ```  This is because the computing node is also considered a replica in the code, and the computing node does not have storage resources, resulting in an error message. --------- Co-authored-by: camby <104178625@qq.com>
…chema three replica (apache#36130) ## Proposed changes Issue Number: close #xxx When I add computing nodes to the cluster, a large number of warning logs will appear in the FE log, as shown below: ``` 2024-06-11 17:50:04,360 WARN (InternalSchemaInitializer|137) [InternalSchemaInitializer.modifyTblReplicaCount():146] Failed to scale replica of stats tbl:column_statistics to 3 org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = errCode = 2, detailMessage = Failed to find enough backend, please check the replication num,replication tag and storage medium and avail capacity of backends. Create failed replications: replication tag: {"location" : "default"}, replication num: 3, storage medium: null at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocationImpl(PropertyAnalyzer.java:1217) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocation(PropertyAnalyzer.java:1136) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.modifyTableReplicaAllocation(Env.java:4868) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.modifyTblReplicaCount(InternalSchemaInitializer.java:123) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.run(InternalSchemaInitializer.java:93) ~[doris-fe.jar:1.2-SNAPSHOT] ```  This is because the computing node is also considered a replica in the code, and the computing node does not have storage resources, resulting in an error message. --------- Co-authored-by: camby <104178625@qq.com>
…chema three replica (#36130) ## Proposed changes Issue Number: close #xxx When I add computing nodes to the cluster, a large number of warning logs will appear in the FE log, as shown below: ``` 2024-06-11 17:50:04,360 WARN (InternalSchemaInitializer|137) [InternalSchemaInitializer.modifyTblReplicaCount():146] Failed to scale replica of stats tbl:column_statistics to 3 org.apache.doris.common.AnalysisException: errCode = 2, detailMessage = errCode = 2, detailMessage = Failed to find enough backend, please check the replication num,replication tag and storage medium and avail capacity of backends. Create failed replications: replication tag: {"location" : "default"}, replication num: 3, storage medium: null at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocationImpl(PropertyAnalyzer.java:1217) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.common.util.PropertyAnalyzer.analyzeReplicaAllocation(PropertyAnalyzer.java:1136) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.Env.modifyTableReplicaAllocation(Env.java:4868) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.modifyTblReplicaCount(InternalSchemaInitializer.java:123) ~[doris-fe.jar:1.2-SNAPSHOT] at org.apache.doris.catalog.InternalSchemaInitializer.run(InternalSchemaInitializer.java:93) ~[doris-fe.jar:1.2-SNAPSHOT] ```  This is because the computing node is also considered a replica in the code, and the computing node does not have storage resources, resulting in an error message. --------- Co-authored-by: camby <104178625@qq.com>
Proposed changes
Issue Number: close #xxx
When I add computing nodes to the cluster, a large number of warning logs will appear in the FE log, as shown below:
This is because the computing node is also considered a replica in the code, and the computing node does not have storage resources, resulting in an error message.