Skip to content

[improvement](compaction) be do not compact invisible version to avoid query error -230 #28082 #36222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jun 27, 2024
Merged

[improvement](compaction) be do not compact invisible version to avoid query error -230 #28082 #36222

dataroaring merged 2 commits into from
Jun 27, 2024

Conversation

@yujun777
Copy link
Contributor

@yujun777 yujun777 commented Jun 13, 2024

cherry pick from #28082

@yujun777
Copy link
Contributor Author

yujun777 commented Jun 13, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 13, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@yujun777 yujun777 marked this pull request as draft June 13, 2024 03:49
github-actions[bot]
github-actions bot reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

be/src/olap/olap_common.h

#pragma once

#include <gen_cpp/Types_types.h>
Copy link
Contributor

@github-actions github-actions bot Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/Types_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/Types_types.h>
         ^

@doris-robot
Copy link

doris-robot commented Jun 13, 2024

TeamCity be ut coverage result:
Function Coverage: 36.26% (9118/25145)
Line Coverage: 27.77% (74201/267206)
Region Coverage: 26.70% (38284/143372)
Branch Coverage: 23.39% (19398/82928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/676138d4bfb7c13e93784e2b9995c772d4595c2f_676138d4bfb7c13e93784e2b9995c772d4595c2f/report/index.html

@yujun777
Copy link
Contributor Author

yujun777 commented Jun 13, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 13, 2024

TeamCity be ut coverage result:
Function Coverage: 36.27% (9119/25145)
Line Coverage: 27.77% (74207/267206)
Region Coverage: 26.71% (38291/143372)
Branch Coverage: 23.40% (19404/82928)
Coverage Report: http://coverage.selectdb-in.cc/coverage/938a47a576ba89e97cdd9b5882431cf702ee3326_938a47a576ba89e97cdd9b5882431cf702ee3326/report/index.html

@yujun777 yujun777 force-pushed the pick_28082_to_upstream_branch-2.1 branch from 938a47a to af89032 Compare June 25, 2024 06:05
@yujun777 yujun777 marked this pull request as ready for review June 25, 2024 06:38
@yujun777
Copy link
Contributor Author

yujun777 commented Jun 25, 2024

run buildall

@doris-robot
Copy link

doris-robot commented Jun 25, 2024

TeamCity be ut coverage result:
Function Coverage: 36.33% (9145/25174)
Line Coverage: 27.87% (74594/267674)
Region Coverage: 26.78% (38476/143661)
Branch Coverage: 23.47% (19496/83068)
Coverage Report: http://coverage.selectdb-in.cc/coverage/af890324012b266a3ae2819da1ed185700a54383_af890324012b266a3ae2819da1ed185700a54383/report/index.html

@yujun777
Copy link
Contributor Author

yujun777 commented Jun 25, 2024

run feut

@dataroaring dataroaring merged commit 22cb7b8 into apache:branch-2.1 Jun 27, 2024
@yiguolei yiguolei mentioned this pull request Jul 19, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees

No one assigned

Labels

meta-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yujun777 @doris-robot @dataroaring