[Opt](streamload) Commit txn on BE coordinator in cloud mode to avoid RPC and lock overhead #36237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c and lock overhead
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
gavinchou
changed the title
gavinchou
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| put_result.params.is_mow_table) || | ||
| (put_result.__isset.pipeline_params && put_result.pipeline_params.__isset.is_mow_table && | ||
| put_result.pipeline_params.is_mow_table)) { | ||
| return true; |
Contributor
There was a problem hiding this comment.
warning: redundant boolean literal in conditional return statement [readability-simplify-boolean-expr]
be/src/runtime/stream_load/stream_load_context.cpp:353:
- if ((put_result.__isset.params && put_result.params.__isset.is_mow_table &&
- put_result.params.is_mow_table) ||
- (put_result.__isset.pipeline_params && put_result.pipeline_params.__isset.is_mow_table &&
- put_result.pipeline_params.is_mow_table)) {
- return true;
- }
- return false;
+ return (put_result.__isset.params && put_result.params.__isset.is_mow_table &&
+ put_result.params.is_mow_table) ||
+ (put_result.__isset.pipeline_params && put_result.pipeline_params.__isset.is_mow_table &&
+ put_result.pipeline_params.is_mow_table);
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39630 ms |
TPC-DS: Total hot run time: 173660 ms |
ClickBench: Total hot run time: 31.7 s |
Contributor
Author
|
refer to #34548 |
gavinchou
force-pushed
the
gavin-fix-strema-load-commit-txn
branch
from
5dbd545 to
062b257
Compare
Contributor
Author
|
run buildall |
gavinchou
force-pushed
the
gavin-fix-strema-load-commit-txn
branch
from
062b257 to
22b306e
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
|
TeamCity be ut coverage result: |
TPC-H: Total hot run time: 39877 ms |
TPC-DS: Total hot run time: 173411 ms |
ClickBench: Total hot run time: 30.74 s |
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Jun 18, 2024
Fix incomplete optimization introduced by apache#36237 [Opt](streamload) Commit txn on BE coordinator in cloud mode to avoid RPC and lock overhead (apache#36237)
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Jun 18, 2024
Fix incomplete optimization introduced by apache#36237 [Opt](streamload) Commit txn on BE coordinator in cloud mode to avoid RPC and lock overhead (apache#36237)
gavinchou
added a commit
to gavinchou/doris
that referenced
this pull request
Jun 19, 2024
Fix incomplete optimization introduced by apache#36237 [Opt](streamload) Commit txn on BE coordinator in cloud mode to avoid RPC and lock overhead (apache#36237)
gavinchou
added a commit
that referenced
this pull request
Jun 20, 2024
iszhangpch
pushed a commit
to iszhangpch/doris-p
that referenced
this pull request
Jun 21, 2024
…troduced by apache#36237 (apache#36496) Fix incomplete optimization introduced by apache#36237 [Opt](streamload) Commit txn on BE coordinator in cloud mode to avoid RPC and lock overhead (apache#36237)
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
… RPC and lock overhead (#36237) In cloud mode, FE master is not mandatory for committing load txn, and there is overhead (locks and PRC) if we commit load txn via FE master.
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jul 6, 2024
…7347) ## Proposed changes introduce by #36237 If meets some error like `out of range`, routine load job state should change from running to pause. When rollback transaction, the RPC will send to meta service directly, which can not change state by transaction information. This pr sends RPC to FE first to solve this problem.
dataroaring
pushed a commit
that referenced
this pull request
Jul 6, 2024
…7347) ## Proposed changes introduce by #36237 If meets some error like `out of range`, routine load job state should change from running to pause. When rollback transaction, the RPC will send to meta service directly, which can not change state by transaction information. This pr sends RPC to FE first to solve this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cloud mode, FE master is not mandatory for committing load txn, and there is overhead (locks and PRC) if we commit load txn via FE master.