-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](schema change) reduce memory usage of create a good deal of shadow tablets in schema change process #36285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 40194 ms |
TPC-DS: Total hot run time: 173595 ms |
ClickBench: Total hot run time: 30.88 s |
|
run buildall |
TPC-H: Total hot run time: 39822 ms |
TPC-DS: Total hot run time: 171949 ms |
ClickBench: Total hot run time: 30.11 s |
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 40324 ms |
TPC-DS: Total hot run time: 172218 ms |
ClickBench: Total hot run time: 30.83 s |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
| try { | ||
| BinlogConfig binlogConfig = new BinlogConfig(tbl.getBinlogConfig()); | ||
| Preconditions.checkState(tbl.getState() == OlapTableState.ROLLUP); | ||
| Map<Object, Object> objectPool = new HashMap<Object, Object>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use a concurrent map.
…dow tablets in schema change process (#36285) When doing schema change, it will create many shadow tablets. And many TCreateTabletReq will be new. So we can use object pool to reduct they memory usage.
When doing schema change, it will create many shadow tablets. And many TCreateTabletReq will be new. So we can use object pool to reduct they memory usage.