[Fix](auto-partition) fix auto partition expr change unexpected #36345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39786 ms |
TPC-DS: Total hot run time: 173315 ms |
ClickBench: Total hot run time: 31.19 s |
Contributor
Author
|
run buildall |
zclllyybb
changed the title
TPC-H: Total hot run time: 40733 ms |
TPC-DS: Total hot run time: 171740 ms |
ClickBench: Total hot run time: 30.61 s |
zclllyybb
changed the title
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39443 ms |
TPC-DS: Total hot run time: 173128 ms |
ClickBench: Total hot run time: 30.52 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39495 ms |
TPC-DS: Total hot run time: 172730 ms |
ClickBench: Total hot run time: 30.35 s |
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40502 ms |
TPC-DS: Total hot run time: 173106 ms |
ClickBench: Total hot run time: 30.46 s |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
zhangstar333
approved these changes
Jun 18, 2024
zclllyybb
added a commit
to zclllyybb/doris
that referenced
this pull request
Jun 19, 2024
…he#36345) ## Proposed changes Issue Number: close #xxx there's a caller used `getPartitionExprs` and modified the result. the result is a reference to a part of metadata. If when we create the table, the number of editlog didn't reach the limit to generate image file, when it reaches, the image will get the wrong metadata of `partitionExprs` from memory which was modified. currently we don't know why, but this root cause has been confirmed by: ```java private void analyzerPartitionExpr(Analyzer analyzer, PartitionInfo partitionInfo) throws AnalysisException { ArrayList<Expr> exprs = partitionInfo.getPartitionExprs(); for (Expr e : exprs) { LOG.info("beforeB: {}", e.toSql()); e.analyze(analyzer); LOG.info("afterB: {}", e.toSql()); } } ``` ```log 2024-06-18 21:49:07,449 INFO (mysql-nio-pool-154|695) [OlapScanNode.analyzerPartitionExpr():1561] beforeB: date_trunc(Carding_Day, 'MONTH') 2024-06-18 21:49:07,449 INFO (mysql-nio-pool-154|695) [OlapScanNode.analyzerPartitionExpr():1563] afterB: date_trunc(`a`.null, 'MONTH') ```
morningman
pushed a commit
that referenced
this pull request
Jun 20, 2024
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
## Proposed changes
Issue Number: close #xxx
there's a caller used `getPartitionExprs` and modified the result. the
result is a reference to a part of metadata. If when we create the
table, the number of editlog didn't reach the limit to generate image
file, when it reaches, the image will get the wrong metadata of
`partitionExprs` from memory which was modified.
currently we don't know why, but this root cause has been confirmed by:
```java
private void analyzerPartitionExpr(Analyzer analyzer, PartitionInfo partitionInfo) throws AnalysisException {
ArrayList<Expr> exprs = partitionInfo.getPartitionExprs();
for (Expr e : exprs) {
LOG.info("beforeB: {}", e.toSql());
e.analyze(analyzer);
LOG.info("afterB: {}", e.toSql());
}
}
```
```log
2024-06-18 21:49:07,449 INFO (mysql-nio-pool-154|695) [OlapScanNode.analyzerPartitionExpr():1561] beforeB: date_trunc(Carding_Day, 'MONTH')
2024-06-18 21:49:07,449 INFO (mysql-nio-pool-154|695) [OlapScanNode.analyzerPartitionExpr():1563] afterB: date_trunc(`a`.null, 'MONTH')
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #xxx
there's a caller used
getPartitionExprsand modified the result. the result is a reference to a part of metadata. If when we create the table, the number of editlog didn't reach the limit to generate image file, when it reaches, the image will get the wrong metadata ofpartitionExprsfrom memory which was modified.when Nereids timeout, we will get into trouble in legacy planner here: