-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[opt](meta) put normal partitions into recyclebin when replacing partitions #36361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
Please handle truncate too, and add regression test. |
|
run buildall |
TPC-H: Total hot run time: 39566 ms |
TPC-DS: Total hot run time: 173985 ms |
ClickBench: Total hot run time: 30.35 s |
e3add86 to
43ad8ce
Compare
|
run buildall |
43ad8ce to
13bb106
Compare
|
run buildall |
13bb106 to
43ab7fd
Compare
|
run buildall |
TPC-H: Total hot run time: 39727 ms |
TPC-DS: Total hot run time: 171893 ms |
ClickBench: Total hot run time: 30.83 s |
253f055 to
4f6c77a
Compare
|
run buildall |
TPC-H: Total hot run time: 40320 ms |
|
run buildall |
zddr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
| @SerializedName(value = "versionTime") | ||
| private long versionTime = 0L; | ||
| @SerializedName(value = "force") | ||
| private boolean force = FeConstants.DEFAULT_DROP_NORMAL_PARTITION_WHEN_REPLACE_PARTITION; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default to false.
00ae8f2 to
bc0309d
Compare
|
run buildall |
TPC-H: Total hot run time: 40035 ms |
TPC-DS: Total hot run time: 172633 ms |
ClickBench: Total hot run time: 31.03 s |
46c7c61 to
b0526af
Compare
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 39903 ms |
TPC-DS: Total hot run time: 170504 ms |
ClickBench: Total hot run time: 30.18 s |
b0526af to
35210d8
Compare
|
run buildall |
TPC-H: Total hot run time: 39766 ms |
TPC-DS: Total hot run time: 173200 ms |
ClickBench: Total hot run time: 30.48 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed changes
Issue Number: close #36714
Move the old partitions to recycle bin when replacing partition.