-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](split) FileSystemCacheKey are always different in overload equals #36432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
1 similar comment
|
run buildall |
TPC-H: Total hot run time: 39501 ms |
TPC-DS: Total hot run time: 170365 ms |
ClickBench: Total hot run time: 30.58 s |
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
This reverts commit efe8e4c.
|
run buildall |
TPC-H: Total hot run time: 39609 ms |
TPC-DS: Total hot run time: 169596 ms |
ClickBench: Total hot run time: 30.25 s |
…ls (#36431) bp: #36432 ## Proposed changes ## Fixed Bugs introduced from #34307 1. `FileSystemCacheKey.equals()` compares properties by `==`, resulting in creating new file system in each partition 2. `dfsFileSystem` is not synchronized, resulting in creating more file systems than need. 3. `jobConf.iterator()` will produce more than 2000 pairs of key-value
|
PR approved by at least one committer and no changes requested. |
kaka11chen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ls (apache#36432) ## Proposed changes ## Fixed Bugs introduced from apache#33937 1. `FileSystemCacheKey.equals()` compares properties by `==`, resulting in creating new file system in each partition 2. `dfsFileSystem` is not synchronized, resulting in creating more file systems than need. 3. `jobConf.iterator()` will produce more than 2000 pairs of key-value
…ls (#36432) ## Proposed changes ## Fixed Bugs introduced from #33937 1. `FileSystemCacheKey.equals()` compares properties by `==`, resulting in creating new file system in each partition 2. `dfsFileSystem` is not synchronized, resulting in creating more file systems than need. 3. `jobConf.iterator()` will produce more than 2000 pairs of key-value
Proposed changes
Fixed Bugs introduced from #33937
FileSystemCacheKey.equals()compares properties by==, resulting in creating new file system in each partitiondfsFileSystemis not synchronized, resulting in creating more file systems than need.jobConf.iterator()will produce more than 2000 pairs of key-value