[refactor](variant) refactor sub path push down on variant type #36478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
Contributor
Author
|
run buildall |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
from
78d172c to
ef7c773
Compare
Contributor
Author
|
run buildall |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
2 times, most recently
from
09d4cc3 to
e728e47
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 39934 ms |
TPC-DS: Total hot run time: 175748 ms |
ClickBench: Total hot run time: 31.2 s |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
2 times, most recently
from
7b2546a to
cf24bb2
Compare
Contributor
Author
|
run buildall |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
2 times, most recently
from
7e0e2de to
d5617fe
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 40076 ms |
TPC-DS: Total hot run time: 173463 ms |
ClickBench: Total hot run time: 30.93 s |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
from
d5617fe to
cc9cdaf
Compare
Contributor
Author
|
run buildall |
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40522 ms |
TPC-DS: Total hot run time: 173610 ms |
|
TeamCity be ut coverage result: |
ClickBench: Total hot run time: 30.72 s |
morrySnow
force-pushed
the
refactor_variant_element_at
branch
from
cc9cdaf to
e2479a6
Compare
Contributor
Author
|
run buildall |
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path
morrySnow
force-pushed
the
refactor_variant_element_at
branch
from
b9eff65 to
8125377
Compare
Contributor
Author
|
run buildall |
github-actions
bot
removed
the
approved
TPC-H: Total hot run time: 39720 ms |
Contributor
Author
|
run performance |
starocean999
approved these changes
Jun 21, 2024
Contributor
|
PR approved by at least one committer and no changes requested. |
github-actions
bot
added
the
approved
TPC-H: Total hot run time: 40108 ms |
TPC-DS: Total hot run time: 172351 ms |
ClickBench: Total hot run time: 30.49 s |
924060929
approved these changes
Jun 21, 2024
iszhangpch
pushed a commit
to iszhangpch/doris-p
that referenced
this pull request
Jun 21, 2024
…he#36478) intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path. for example, variant slot v in table t has two sub path: 'c1' and 'c2', after this rule, select v['c1'] from t will only scan one sub path 'c1' of v to reduce scan time. This rule accomplishes all the work using two components. The Collector traverses from the top down, collecting all the element_at functions on the variant types, and recording the required path from the original variant slot to the current element_at. The Replacer traverses from the bottom up, generating the slots for the required sub path on scan, union, and cte consumer. Then, it replaces the element_at with the corresponding slot.
dataroaring
pushed a commit
that referenced
this pull request
Jun 21, 2024
intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path. for example, variant slot v in table t has two sub path: 'c1' and 'c2', after this rule, select v['c1'] from t will only scan one sub path 'c1' of v to reduce scan time. This rule accomplishes all the work using two components. The Collector traverses from the top down, collecting all the element_at functions on the variant types, and recording the required path from the original variant slot to the current element_at. The Replacer traverses from the bottom up, generating the slots for the required sub path on scan, union, and cte consumer. Then, it replaces the element_at with the corresponding slot.
morrySnow
added a commit
to morrySnow/incubator-doris
that referenced
this pull request
Jun 27, 2024
…he#36478) pick from master apache#36478 intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path. for example, variant slot v in table t has two sub path: 'c1' and 'c2', after this rule, select v['c1'] from t will only scan one sub path 'c1' of v to reduce scan time. This rule accomplishes all the work using two components. The Collector traverses from the top down, collecting all the element_at functions on the variant types, and recording the required path from the original variant slot to the current element_at. The Replacer traverses from the bottom up, generating the slots for the required sub path on scan, union, and cte consumer. Then, it replaces the element_at with the corresponding slot.
morrySnow
added a commit
that referenced
this pull request
Jun 27, 2024
…) (#36923) pick from master #36478 intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path. for example, variant slot v in table t has two sub path: 'c1' and 'c2', after this rule, select v['c1'] from t will only scan one sub path 'c1' of v to reduce scan time. This rule accomplishes all the work using two components. The Collector traverses from the top down, collecting all the element_at functions on the variant types, and recording the required path from the original variant slot to the current element_at. The Replacer traverses from the bottom up, generating the slots for the required sub path on scan, union, and cte consumer. Then, it replaces the element_at with the corresponding slot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
intro a new rule VARIANT_SUB_PATH_PRUNING to prune variant sub path.
for example, variant slot v in table t has two sub path: 'c1' and 'c2', after this rule, select v['c1'] from t will only scan one sub path 'c1' of v to reduce scan time.
This rule accomplishes all the work using two components. The Collector traverses from the top down, collecting all the element_at functions on the variant types, and recording the required path from the original variant slot to the current element_at. The Replacer traverses from the bottom up, generating the slots for the required sub path on scan, union, and cte consumer. Then, it replaces the element_at with the corresponding slot.