Skip to content

[function](signature) add datev2 signature for from_days function #36505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhangstar333 merged 2 commits into from
Jun 20, 2024
Merged

[function](signature) add datev2 signature for from_days function #36505

zhangstar333 merged 2 commits into from
Jun 20, 2024

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Jun 19, 2024

Proposed changes

add datev2 signature for from_days function

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 19, 2024

run buildall

@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Jun 19, 2024

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 19, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2024

PR approved by anyone and no changes requested.

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TPC-H: Total hot run time: 40093 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 160b2dee6ec3a0db03fe8570e7cabfc4bedf6b86, data reload: false

------ Round 1 ----------------------------------
q1	18011	4551	4433	4433
q2	2366	193	197	193
q3	10454	1114	1073	1073
q4	10180	824	770	770
q5	7510	2661	2662	2661
q6	229	136	135	135
q7	956	614	616	614
q8	9308	2061	2109	2061
q9	8943	6502	6467	6467
q10	8876	3751	3722	3722
q11	452	246	237	237
q12	405	242	225	225
q13	19006	2967	2975	2967
q14	265	235	229	229
q15	531	473	479	473
q16	530	393	380	380
q17	976	674	775	674
q18	8162	7472	7365	7365
q19	5330	1569	1512	1512
q20	652	314	324	314
q21	4993	3904	3260	3260
q22	383	334	328	328
Total cold run time: 118518 ms
Total hot run time: 40093 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4384	4202	4211	4202
q2	361	271	262	262
q3	2921	2740	2725	2725
q4	1880	1589	1650	1589
q5	5280	5288	5264	5264
q6	212	126	124	124
q7	2090	1726	1698	1698
q8	3181	3329	3284	3284
q9	8331	8346	8304	8304
q10	3914	3704	3675	3675
q11	593	478	514	478
q12	768	589	613	589
q13	17283	2986	3015	2986
q14	312	253	249	249
q15	514	486	480	480
q16	465	407	432	407
q17	1808	1476	1468	1468
q18	7758	7410	7401	7401
q19	1664	1609	1608	1608
q20	1993	1772	1767	1767
q21	4994	4775	4744	4744
q22	597	535	549	535
Total cold run time: 71303 ms
Total hot run time: 53839 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

TPC-DS: Total hot run time: 172504 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 160b2dee6ec3a0db03fe8570e7cabfc4bedf6b86, data reload: false

query1	934	383	372	372
query2	6456	2378	2300	2300
query3	6651	205	208	205
query4	21932	17427	17186	17186
query5	4169	501	460	460
query6	243	161	160	160
query7	4587	309	292	292
query8	306	279	290	279
query9	8625	2398	2370	2370
query10	624	325	297	297
query11	10807	10074	9966	9966
query12	142	86	84	84
query13	1655	356	366	356
query14	9625	7627	7014	7014
query15	231	186	188	186
query16	7796	266	268	266
query17	1916	537	531	531
query18	1902	272	269	269
query19	202	153	157	153
query20	98	86	85	85
query21	208	136	124	124
query22	4273	4079	3934	3934
query23	33704	33025	33098	33025
query24	12059	2776	2841	2776
query25	662	359	355	355
query26	1832	151	154	151
query27	3081	310	314	310
query28	7594	2047	2020	2020
query29	1139	609	606	606
query30	292	149	150	149
query31	950	737	764	737
query32	96	53	57	53
query33	770	282	277	277
query34	1017	473	466	466
query35	726	604	610	604
query36	1074	950	928	928
query37	294	71	72	71
query38	2892	2788	2772	2772
query39	865	804	801	801
query40	285	133	128	128
query41	56	53	54	53
query42	121	99	104	99
query43	588	530	527	527
query44	1210	722	733	722
query45	199	168	167	167
query46	1097	723	729	723
query47	1907	1799	1789	1789
query48	373	298	293	293
query49	1184	410	398	398
query50	769	390	388	388
query51	6802	6727	6616	6616
query52	105	90	93	90
query53	370	286	299	286
query54	1019	435	427	427
query55	75	73	73	73
query56	277	250	259	250
query57	1157	1057	1053	1053
query58	246	248	238	238
query59	3492	3277	3203	3203
query60	293	297	264	264
query61	94	90	92	90
query62	656	437	435	435
query63	320	287	289	287
query64	9865	2213	1769	1769
query65	3338	3117	3076	3076
query66	1381	342	391	342
query67	15274	15052	15222	15052
query68	4573	538	534	534
query69	496	400	362	362
query70	1129	1154	1148	1148
query71	396	274	278	274
query72	7234	5296	5645	5296
query73	750	323	320	320
query74	5956	5523	5514	5514
query75	3495	2646	2650	2646
query76	2744	926	902	902
query77	437	288	297	288
query78	10265	9797	9766	9766
query79	2120	511	509	509
query80	987	463	459	459
query81	539	217	217	217
query82	825	110	103	103
query83	255	166	168	166
query84	236	82	84	82
query85	1941	350	266	266
query86	487	326	311	311
query87	3331	3107	3118	3107
query88	4144	2352	2321	2321
query89	468	379	390	379
query90	1807	206	191	191
query91	126	100	98	98
query92	71	51	50	50
query93	2439	521	503	503
query94	1267	186	187	186
query95	404	314	311	311
query96	590	274	273	273
query97	3270	3089	3046	3046
query98	205	208	206	206
query99	1237	851	842	842
Total cold run time: 279206 ms
Total hot run time: 172504 ms

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

ClickBench: Total hot run time: 30.3 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 160b2dee6ec3a0db03fe8570e7cabfc4bedf6b86, data reload: false

query1	0.04	0.03	0.03
query2	0.07	0.04	0.04
query3	0.22	0.05	0.06
query4	1.68	0.08	0.08
query5	0.50	0.51	0.48
query6	1.13	0.74	0.73
query7	0.02	0.01	0.01
query8	0.05	0.04	0.04
query9	0.54	0.48	0.49
query10	0.52	0.53	0.54
query11	0.17	0.11	0.12
query12	0.15	0.11	0.12
query13	0.59	0.58	0.59
query14	0.79	0.77	0.78
query15	0.85	0.82	0.80
query16	0.36	0.37	0.37
query17	0.96	1.02	1.02
query18	0.23	0.25	0.25
query19	1.77	1.79	1.72
query20	0.01	0.01	0.02
query21	15.45	0.67	0.67
query22	3.80	8.20	1.62
query23	18.28	1.43	1.33
query24	2.11	0.22	0.21
query25	0.14	0.08	0.09
query26	0.28	0.18	0.18
query27	0.08	0.08	0.08
query28	13.29	1.02	1.01
query29	12.63	3.29	3.25
query30	0.26	0.06	0.07
query31	2.83	0.38	0.39
query32	3.29	0.46	0.46
query33	2.87	2.86	2.82
query34	17.02	4.43	4.48
query35	4.48	4.51	4.46
query36	0.65	0.46	0.46
query37	0.18	0.15	0.15
query38	0.15	0.15	0.14
query39	0.04	0.03	0.04
query40	0.17	0.14	0.14
query41	0.09	0.05	0.05
query42	0.05	0.05	0.04
query43	0.04	0.04	0.04
Total cold run time: 108.83 s
Total hot run time: 30.3 s

@wm1581066 wm1581066 requested a review from HappenLee June 20, 2024 00:31
HappenLee
HappenLee approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhangstar333 zhangstar333 merged commit f730787 into apache:master Jun 20, 2024
iszhangpch pushed a commit to iszhangpch/doris-p that referenced this pull request Jun 21, 2024
@zhangstar333
[function](signature) add datev2 signature for from_days function (ap…
dcc156b 
…ache#36505)

## Proposed changes
add datev2 signature for from_days function
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@zhangstar333 @dataroaring
[function](signature) add datev2 signature for from_days function (#3…
fbceacc 
…6505)

## Proposed changes
add datev2 signature for from_days function
zhangstar333 added a commit to zhangstar333/incubator-doris that referenced this pull request Jul 15, 2024
@zhangstar333
[function](signature) add datev2 signature for from_days function (ap…
15c9d04 
…ache#36505)

## Proposed changes
add datev2 signature for from_days function
@zhangstar333 zhangstar333 mentioned this pull request Jul 15, 2024
Merged
yiguolei pushed a commit that referenced this pull request Jul 15, 2024
@zhangstar333
[cherry-pick](branch-21) fix cast string to int return wrong result (#…
03e21dd 
…36788) (#37803)

## Proposed changes
cherry-pick from master:
#36788
#36505

<!--Describe your changes.-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HappenLee HappenLee HappenLee approved these changes

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.5-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@zhangstar333 @doris-robot @HappenLee @morrySnow @yiguolei @dataroaring