-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](partition rebalance) improve partition rebalance choose candidate speed #36509
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improvement](partition rebalance) improve partition rebalance choose candidate speed #36509
Conversation
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
deardeng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 40085 ms |
TPC-DS: Total hot run time: 173237 ms |
ClickBench: Total hot run time: 30.25 s |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
|
run buildall |
58591e6 to
3cd9670
Compare
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 39837 ms |
TPC-DS: Total hot run time: 171620 ms |
ClickBench: Total hot run time: 31.29 s |
|
run feut |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
PR approved by at least one committer and no changes requested. |
… candidate speed (apache#36509) When partition reblancer choose candidate tablets, it will call tabletListOfA.removeAll(tabletListOfB), but list.removeAll(list)'s runtime is O(n^2). Then if each BE contains 10w+ tablets, it's rather slow. And we found a online case the tablet scheduler thread is busy at it. So need improve this search.
… candidate speed (#36509) When partition reblancer choose candidate tablets, it will call tabletListOfA.removeAll(tabletListOfB), but list.removeAll(list)'s runtime is O(n^2). Then if each BE contains 10w+ tablets, it's rather slow. And we found a online case the tablet scheduler thread is busy at it. So need improve this search.
… candidate speed apache#36509 (apache#36978) cherry pick from apache#36509
When partition reblancer choose candidate tablets, it will call tabletListOfA.removeAll(tabletListOfB), but list.removeAll(list)'s runtime is O(n^2). Then if each BE contains 10w+ tablets, it's rather slow. And we found a online case the tablet scheduler thread is busy at it.
So need improve this search.
Proposed changes
Issue Number: close #xxx