Skip to content

Conversation

@HangyuanLiu
Copy link
Contributor

1、Modify hll_hash function return type to HLL
2、Make HLL_RAW_AGG is alias of HLL_UNION
For #3652

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fail to compile BE, you should make this script work when there is HLL type

@HangyuanLiu HangyuanLiu self-assigned this May 22, 2020
@HangyuanLiu HangyuanLiu added area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature. labels May 22, 2020
Copy link
Contributor

@imay imay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imay imay added the approved Indicates a PR has been approved by one committer. label May 23, 2020
@imay imay merged commit 838c1e9 into apache:master May 24, 2020
@HangyuanLiu HangyuanLiu deleted the hll_union branch May 30, 2020 12:53
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/sql/function Issues or PRs related to the SQL functions kind/feature Categorizes issue or PR as related to a new feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants