Skip to content

Conversation

@csun5285
Copy link
Contributor

@csun5285 csun5285 commented Jun 19, 2024

Proposed changes

  1. Fix BUG, when multiple cases concurrently modify the BE config 'disable_auto_compaction' to false, then true, and back to false.
  2. remove unused code.
  3. fix unstable single compaction test

Issue Number: close #xxx

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@csun5285
Copy link
Contributor Author

run buildall

airborne12
airborne12 previously approved these changes Jun 20, 2024
Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@csun5285
Copy link
Contributor Author

run buildall

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@csun5285 csun5285 force-pushed the fix_compaction_test branch from 5d3b3fb to 5bfecc3 Compare July 18, 2024 15:23
@csun5285
Copy link
Contributor Author

run buildall

@csun5285 csun5285 changed the title [fix] (regression test) Fix the errors caused by changing the BE config: disable_auto_compaction [fix] (regression test) Fix unstable regression test Jul 18, 2024
@csun5285
Copy link
Contributor Author

run buildall

@csun5285 csun5285 force-pushed the fix_compaction_test branch from 7d6436b to 6afbb58 Compare August 5, 2024 06:11
@github-actions github-actions bot added the doing label Aug 5, 2024
@csun5285
Copy link
Contributor Author

csun5285 commented Aug 5, 2024

run buildall

Copy link
Member

@airborne12 airborne12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 5, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2024

PR approved by at least one committer and no changes requested.

@qidaye qidaye merged commit 1190ae2 into apache:master Aug 5, 2024
dataroaring pushed a commit that referenced this pull request Aug 8, 2024
## Proposed changes
1. Fix BUG, when multiple cases concurrently modify the BE config
'disable_auto_compaction' to false, then true, and back to false.
2. remove unused code.
3. fix fault injection
airborne12 pushed a commit that referenced this pull request Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.6-merged dev/3.0.1-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants