Skip to content

[fix](Nereids) should check it is Slot before check it is DELETE_SIGN #36564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
starocean999 merged 1 commit into from
Jun 20, 2024
Merged

[fix](Nereids) should check it is Slot before check it is DELETE_SIGN #36564

starocean999 merged 1 commit into from
Jun 20, 2024

Conversation

@morrySnow
Copy link
Contributor

@morrySnow morrySnow commented Jun 19, 2024

introduced by #35823

@doris-robot
Copy link

doris-robot commented Jun 19, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@morrySnow
Copy link
Contributor Author

morrySnow commented Jun 19, 2024

run buildall

@morrySnow morrySnow requested a review from eldenmoon June 19, 2024 13:07
@morrySnow morrySnow mentioned this pull request Jun 19, 2024
Merged
@morrySnow
Copy link
Contributor Author

morrySnow commented Jun 20, 2024

run performance

eldenmoon
eldenmoon approved these changes Jun 20, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 20, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Jun 20, 2024

PR approved by anyone and no changes requested.

morrySnow added a commit that referenced this pull request Jun 20, 2024
@morrySnow
[fix](point query) should check it is Slot before check it is DELETE_…
9c1f343 
…SIGN (#36566)

pick from master #36564

introduced by #36443
@morrySnow
Copy link
Contributor Author

morrySnow commented Jun 20, 2024

run performance

@doris-robot
Copy link

doris-robot commented Jun 20, 2024

TPC-H: Total hot run time: 39670 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit bc6ef41be2b5d005cd9c55fb70a2341d262b7856, data reload: false

------ Round 1 ----------------------------------
q1	17597	4342	4301	4301
q2	2036	198	192	192
q3	10456	1179	1050	1050
q4	10211	849	820	820
q5	7503	2703	2638	2638
q6	232	135	135	135
q7	971	602	605	602
q8	9235	2086	2086	2086
q9	8874	6496	6487	6487
q10	8952	3697	3730	3697
q11	443	230	235	230
q12	413	221	230	221
q13	18791	2974	3010	2974
q14	263	213	221	213
q15	526	474	466	466
q16	539	389	376	376
q17	972	639	693	639
q18	7962	7421	7367	7367
q19	1644	1417	1465	1417
q20	684	315	321	315
q21	4861	3115	3946	3115
q22	398	344	329	329
Total cold run time: 113563 ms
Total hot run time: 39670 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4365	4252	4242	4242
q2	363	266	255	255
q3	2971	2725	2841	2725
q4	2075	1735	1720	1720
q5	5514	5632	5530	5530
q6	222	127	131	127
q7	2247	1806	1853	1806
q8	3275	3427	3407	3407
q9	8659	8616	8763	8616
q10	4078	3849	3838	3838
q11	598	515	478	478
q12	755	615	637	615
q13	15959	3154	3147	3147
q14	300	256	280	256
q15	523	487	494	487
q16	482	438	435	435
q17	1959	1518	1485	1485
q18	8095	7933	7803	7803
q19	2846	1610	1623	1610
q20	2137	1861	1858	1858
q21	5118	5039	5023	5023
q22	624	552	534	534
Total cold run time: 73165 ms
Total hot run time: 55997 ms

@starocean999 starocean999 merged commit cdcb02a into apache:master Jun 20, 2024
@morrySnow morrySnow deleted the fix_short_c branch June 20, 2024 11:40
iszhangpch pushed a commit to iszhangpch/doris-p that referenced this pull request Jun 21, 2024
@morrySnow
[fix](Nereids) should check it is Slot before check it is DELETE_SIGN (…
5c1924e 
…apache#36564)

introduced by apache#35823
dataroaring pushed a commit that referenced this pull request Jun 21, 2024
@morrySnow @dataroaring
[fix](Nereids) should check it is Slot before check it is DELETE_SIGN (…
32c8dec 
…#36564)

introduced by #35823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.4-merged dev/3.0.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@morrySnow @doris-robot @starocean999 @eldenmoon @dataroaring