[bug](prepared statement) Fix an analysis bug in legacy planner #36703

xy720 · 2024-06-22T13:23:10Z

Proposed changes

Issue Number: close #xxx

java.lang.ClassCastException: org.apache.doris.analysis.PlaceHolderExpr cannot be cast to org.apache.doris.analysis.LargeIntLiteral
        at org.apache.doris.analysis.LargeIntLiteral.compareLiteral(LargeIntLiteral.java:181) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.analysis.PlaceHolderExpr.compareLiteral(PlaceHolderExpr.java:112) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.analysis.LiteralExpr.equals(LiteralExpr.java:310) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.common.Pair.equals(Pair.java:66) ~[fe-common-1.2-SNAPSHOT.jar:1.2-SNAPSHOT]
        at java.util.HashMap.getNode(HashMap.java:572) ~[?:1.8.0_272]
        at java.util.HashMap.containsKey(HashMap.java:596) ~[?:1.8.0_272]
        at java.util.HashSet.contains(HashSet.java:204) ~[?:1.8.0_272]
        at org.apache.doris.rewrite.InferFiltersRule.initAllStructure(InferFiltersRule.java:184) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.rewrite.InferFiltersRule.initAllStructure(InferFiltersRule.java:170) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.rewrite.InferFiltersRule.apply(InferFiltersRule.java:117) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.rewrite.ExprRewriter.applyRuleOnce(ExprRewriter.java:178) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.rewrite.ExprRewriter.rewrite(ExprRewriter.java:171) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.analysis.SelectStmt.rewriteExprs(SelectStmt.java:1856) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.analyzeAndGenerateQueryPlan(StmtExecutor.java:1165) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.analyze(StmtExecutor.java:1060) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.executeByLegacy(StmtExecutor.java:735) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:510) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.StmtExecutor.execute(StmtExecutor.java:475) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.handleExecute(ConnectProcessor.java:263) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.dispatch(ConnectProcessor.java:592) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.qe.ConnectProcessor.processOnce(ConnectProcessor.java:852) ~[doris-fe.jar:1.2-SNAPSHOT]
        at org.apache.doris.mysql.ReadListener.lambda$handleEvent$0(ReadListener.java:52) ~[doris-fe.jar:1.2-SNAPSHOT]
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149) ~[?:1.8.0_272]
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624) ~[?:1.8.0_272]
        at java.lang.Thread.run(Thread.java:748) ~[?:1.8.0_272]

doris-robot · 2024-06-22T13:23:14Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

xy720 · 2024-06-22T13:23:37Z

run buildall

doris-robot · 2024-06-22T14:01:00Z

TPC-H: Total hot run time: 39757 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 36b36b1140b12f41ad7daaa655ee768dc1576aa7, data reload: false

------ Round 1 ----------------------------------
q1	17623	4339	4240	4240
q2	2025	186	184	184
q3	10467	1170	1166	1166
q4	10185	823	775	775
q5	7459	2680	2619	2619
q6	224	136	135	135
q7	957	606	613	606
q8	9225	2062	2060	2060
q9	9144	6464	6457	6457
q10	8965	3750	3749	3749
q11	456	242	225	225
q12	465	222	239	222
q13	17762	3005	3010	3005
q14	259	218	218	218
q15	526	479	478	478
q16	498	379	370	370
q17	960	693	668	668
q18	7862	7378	7420	7378
q19	3872	1518	1407	1407
q20	651	306	315	306
q21	4963	3156	3921	3156
q22	392	333	337	333
Total cold run time: 114940 ms
Total hot run time: 39757 ms

----- Round 2, with runtime_filter_mode=off -----
q1	4335	4236	4219	4219
q2	372	270	265	265
q3	3046	2725	2898	2725
q4	1982	1692	1721	1692
q5	5614	5489	5548	5489
q6	221	139	133	133
q7	2182	1795	1880	1795
q8	3251	3422	3403	3403
q9	8658	8664	8751	8664
q10	4070	3966	3785	3785
q11	568	514	492	492
q12	807	641	602	602
q13	17011	3203	3157	3157
q14	301	283	256	256
q15	522	477	489	477
q16	510	448	422	422
q17	1838	1524	1500	1500
q18	8162	7971	7948	7948
q19	3865	1581	1559	1559
q20	2182	1890	1863	1863
q21	5097	4917	4890	4890
q22	597	566	554	554
Total cold run time: 75191 ms
Total hot run time: 55890 ms

doris-robot · 2024-06-22T14:12:19Z

TPC-DS: Total hot run time: 175251 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 36b36b1140b12f41ad7daaa655ee768dc1576aa7, data reload: false

query1	930	390	368	368
query2	6453	2503	2413	2413
query3	6634	210	224	210
query4	18860	17348	17348	17348
query5	3590	481	471	471
query6	241	161	168	161
query7	4575	293	289	289
query8	314	288	296	288
query9	8482	2369	2341	2341
query10	562	299	291	291
query11	11434	9989	10054	9989
query12	119	86	81	81
query13	1629	371	363	363
query14	10201	7706	7696	7696
query15	235	203	189	189
query16	7685	275	271	271
query17	1918	573	534	534
query18	1463	287	281	281
query19	209	153	155	153
query20	95	81	86	81
query21	215	129	129	129
query22	4461	4108	4042	4042
query23	34008	33717	33745	33717
query24	10576	2956	2873	2873
query25	608	423	391	391
query26	706	160	156	156
query27	2240	323	327	323
query28	5800	2141	2116	2116
query29	899	651	641	641
query30	263	156	162	156
query31	1002	786	761	761
query32	95	55	56	55
query33	674	308	304	304
query34	1055	507	493	493
query35	773	635	673	635
query36	1102	996	998	996
query37	159	75	79	75
query38	3121	2936	2908	2908
query39	899	837	863	837
query40	218	132	133	132
query41	60	58	56	56
query42	109	108	109	108
query43	601	547	562	547
query44	1103	741	759	741
query45	199	164	162	162
query46	1072	704	717	704
query47	1860	1789	1785	1785
query48	376	300	306	300
query49	860	420	430	420
query50	766	399	410	399
query51	6977	6772	6664	6664
query52	104	95	91	91
query53	355	290	290	290
query54	880	451	450	450
query55	76	73	74	73
query56	297	277	282	277
query57	1104	1043	1062	1043
query58	265	254	257	254
query59	3442	3346	3406	3346
query60	295	271	282	271
query61	97	92	108	92
query62	611	441	429	429
query63	320	293	290	290
query64	8495	2254	1725	1725
query65	3183	3068	3113	3068
query66	743	325	326	325
query67	15636	14809	14864	14809
query68	8572	540	565	540
query69	696	427	418	418
query70	1173	1140	1067	1067
query71	533	274	277	274
query72	9176	5469	5501	5469
query73	1923	325	326	325
query74	5915	5476	5551	5476
query75	4917	2645	2681	2645
query76	4980	968	969	968
query77	772	304	297	297
query78	10503	9806	9906	9806
query79	7965	517	510	510
query80	1038	467	497	467
query81	561	220	222	220
query82	715	103	99	99
query83	341	168	162	162
query84	268	85	86	85
query85	1256	293	263	263
query86	396	302	309	302
query87	3248	3098	3123	3098
query88	4479	2468	2483	2468
query89	533	380	373	373
query90	1977	191	223	191
query91	126	101	100	100
query92	57	47	51	47
query93	6250	508	500	500
query94	1168	191	187	187
query95	411	315	315	315
query96	604	270	272	270
query97	3204	2996	3005	2996
query98	207	193	191	191
query99	1197	867	845	845
Total cold run time: 289550 ms
Total hot run time: 175251 ms

doris-robot · 2024-06-22T14:17:51Z

ClickBench: Total hot run time: 30.69 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 36b36b1140b12f41ad7daaa655ee768dc1576aa7, data reload: false

query1	0.04	0.03	0.04
query2	0.08	0.04	0.04
query3	0.22	0.05	0.05
query4	1.69	0.09	0.10
query5	0.50	0.47	0.49
query6	1.14	0.72	0.72
query7	0.02	0.02	0.01
query8	0.05	0.05	0.05
query9	0.55	0.49	0.49
query10	0.55	0.52	0.53
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.59	0.58	0.59
query14	0.77	0.77	0.77
query15	0.86	0.81	0.80
query16	0.36	0.37	0.36
query17	0.93	1.00	0.98
query18	0.22	0.24	0.26
query19	1.88	1.76	1.67
query20	0.02	0.01	0.01
query21	15.42	0.65	0.64
query22	4.86	7.05	2.12
query23	18.25	1.45	1.20
query24	2.09	0.23	0.22
query25	0.16	0.08	0.08
query26	0.27	0.17	0.17
query27	0.09	0.08	0.08
query28	13.28	1.01	1.02
query29	12.63	3.40	3.38
query30	0.26	0.06	0.06
query31	2.91	0.38	0.37
query32	3.25	0.47	0.46
query33	2.87	2.88	2.91
query34	17.22	4.39	4.42
query35	4.50	4.44	4.48
query36	0.64	0.46	0.46
query37	0.19	0.16	0.17
query38	0.16	0.15	0.15
query39	0.05	0.04	0.04
query40	0.18	0.14	0.16
query41	0.10	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.05	0.04
Total cold run time: 110.27 s
Total hot run time: 30.69 s

lide-reed

LGTM

github-actions · 2024-06-24T02:34:50Z

PR approved by at least one committer and no changes requested.

github-actions · 2024-06-24T02:34:52Z

PR approved by anyone and no changes requested.

## Proposed changes Fix an analysis bug in legacy planner.

xy720 added 2 commits June 22, 2024 21:17

save

5d7f96c

save

36b36b1

lide-reed approved these changes Jun 24, 2024

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2024

github-actions bot added the reviewed label Jun 24, 2024

cambyzju approved these changes Jun 24, 2024

View reviewed changes

xy720 mentioned this pull request Jun 24, 2024

[bug](prepared statement) fix some bugs in legacy planner #36731

Merged

xy720 merged commit ebfc4f6 into apache:master Jun 24, 2024

dataroaring pushed a commit that referenced this pull request Jun 26, 2024

[bug](prepared statement) Fix an analysis bug in legacy planner (#36703)

483be85

## Proposed changes Fix an analysis bug in legacy planner.

dataroaring added the dev/3.0.0-merged label Aug 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[bug](prepared statement) Fix an analysis bug in legacy planner #36703

[bug](prepared statement) Fix an analysis bug in legacy planner #36703

Uh oh!

xy720 commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

xy720 commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

lide-reed left a comment

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[bug](prepared statement) Fix an analysis bug in legacy planner #36703

[bug](prepared statement) Fix an analysis bug in legacy planner #36703

Uh oh!

Conversation

xy720 commented Jun 22, 2024

Proposed changes

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

xy720 commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

doris-robot commented Jun 22, 2024

Uh oh!

lide-reed left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

github-actions bot commented Jun 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants